-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #98899
Closed
Closed
Rollup of 8 pull requests #98899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They never return `None`, so they trivially fulfill the contract.
Implement `FusedIterator` for `std::net::[Into]Incoming` They never return `None`, so they trivially fulfill the contract. What should I put for the stability attribute of `Incoming`?
Clarify MIR semantics of checked binary operations
…erister Enable raw-dylib for bin crates Fixes rust-lang#93842 When a `raw-dylib` is used in a `bin` crate, we need to link to the library name specified.
…r-span, r=oli-obk Improve spans for specialization error Fixes rust-lang#98777
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
…num-with-default-attribute, r=fee1-dead Suggest `#[derive(Default)]` to enums with `#[default]` fixes rust-lang#95226
…i-obk add more `rustc_pass_by_value` r? ``@oli-obk`` cc rust-lang#98766
…parens, r=oli-obk Fix "wrap closure in parenthesis" suggestion for `async` closure Fixes rust-lang#98023
rustbot
added
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Jul 4, 2022
@bors r rollup=never p=5 |
📌 Commit 484fa44 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 4, 2022
⌛ Testing commit 484fa44 with merge 1dc53b71924a8df2abae86741db2900e001f75af... |
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jul 4, 2022
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
FusedIterator
forstd::net::[Into]Incoming
#97300 (ImplementFusedIterator
forstd::net::[Into]Incoming
)#[derive(Default)]
to enums with#[default]
#98873 (Suggest#[derive(Default)]
to enums with#[default]
)rustc_pass_by_value
#98878 (add morerustc_pass_by_value
)async
closure #98879 (Fix "wrap closure in parenthesis" suggestion forasync
closure)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup