Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unneeded code #97879

Merged
merged 1 commit into from
Jun 8, 2022
Merged

remove unneeded code #97879

merged 1 commit into from
Jun 8, 2022

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Jun 8, 2022

The init function isn't longer part of Condvar. Consequently, we removed the implementation for the target os hermit.

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 8, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2022
@Dylan-DPC
Copy link
Member

@bors r rollup

@bors
Copy link
Contributor

bors commented Jun 8, 2022

📌 Commit 85b5f74 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 8, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2022
@bors
Auto merge of rust-lang#97887 - matthiaskrgr:rollup-ym5k7kb, r=matthi…
263d868 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97507 (Move rustfmt downloads from bootstrap.py to rustbuild)
 - rust-lang#97813 (Sync rustc_codegen_gcc)
 - rust-lang#97878 (Add regression test for anonymous lifetimes)
 - rust-lang#97879 (remove unneeded code)
 - rust-lang#97880 (Fix typo: fo->for)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ef56a1e into rust-lang:master Jun 8, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 8, 2022
@mkroening mkroening mentioned this pull request Jun 26, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#98555 - mkroening:hermit-lock-init, r=m-ou-se
6de107a 
Hermit: Fix initializing lazy locks

Closes hermit-os/hermit-rs#322.

The initialization function of hermit's `Condvar` is not called since rust-lang#97647 and was erroneously removed in rust-lang#97879.

r? `@m-ou-se`

CC: `@stlankes`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#98555 - mkroening:hermit-lock-init, r=m-ou-se
f181ae9 
Hermit: Fix initializing lazy locks

Closes hermit-os/hermit-rs#322.

The initialization function of hermit's `Condvar` is not called since rust-lang#97647 and was erroneously removed in rust-lang#97879.

r? ``@m-ou-se``

CC: ``@stlankes``
workingjubilee pushed a commit to tcdi/postgrestd that referenced this pull request Sep 15, 2022
@Dylan-DPC
Rollup merge of #98555 - mkroening:hermit-lock-init, r=m-ou-se
58f1f02 
Hermit: Fix initializing lazy locks

Closes hermit-os/hermit-rs#322.

The initialization function of hermit's `Condvar` is not called since rust-lang/rust#97647 and was erroneously removed in rust-lang/rust#97879.

r? ``@m-ou-se``

CC: ``@stlankes``
@mkroening mkroening deleted the condvar branch December 11, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@stlankes @rust-highfive @Dylan-DPC @bors @Mark-Simulacrum @rustbot