Improve diagnostics for unterminated nested block comment #95859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
yue4u
force-pushed
the
unterminated-nested-block-comment
branch
from
1dbebb3
to
5d1f333
Compare
|
The text of the comment should be available in Also all this logic searching for |
petrochenkov
added
S-waiting-on-author
yue4u
force-pushed
the
unterminated-nested-block-comment
branch
2 times, most recently
from
66ff71a
to
08baf85
Compare
yue4u
force-pushed
the
unterminated-nested-block-comment
branch
from
08baf85
to
4a0f8d5
Compare
yue4u
commented
Apr 13, 2022
There was a problem hiding this comment.
Hi @petrochenkov , thanks for the review. I updated this pr and does this look better?
petrochenkov
added
S-waiting-on-review
|
Thanks! |
|
📌 Commit 1b7008d has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 14, 2022
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 14, 2022
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 14, 2022
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 15, 2022
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 15, 2022
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 16, 2022
…comment, r=petrochenkov Improve diagnostics for unterminated nested block comment close rust-lang#95283 (This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2022
Rollup of 9 pull requests Successful merges: - rust-lang#93969 (Only add codegen backend to dep info if -Zbinary-dep-depinfo is used) - rust-lang#94605 (Add missing links in platform support docs) - rust-lang#95372 (make unaligned_references lint deny-by-default) - rust-lang#95859 (Improve diagnostics for unterminated nested block comment) - rust-lang#95961 (implement SIMD gather/scatter via vector getelementptr) - rust-lang#96004 (Consider lifetimes when comparing types for equality in MIR validator) - rust-lang#96050 (Remove some now-dead code that was only relevant before deaggregation.) - rust-lang#96070 ([test] Add test cases for untested functions for BTreeMap) - rust-lang#96099 (MaybeUninit array cleanup) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #95283
(This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )