Stabilize the `bundle` native library modifier #95818

petrochenkov · 2022-04-08T17:35:31Z

And remove the legacy static-nobundle linking kind.

Stabilization report - #95818 (comment).

cc #81490
Closes #37403

rust-highfive · 2022-04-08T17:35:35Z

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2022-05-08T19:06:16Z

Stabilization Report

This PR stabilizes native library modifier bundle, a part of RFC 2951: "Linking modifiers for native libraries" (tracking issue #83507).
The RFC was implemented about 1 year ago in #83507.

Before that it was implemented as a separate linbrary kind static-nobundle in early 2017 in #38426.
static-nobundle kind was deprecated about 1 year ago and this PR removes it.

`bundle` modifier

Examples: #[link(name = "mylib", kind = "static", modifiers = "-bundle")], -l static:-bundle=mylib.

This modifier is only compatible with the static linking kind.
Using any other kind will result in a compiler error.

When building a rlib or staticlib bundle means that all object files from the native static
library will be added to the rlib or staticlib archive, and then used from it during linking of
the final binary.

When building a rlib -bundle means that the native static library is registered as a dependency
of that rlib "by name", and object files from it are included only during linking of the final
binary, the file search by that name is also performed during final linking.
When building a staticlib -bundle means that the native static library is simply not included
into the archive and some higher level build system will need to add it later during linking of
the final binary.

This modifier has no effect when building other targets like executables or dynamic libraries.

The default for this modifier is bundle.

Test cases

src\test\run-make\native-link-modifier-*
src\test\ui\native-library-link-flags\*

Documentation

rust-lang/reference#1210

petrochenkov · 2022-05-08T19:08:23Z

@rfcbot fcp merge

rfcbot · 2022-05-08T19:08:25Z

Team member @petrochenkov has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

nikomatsakis · 2022-05-12T14:38:02Z

@rfcbot reviewed

rfcbot · 2022-05-19T15:00:58Z

🔔 This is now entering its final comment period, as per the review above. 🔔

petrochenkov · 2022-06-09T06:29:19Z

Error: cannot match: T _*native_func

🤦
I pushed a fix for this several days ago, but overwrote it yesterday from an outdated branch.

petrochenkov · 2022-06-09T08:44:11Z

Hmm, maybe these IO errors happen (due to some CI-specific limitations) just because a lot of text is printed after some other original error is encountered?
In that case they should disappear once all the true errors are fixed.

wesleywiser · 2022-06-09T16:22:42Z

Hmm, maybe these IO errors happen (due to some CI-specific limitations) just because a lot of text is printed after some other original error is encountered? In that case they should disappear once all the true errors are fixed.

Yeah, I think that's true.

I notice in the cdylib case, we're linking the native dependency as needed:

"-Wl,--as-needed" "-L" "/tmp/rust/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-bundle/native-link-modifier-bundle" "-L" "/tmp/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-Wl,-Bstatic" "/tmp/rust/build/x86_64-unknown-linux-gnu/test/run-make/native-link-modifier-bundle/native-link-modifier-bundle/libbundled.rlib"

but since cdylib-bundled.rs doesn't use any symbols from native dependency, I don't think the linker has any reason to include it. Maybe I'm missing something?

petrochenkov · 2022-06-09T19:11:46Z

but since cdylib-bundled.rs doesn't use any symbols from native dependency, I don't think the linker has any reason to include it.

The cdylib should export wrapped_func and therefore keep it alive.
wrapped_func uses native_func so it should also be kept.

Looks like I didn't reapply the fix for

I pushed a fix for this several days ago, but overwrote it yesterday from an outdated branch.

correctly, T was changed to [Tt], but -g wasn't removed from nm -g.

petrochenkov · 2022-06-09T20:58:42Z

PR CI is green now.
@bors r=wesleywiser

bors · 2022-06-09T20:58:43Z

📌 Commit a8ee1f3 has been approved by wesleywiser

Stabilize the `bundle` native library modifier And remove the legacy `static-nobundle` linking kind. Stabilization report - rust-lang#95818 (comment). cc rust-lang#81490 Closes rust-lang#37403

bors · 2022-06-10T06:25:06Z

⌛ Testing commit a8ee1f3 with merge 3dea003...

bors · 2022-06-10T09:05:44Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 3dea003 to master...

rust-timer · 2022-06-10T10:26:23Z

Finished benchmarking commit (3dea003): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.2%	-0.2%	2
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	2.1%	2.1%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.5%	-3.5%	1
All 😿🎉 (primary)	2.1%	2.1%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.0%	2.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rust-timer · 2022-06-10T11:45:46Z

Finished benchmarking commit (3dea003): comparison url.

Instruction count

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-0.2%	-0.2%	2
All 😿🎉 (primary)	N/A	N/A	0

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	2.1%	2.1%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.5%	-3.5%	1
All 😿🎉 (primary)	2.1%	2.1%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.0%	2.0%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

wesleywiser · 2022-06-10T12:02:20Z

Thanks for your work on this @petrochenkov!

Stabilize the `bundle` native library modifier And remove the legacy `static-nobundle` linking kind. Stabilization report - rust-lang/rust#95818 (comment). cc #81490 Closes #37403

Pkgsrc changes: * Adjust patches as needed & checksum updates. Upstream changes: Version 1.63.0 (2022-08-11) ========================== Language -------- - [Remove migrate borrowck mode for pre-NLL errors.][95565] - [Modify MIR building to drop repeat expressions with length zero.][95953] - [Remove label/lifetime shadowing warnings.][96296] - [Allow explicit generic arguments in the presence of `impl Trait` args.] [96868] - [Make `cenum_impl_drop_cast` warnings deny-by-default.][97652] - [Prevent unwinding when `-C panic=abort` is used regardless of declared ABI.][96959] - [lub: don't bail out due to empty binders.][97867] Compiler -------- - [Stabilize the `bundle` native library modifier,][95818] also removing the deprecated `static-nobundle` linking kind. - [Add Apple WatchOS compile targets\*.][95243] - [Add a Windows application manifest to rustc-main.][96737] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Implement `Copy`, `Clone`, `PartialEq` and `Eq` for `core::fmt::Alignment`.][94530] - [Extend `ptr::null` and `null_mut` to all thin (including extern) types.][94954] - [`impl Read and Write for VecDeque<u8>`.][95632] - [STD support for the Nintendo 3DS.][95897] - [Make write/print macros eagerly drop temporaries.][96455] - [Implement internal traits that enable `[OsStr]::join`.][96881] - [Implement `Hash` for `core::alloc::Layout`.][97034] - [Add capacity documentation for `OsString`.][97202] - [Put a bound on collection misbehavior.][97316] - [Make `std::mem::needs_drop` accept `?Sized`.][97675] - [`impl Termination for Infallible` and then make the `Result` impls of `Termination` more generic.][97803] - [Document Rust's stance on `/proc/self/mem`.][97837] Stabilized APIs --------------- - [`array::from_fn`] - [`Box::into_pin`] - [`BinaryHeap::try_reserve`] - [`BinaryHeap::try_reserve_exact`] - [`OsString::try_reserve`] - [`OsString::try_reserve_exact`] - [`PathBuf::try_reserve`] - [`PathBuf::try_reserve_exact`] - [`Path::try_exists`] - [`Ref::filter_map`] - [`RefMut::filter_map`] - [`NonNull::<[T]>::len`][`NonNull::<slice>::len`] - [`ToOwned::clone_into`] - [`Ipv6Addr::to_ipv4_mapped`] - [`unix::io::AsFd`] - [`unix::io::BorrowedFd<'fd>`] - [`unix::io::OwnedFd`] - [`windows::io::AsHandle`] - [`windows::io::BorrowedHandle<'handle>`] - [`windows::io::OwnedHandle`] - [`windows::io::HandleOrInvalid`] - [`windows::io::HandleOrNull`] - [`windows::io::InvalidHandleError`] - [`windows::io::NullHandleError`] - [`windows::io::AsSocket`] - [`windows::io::BorrowedSocket<'handle>`] - [`windows::io::OwnedSocket`] - [`thread::scope`] - [`thread::Scope`] - [`thread::ScopedJoinHandle`] These APIs are now usable in const contexts: - [`array::from_ref`] - [`slice::from_ref`] - [`intrinsics::copy`] - [`intrinsics::copy_nonoverlapping`] - [`<*const T>::copy_to`] - [`<*const T>::copy_to_nonoverlapping`] - [`<*mut T>::copy_to`] - [`<*mut T>::copy_to_nonoverlapping`] - [`<*mut T>::copy_from`] - [`<*mut T>::copy_from_nonoverlapping`] - [`str::from_utf8`] - [`Utf8Error::error_len`] - [`Utf8Error::valid_up_to`] - [`Condvar::new`] - [`Mutex::new`] - [`RwLock::new`] Cargo ----- - [Stabilize the `--config path` command-line argument.][cargo/10755] - [Expose rust-version in the environment as `CARGO_PKG_RUST_VERSION`.][cargo/10713] Compatibility Notes ------------------- - [`#[link]` attributes are now checked more strictly,][96885] which may introduce errors for invalid attribute arguments that were previously ignored. Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Prepare Rust for LLVM opaque pointers.][94214] [94214]: rust-lang/rust#94214 [94530]: rust-lang/rust#94530 [94954]: rust-lang/rust#94954 [95243]: rust-lang/rust#95243 [95565]: rust-lang/rust#95565 [95632]: rust-lang/rust#95632 [95818]: rust-lang/rust#95818 [95897]: rust-lang/rust#95897 [95953]: rust-lang/rust#95953 [96296]: rust-lang/rust#96296 [96455]: rust-lang/rust#96455 [96737]: rust-lang/rust#96737 [96868]: rust-lang/rust#96868 [96881]: rust-lang/rust#96881 [96885]: rust-lang/rust#96885 [96959]: rust-lang/rust#96959 [97034]: rust-lang/rust#97034 [97202]: rust-lang/rust#97202 [97316]: rust-lang/rust#97316 [97652]: rust-lang/rust#97652 [97675]: rust-lang/rust#97675 [97803]: rust-lang/rust#97803 [97837]: rust-lang/rust#97837 [97867]: rust-lang/rust#97867 [cargo/10713]: rust-lang/cargo#10713 [cargo/10755]: rust-lang/cargo#10755 [`array::from_fn`]: https://doc.rust-lang.org/stable/std/array/fn.from_fn.html [`Box::into_pin`]: https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#method.into_pin [`BinaryHeap::try_reserve_exact`]: https://doc.rust-lang.org/stable/alloc/collections/binary_heap/struct.BinaryHeap.html#method.try_reserve_exact [`BinaryHeap::try_reserve`]: https://doc.rust-lang.org/stable/std/collections/struct.BinaryHeap.html#method.try_reserve [`OsString::try_reserve`]: https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.try_reserve [`OsString::try_reserve_exact`]: https://doc.rust-lang.org/stable/std/ffi/struct.OsString.html#method.try_reserve_exact [`PathBuf::try_reserve`]: https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.try_reserve [`PathBuf::try_reserve_exact`]: https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#method.try_reserve_exact [`Path::try_exists`]: https://doc.rust-lang.org/stable/std/path/struct.Path.html#method.try_exists [`Ref::filter_map`]: https://doc.rust-lang.org/stable/std/cell/struct.Ref.html#method.filter_map [`RefMut::filter_map`]: https://doc.rust-lang.org/stable/std/cell/struct.RefMut.html#method.filter_map [`NonNull::<slice>::len`]: https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.len [`ToOwned::clone_into`]: https://doc.rust-lang.org/stable/std/borrow/trait.ToOwned.html#method.clone_into [`Ipv6Addr::to_ipv4_mapped`]: https://doc.rust-lang.org/stable/std/net/struct.Ipv6Addr.html#method.to_ipv4_mapped [`unix::io::AsFd`]: https://doc.rust-lang.org/stable/std/os/unix/io/trait.AsFd.html [`unix::io::BorrowedFd<'fd>`]: https://doc.rust-lang.org/stable/std/os/unix/io/struct.BorrowedFd.html [`unix::io::OwnedFd`]: https://doc.rust-lang.org/stable/std/os/unix/io/struct.OwnedFd.html [`windows::io::AsHandle`]: https://doc.rust-lang.org/stable/std/os/windows/io/trait.AsHandle.html [`windows::io::BorrowedHandle<'handle>`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.BorrowedHandle.html [`windows::io::OwnedHandle`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.OwnedHandle.html [`windows::io::HandleOrInvalid`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.HandleOrInvalid.html [`windows::io::HandleOrNull`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.HandleOrNull.html [`windows::io::InvalidHandleError`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.InvalidHandleError.html [`windows::io::NullHandleError`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.NullHandleError.html [`windows::io::AsSocket`]: https://doc.rust-lang.org/stable/std/os/windows/io/trait.AsSocket.html [`windows::io::BorrowedSocket<'handle>`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.BorrowedSocket.html [`windows::io::OwnedSocket`]: https://doc.rust-lang.org/stable/std/os/windows/io/struct.OwnedSocket.html [`thread::scope`]: https://doc.rust-lang.org/stable/std/thread/fn.scope.html [`thread::Scope`]: https://doc.rust-lang.org/stable/std/thread/struct.Scope.html [`thread::ScopedJoinHandle`]: https://doc.rust-lang.org/stable/std/thread/struct.ScopedJoinHandle.html [`array::from_ref`]: https://doc.rust-lang.org/stable/std/array/fn.from_ref.html [`slice::from_ref`]: https://doc.rust-lang.org/stable/std/slice/fn.from_ref.html [`intrinsics::copy`]: https://doc.rust-lang.org/stable/std/intrinsics/fn.copy.html [`intrinsics::copy_nonoverlapping`]: https://doc.rust-lang.org/stable/std/intrinsics/fn.copy_nonoverlapping.html [`<*const T>::copy_to`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to [`<*const T>::copy_to_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to_nonoverlapping [`<*mut T>::copy_to`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to-1 [`<*mut T>::copy_to_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_to_nonoverlapping-1 [`<*mut T>::copy_from`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_from [`<*mut T>::copy_from_nonoverlapping`]: https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.copy_from_nonoverlapping [`str::from_utf8`]: https://doc.rust-lang.org/stable/std/str/fn.from_utf8.html [`Utf8Error::error_len`]: https://doc.rust-lang.org/stable/std/str/struct.Utf8Error.html#method.error_len [`Utf8Error::valid_up_to`]: https://doc.rust-lang.org/stable/std/str/struct.Utf8Error.html#method.valid_up_to [`Condvar::new`]: https://doc.rust-lang.org/stable/std/sync/struct.Condvar.html#method.new [`Mutex::new`]: https://doc.rust-lang.org/stable/std/sync/struct.Mutex.html#method.new [`RwLock::new`]: https://doc.rust-lang.org/stable/std/sync/struct.RwLock.html#method.new

rust-highfive assigned estebank Apr 8, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 8, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2022

petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2022

This was referenced Apr 8, 2022

Tracking Issue for linking modifiers for native libraries #81490

Closed

Generate synthetic object file to ensure all exported and used symbols participate in the linking #95604

Merged

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels May 3, 2022

petrochenkov force-pushed the stabundle branch from ef791a0 to ef5c0e5 Compare May 3, 2022 18:19

petrochenkov mentioned this pull request May 8, 2022

Document native library modifier bundle rust-lang/reference#1210

Merged

petrochenkov force-pushed the stabundle branch from ef5c0e5 to 91f3d25 Compare May 8, 2022 19:05

petrochenkov changed the title ~~[WIP] Stabilize the bundle native library modifier~~ Stabilize the bundle native library modifier May 8, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 8, 2022

This comment was marked as resolved.

Sign in to view

petrochenkov mentioned this pull request May 13, 2022

rustc: Stricter checking for #[link] attributes #96885

Merged

This comment was marked as resolved.

Sign in to view

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 19, 2022

petrochenkov removed the I-compiler-nominated The issue / PR has been nominated for discussion during a compiler team meeting. label May 19, 2022

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 9, 2022

petrochenkov force-pushed the stabundle branch from 8ba1a00 to 03ac1f2 Compare June 9, 2022 07:03

This comment has been minimized.

Sign in to view

apiraino removed the to-announce Announce this issue on triage meeting label Jun 9, 2022

Stabilize the bundle native library modifier

a8ee1f3

petrochenkov force-pushed the stabundle branch from 03ac1f2 to a8ee1f3 Compare June 9, 2022 19:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2022

Dylan-DPC mentioned this pull request Jun 10, 2022

Rollup of 5 pull requests #97938

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2022

bors merged commit 3dea003 into rust-lang:master Jun 10, 2022

rustbot added this to the 1.63.0 milestone Jun 10, 2022

petrochenkov added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 19, 2022

krasimirgg mentioned this pull request Jun 23, 2022

adapt native-link-modifier-bundle test no not emit LLVM bitcode #98424

Closed

petrochenkov mentioned this pull request Aug 3, 2022

rustc-docs: Be less specific about the representation of bundle #100074

Merged

AlexTMjugador mentioned this pull request Apr 17, 2024

Tracking issue for #[link(kind)] connecting libraries on Windows #37403

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize the `bundle` native library modifier #95818

Stabilize the `bundle` native library modifier #95818

petrochenkov commented Apr 8, 2022 •

edited

Loading

rust-highfive commented Apr 8, 2022

petrochenkov commented May 8, 2022

petrochenkov commented May 8, 2022

rfcbot commented May 8, 2022 •

edited by pnkfelix

Loading

This comment was marked as resolved.

nikomatsakis commented May 12, 2022

This comment was marked as resolved.

rfcbot commented May 19, 2022

petrochenkov commented Jun 9, 2022

This comment has been minimized.

petrochenkov commented Jun 9, 2022 •

edited

Loading

wesleywiser commented Jun 9, 2022

petrochenkov commented Jun 9, 2022

petrochenkov commented Jun 9, 2022

bors commented Jun 9, 2022

bors commented Jun 10, 2022

bors commented Jun 10, 2022

rust-timer commented Jun 10, 2022

rust-timer commented Jun 10, 2022

wesleywiser commented Jun 10, 2022

Stabilize the bundle native library modifier #95818

Stabilize the bundle native library modifier #95818

Conversation

petrochenkov commented Apr 8, 2022 • edited Loading

rust-highfive commented Apr 8, 2022

petrochenkov commented May 8, 2022

Stabilization Report

bundle modifier

Test cases

Documentation

petrochenkov commented May 8, 2022

rfcbot commented May 8, 2022 • edited by pnkfelix Loading

This comment was marked as resolved.

nikomatsakis commented May 12, 2022

This comment was marked as resolved.

rfcbot commented May 19, 2022

petrochenkov commented Jun 9, 2022

This comment has been minimized.

petrochenkov commented Jun 9, 2022 • edited Loading

wesleywiser commented Jun 9, 2022

petrochenkov commented Jun 9, 2022

petrochenkov commented Jun 9, 2022

bors commented Jun 9, 2022

bors commented Jun 10, 2022

bors commented Jun 10, 2022

rust-timer commented Jun 10, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

rust-timer commented Jun 10, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

wesleywiser commented Jun 10, 2022

Stabilize the `bundle` native library modifier #95818

Stabilize the `bundle` native library modifier #95818

petrochenkov commented Apr 8, 2022 •

edited

Loading

`bundle` modifier

rfcbot commented May 8, 2022 •

edited by pnkfelix

Loading

petrochenkov commented Jun 9, 2022 •

edited

Loading