fix sparc64 ABI for aggregates with floating point members #91003

psumbera · 2021-11-18T09:41:14Z

rust-highfive · 2021-11-18T09:41:17Z

(rust-highfive has picked a reviewer for you, use r? to override)

psumbera · 2021-11-18T09:43:32Z

I have created this with some suggestions from @eddyb.

nagisa · 2021-11-18T10:01:44Z

This should have a regression test which tests both the LLVM-IR output and the assembly. One with #[no_core] and compiler-flags: --target=sparc64-... so that it runs on all hosts would be ideal.

See src/test/codegen/sparc-struct-abi.rs for an example of an LLVM-IR test and src/test/assembly for the assembly ones.

psumbera · 2021-11-19T10:21:51Z

@nagisa isn't extending src/test/codegen/sparc-struct-abi.rs enough? I don't know how to check these easily in assembler...

nagisa · 2021-11-19T12:12:34Z

I would say that LLVM IR is a pretty poor proxy for verifying the ABI is what we want it to be. Conventionally we would have a run-pass test which would call some functions defined in C, like this.

However since nobody is really able to run tests on a SPARC and the CI does not cover the architecture, such a run-pass test would be pretty much always skipped (though adding one would still be appreciated!)

An assembly test therefore is the next best thing, I feel. As for how to construct such a test, I would start with emitting some assembly from clang for an equivalent call and then FileChecking the ABI instructions around… Kinda like this (taking the code from the issue):

// compiler-flags: -Copt-level=3 --target=sparc...

#[repr(C)]
pub struct Franta {
        a:f32,
        b:f32,
        c:f32,
        d:f32,
}

// CHECK-LABEL: callee
#[no_mangle]
pub extern "C" fn callee(arg: Franta) {
    // CHECK: fmovs   %f?, �
    // CHECK: call use
    use(arg.a); 
    // CHECK: fmovs   %f?, �
    // CHECK: call use
    use(arg.b); 
    // CHECK: fmovs   %f?, �
    // CHECK: call use
    use(arg.c);
    // CHECK: fmovs   %f?, �
    // CHECK: call use
    use(arg.d);
}

extern "C" {
    fn opaque_callee(arg: Franta, intarg: i32);
    fn use(arg: f32);
}

// CHECK-LABEL: caller
// CHECK: mov       0x3, %o2
// CHECK: fmovs     %{{.*}}, �
// CHECK: fmovs     %{{.*}}, �
// CHECK: fmovs     %{{.*}}, �
// CHECK: fmovs     %{{.*}}, �
// CHECK: call {{.*}}
pub unsafe extern "C" fn caller() {
    opaque_callee(Franta { a: 1.0, b: 2.0, c: 3.0, d: 4.0 }, 3);
}

Do note that I pretty much wrote this entire thing into the github's comment field from memory so there may be mistakes in the code above etc, but should give you a good starting point, hopefully?

psumbera · 2021-11-19T14:57:58Z

I think I that asm testing cannot reliable work. One time it uses fmovs instruction and another time st instruction.

Clang code below:

void calle(struct Franta a) {
  tst_use(a.a);
  tst_use(a.b);
  tst_use(a.c);
  tst_use(a.d);
}

generates:

calle:                                  ! @calle
! �.0:
        save %sp, -208, %sp
        st �, [%fp 2031]
        add %fp, 2031, %i0
        or %i0, 4, %i0
        st �, [%i0]
        st �, [%fp 2039]
        st �, [%fp 2043]
        ld [%fp 2031], �
        call tst_use
        stx %i0, [%fp 2023]
        ldx [%fp 2023], %i0                     ! 8-byte Folded Reload
        call tst_use
        ld [%i0], �
        call tst_use
        ld [%fp 2039], �
        call tst_use
        ld [%fp 2043], �
        ret
        restore

Where Rust code:

pub unsafe extern "C" fn callee(arg: Franta) {
    tst_use(arg.a);
    tst_use(arg.b);
    tst_use(arg.c);
    tst_use(arg.d);
}

generates:

callee:
        .cfi_startproc
        save %sp, -192, %sp
        .cfi_def_cfa_register %fp
        .cfi_window_save
        .cfi_register %o7, %i7
        st �, [%fp 2043]
        st �, [%fp 2039]
        st �, [%fp 2035]
        fmovs �, �
        call tst_use
        nop
        call tst_use
        ld [%fp 2035], �
        call tst_use
        ld [%fp 2039], �
        call tst_use
        ld [%fp 2043], �
        ret
        restore

psumbera · 2021-11-19T15:24:46Z

E.g. Following works. But I think it can change with next LLVM update:

// assembly-output: emit-asm
// needs-llvm-components: sparc
// compile-flags: --target=sparcv9-sun-solaris
#![crate_type = "lib"]

#[repr(C)]
pub struct Franta {
        a:f32,
        b:f32,
        c:f32,
        d:f32,
}

// CHECK-LABEL: callee
#[no_mangle]
pub unsafe extern "C" fn callee(arg: Franta) {
    // CHECK: st �, [%fp 2043]
    // CHECK: st �, [%fp 2039]
    // CHECK: st �, [%fp 2035]
    // CHECK: fmovs �, �
    tst_use(arg.a);
    tst_use(arg.b);
    tst_use(arg.c);
    tst_use(arg.d);
}

extern "C" {
    fn opaque_callee(arg: Franta, intarg: i32);
    fn tst_use(arg: f32);
}

// CHECK-LABEL: caller
// CHECK: ld [%i1], �
// CHECK: ld [%i2], �
// CHECK: ld [%i3], �
// CHECK: ld [%i0], �
// CHECK: call {{.*}}
// CHECK: mov     3, %o2
pub unsafe extern "C" fn caller() {
    opaque_callee(Franta { a: 1.0, b: 2.0, c: 3.0, d: 4.0 }, 3);
}

nagisa · 2021-11-19T20:39:35Z

I think it is fine if some tests change in output occasionally after a change as major as LLVM bump, so long as it is easy to tell that the test output did not become wrong. There are a couple ways to reduce the frequency of such changes too – first is using the highest optimization level available (-Copt-level=3), another is writing the FileCheck rules in such a way that the test is resilient to offsets on the stack changing, in some ways, for example. Adjusting the test to the following code makes me reasonably confident that maintaining this test won't be an issue. Here's what I came up with:

The code

// assembly-output: emit-asm
// needs-llvm-components: sparc
// compile-flags: --target=sparcv9-sun-solaris
#![crate_type = "lib"]
#![feature(no_core, lang_items)]
#![no_core]

#[lang = "sized"]
pub trait Sized {}
#[lang = "copy"]
pub trait Copy {}

#[repr(C)]
pub struct Franta {
    a: f32,
    b: f32,
    c: f32,
    d: f32,
}

// NB: due to delay slots the `ld` following the call is actually executed before the call.
#[no_mangle]
pub unsafe extern "C" fn callee(arg: Franta) {
    // CHECK-LABEL: callee:
    // CHECK: st �, [[PLACE_D:.*]]
    // CHECK: st �, [[PLACE_C:.*]]
    // CHECK: st �, [[PLACE_B:.*]]
    // CHECK: st �, [[PLACE_A:.*]]
    // CHECK: call tst_use
    // CHECK-NEXT: ld [[PLACE_A]], �
    // CHECK: call tst_use
    // CHECK-NEXT: ld [[PLACE_B]], �
    // CHECK: call tst_use
    // CHECK-NEXT: ld [[PLACE_C]], �
    // CHECK: call tst_use
    // CHECK-NEXT: ld [[PLACE_D]], �
    clobber();
    tst_use(arg.a);
    tst_use(arg.b);
    tst_use(arg.c);
    tst_use(arg.d);
}

extern "C" {
    fn opaque_callee(arg: Franta, intarg: i32);
    fn tst_use(arg: f32);
    fn clobber();
}

#[no_mangle]
pub unsafe extern "C" fn caller() {
    // CHECK-LABEL: caller:
    // CHECK: ld [{{.*}}], �
    // CHECK: ld [{{.*}}], �
    // CHECK: ld [{{.*}}], �
    // CHECK: ld [{{.*}}], �
    // CHECK: call opaque_callee
    // CHECK: mov     3, %o2
    opaque_callee(Franta { a: 1.0, b: 2.0, c: 3.0, d: 4.0 }, 3);
}

nagisa · 2021-11-22T10:43:26Z

Can you please squash the commits into 1 or 2 so that the commit history is meaningful once merged into the main branch?

nagisa · 2021-11-24T21:17:15Z

@bors r thanks!

bors · 2021-11-24T21:17:17Z

📌 Commit edbdda3 has been approved by nagisa

fix sparc64 ABI for aggregates with floating point members Fixes rust-lang#86163

matthiaskrgr · 2021-11-25T19:46:57Z

failed in a rollup: #91232 (comment)
@bors r-

psumbera · 2021-11-30T12:34:43Z

I have removed last problematic test (where was the collision with readnone). It seemed that -Cno-prepopulate-passes would add more complexity and previous tests would need to be rewritten (and became more complex).

nagisa · 2021-11-30T14:56:03Z

@bors r

bors · 2021-11-30T14:56:06Z

📌 Commit bde8b05e2779120b349aba30effcd2896c2cb12f has been approved by nagisa

bors · 2021-11-30T17:34:15Z

⌛ Testing commit bde8b05e2779120b349aba30effcd2896c2cb12f with merge 40df9dfd7f06199f71890877ad3fed3b5777ed39...

bors · 2021-11-30T17:57:41Z

💔 Test failed - checks-actions

nagisa · 2021-11-30T17:59:47Z

Hm, this is a confusing error given that we specifically specify the optimization level flag, but you could switch some of the CHECKs to CHECK-DAGs to permit the st instructions to appear in an arbitrary order.

(EDIT: that said is it just me or is the or business in

            add %fp, 2031, %i0 
            or %i0, 4, %i0 
            st �, [%i0] 
            st �, [%fp 2043] 
            st �, [%fp 2039] 
            st �, [%fp 2031]

really really sketchy?)

psumbera · 2021-12-01T09:07:14Z

I have added -Copt-level=3 as you have suggested earlier. I was able to reproduce the problem when I have added -Copt-level=0. Hopefully with level 3 on Linux test system we will get correct results...

nagisa · 2021-12-01T18:04:45Z

@bors r

bors · 2021-12-01T18:04:47Z

📌 Commit 128ceec has been approved by nagisa

bors · 2021-12-02T02:59:47Z

⌛ Testing commit 128ceec with merge a2b7b78...

bors · 2021-12-02T06:10:58Z

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing a2b7b78 to master...

rust-timer · 2021-12-02T07:40:53Z

Finished benchmarking commit (a2b7b78): comparison url.

Summary: This change led to small relevant improvements 🎉 in compiler performance.

Small improvement in instruction counts (up to -0.7% on incr-unchanged builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

glaubitz · 2021-12-02T10:13:43Z

@psumbera Thanks for fixing this!

fix sparc64 ABI for aggregates with floating point members Fixes rust-lang#86163

Pkgsrc changes: * Bump available bootstraps to 1.58.1. * Adjust one patch (and checksum) so that it still applies. Upstream changes: Version 1.59.0 (2022-02-24) ========================== Language -------- - [Stabilize default arguments for const generics][90207] - [Stabilize destructuring assignment][90521] - [Relax private in public lint on generic bounds and where clauses of trait impls][90586] - [Stabilize asm! and global_asm! for x86, x86_64, ARM, Aarch64, and RISC-V][91728] Compiler -------- - [Stabilize new symbol mangling format, leaving it opt-in (-Csymbol-mangling-version=v0)][90128] - [Emit LLVM optimization remarks when enabled with `-Cremark`][90833] - [Fix sparc64 ABI for aggregates with floating point members][91003] - [Warn when a `#[test]`-like built-in attribute macro is present multiple times.][91172] - [Add support for riscv64gc-unknown-freebsd][91284] - [Stabilize `-Z emit-future-incompat` as `--json future-incompat`][91535] - [Soft disable incremental compilation][94124] This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to a known and relatively frequently occurring bug in incremental compilation, which causes builds to issue internal compiler errors. This particular bug is already fixed on nightly, but that fix has not yet rolled out to stable and is deemed too risky for a direct stable backport. As always, we encourage users to test with nightly and report bugs so that we can track failures and fix issues earlier. See [94124] for more details. [94124]: rust-lang/rust#94124 Libraries --------- - [Remove unnecessary bounds for some Hash{Map,Set} methods][91593] Stabilized APIs --------------- - [`std::thread::available_parallelism`][available_parallelism] - [`Result::copied`][result-copied] - [`Result::cloned`][result-cloned] - [`arch::asm!`][asm] - [`arch::global_asm!`][global_asm] - [`ops::ControlFlow::is_break`][is_break] - [`ops::ControlFlow::is_continue`][is_continue] - [`TryFrom<char> for u8`][try_from_char_u8] - [`char::TryFromCharError`][try_from_char_err] implementing `Clone`, `Debug`, `Display`, `PartialEq`, `Copy`, `Eq`, `Error` - [`iter::zip`][zip] - [`NonZeroU8::is_power_of_two`][is_power_of_two8] - [`NonZeroU16::is_power_of_two`][is_power_of_two16] - [`NonZeroU32::is_power_of_two`][is_power_of_two32] - [`NonZeroU64::is_power_of_two`][is_power_of_two64] - [`NonZeroU128::is_power_of_two`][is_power_of_two128] - [`DoubleEndedIterator for ToLowercase`][lowercase] - [`DoubleEndedIterator for ToUppercase`][uppercase] - [`TryFrom<&mut [T]> for [T; N]`][tryfrom_ref_arr] - [`UnwindSafe for Once`][unwindsafe_once] - [`RefUnwindSafe for Once`][refunwindsafe_once] - [armv8 neon intrinsics for aarch64][stdarch/1266] Const-stable: - [`mem::MaybeUninit::as_ptr`][muninit_ptr] - [`mem::MaybeUninit::assume_init`][muninit_init] - [`mem::MaybeUninit::assume_init_ref`][muninit_init_ref] - [`ffi::CStr::from_bytes_with_nul_unchecked`][cstr_from_bytes] Cargo ----- - [Stabilize the `strip` profile option][cargo/10088] - [Stabilize future-incompat-report][cargo/10165] - [Support abbreviating `--release` as `-r`][cargo/10133] - [Support `term.quiet` configuration][cargo/10152] - [Remove `--host` from cargo {publish,search,login}][cargo/10145] Compatibility Notes ------------------- - [Refactor weak symbols in std::sys::unix][90846] This may add new, versioned, symbols when building with a newer glibc, as the standard library uses weak linkage rather than dynamically attempting to load certain symbols at runtime. - [Deprecate crate_type and crate_name nested inside `#![cfg_attr]`][83744] This adds a future compatibility lint to supporting the use of cfg_attr wrapping either crate_type or crate_name specification within Rust files; it is recommended that users migrate to setting the equivalent command line flags. - [Remove effect of `#[no_link]` attribute on name resolution][92034] This may expose new names, leading to conflicts with preexisting names in a given namespace and a compilation failure. - [Cargo will document libraries before binaries.][cargo/10172] - [Respect doc=false in dependencies, not just the root crate][cargo/10201] - [Weaken guarantee around advancing underlying iterators in zip][83791] - [Make split_inclusive() on an empty slice yield an empty output][89825] - [Update std::env::temp_dir to use GetTempPath2 on Windows when available.][89999] - [unreachable! was updated to match other formatting macro behavior on Rust 2021][92137] Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Fix many cases of normalization-related ICEs][91255] - [Replace dominators algorithm with simple Lengauer-Tarjan][85013] - [Store liveness in interval sets for region inference][90637] - [Remove `in_band_lifetimes` from the compiler and standard library, in preparation for removing this unstable feature.][91867] [91867]: rust-lang/rust#91867 [83744]: rust-lang/rust#83744 [83791]: rust-lang/rust#83791 [85013]: rust-lang/rust#85013 [89825]: rust-lang/rust#89825 [89999]: rust-lang/rust#89999 [90128]: rust-lang/rust#90128 [90207]: rust-lang/rust#90207 [90521]: rust-lang/rust#90521 [90586]: rust-lang/rust#90586 [90637]: rust-lang/rust#90637 [90833]: rust-lang/rust#90833 [90846]: rust-lang/rust#90846 [91003]: rust-lang/rust#91003 [91172]: rust-lang/rust#91172 [91255]: rust-lang/rust#91255 [91284]: rust-lang/rust#91284 [91535]: rust-lang/rust#91535 [91593]: rust-lang/rust#91593 [91728]: rust-lang/rust#91728 [91878]: rust-lang/rust#91878 [91896]: rust-lang/rust#91896 [91926]: rust-lang/rust#91926 [91984]: rust-lang/rust#91984 [92020]: rust-lang/rust#92020 [92034]: rust-lang/rust#92034 [92483]: rust-lang/rust#92483 [cargo/10088]: rust-lang/cargo#10088 [cargo/10133]: rust-lang/cargo#10133 [cargo/10145]: rust-lang/cargo#10145 [cargo/10152]: rust-lang/cargo#10152 [cargo/10165]: rust-lang/cargo#10165 [cargo/10172]: rust-lang/cargo#10172 [cargo/10201]: rust-lang/cargo#10201 [cargo/10269]: rust-lang/cargo#10269 [cstr_from_bytes]: https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked [muninit_ptr]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.as_ptr [muninit_init]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init [muninit_init_ref]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_ref [unwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-UnwindSafe [refunwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-RefUnwindSafe [tryfrom_ref_arr]: https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom<&'_ mut [T]> [lowercase]: https://doc.rust-lang.org/stable/std/char/struct.ToLowercase.html#impl-DoubleEndedIterator [uppercase]: https://doc.rust-lang.org/stable/std/char/struct.ToUppercase.html#impl-DoubleEndedIterator [try_from_char_err]: https://doc.rust-lang.org/stable/std/char/struct.TryFromCharError.html [available_parallelism]: https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html [result-copied]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.copied [result-cloned]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.cloned [asm]: https://doc.rust-lang.org/stable/core/arch/macro.asm.html [global_asm]: https://doc.rust-lang.org/stable/core/arch/macro.global_asm.html [is_break]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_break [is_continue]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_continue [try_from_char_u8]: https://doc.rust-lang.org/stable/std/primitive.char.html#impl-TryFrom [zip]: https://doc.rust-lang.org/stable/std/iter/fn.zip.html [is_power_of_two8]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU8.html#method.is_power_of_two [is_power_of_two16]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU16.html#method.is_power_of_two [is_power_of_two32]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU32.html#method.is_power_of_two [is_power_of_two64]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU64.html#method.is_power_of_two [is_power_of_two128]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU128.html#method.is_power_of_two [stdarch/1266]: rust-lang/stdarch#1266

rust-highfive assigned cjgillot Nov 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2021

This comment has been minimized.

Sign in to view

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021

cjgillot assigned nagisa and unassigned cjgillot Nov 21, 2021

psumbera force-pushed the sparc64-abi branch from d4790c8 to edbdda3 Compare November 22, 2021 12:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2021

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 25, 2021

Rollup merge of rust-lang#91003 - psumbera:sparc64-abi, r=nagisa

63c738d

fix sparc64 ABI for aggregates with floating point members Fixes rust-lang#86163

matthiaskrgr mentioned this pull request Nov 25, 2021

Rollup of 7 pull requests #91232

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2021

fix sparc64 ABI for aggregates with floating point members

128ceec

psumbera force-pushed the sparc64-abi branch from 642f0c6 to 128ceec Compare December 1, 2021 09:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2021

bors merged commit a2b7b78 into rust-lang:master Dec 2, 2021

rustbot added this to the 1.59.0 milestone Dec 2, 2021

bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Dec 31, 2021

Auto merge of rust-lang#91003 - psumbera:sparc64-abi, r=nagisa

48fc7d9

fix sparc64 ABI for aggregates with floating point members Fixes rust-lang#86163

nagisa mentioned this pull request Feb 21, 2022

more complete sparc64 ABI fix for aggregates with floating point members #94216

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix sparc64 ABI for aggregates with floating point members #91003

fix sparc64 ABI for aggregates with floating point members #91003

psumbera commented Nov 18, 2021

rust-highfive commented Nov 18, 2021

psumbera commented Nov 18, 2021

This comment has been minimized.

nagisa commented Nov 18, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

psumbera commented Nov 19, 2021

nagisa commented Nov 19, 2021 •

edited

Loading

psumbera commented Nov 19, 2021

psumbera commented Nov 19, 2021

nagisa commented Nov 19, 2021

nagisa commented Nov 22, 2021

nagisa commented Nov 24, 2021

bors commented Nov 24, 2021

matthiaskrgr commented Nov 25, 2021

psumbera commented Nov 30, 2021

nagisa commented Nov 30, 2021

bors commented Nov 30, 2021

bors commented Nov 30, 2021

This comment has been minimized.

bors commented Nov 30, 2021

nagisa commented Nov 30, 2021 •

edited

Loading

psumbera commented Dec 1, 2021

nagisa commented Dec 1, 2021

bors commented Dec 1, 2021

bors commented Dec 2, 2021

bors commented Dec 2, 2021

rust-timer commented Dec 2, 2021

glaubitz commented Dec 2, 2021

fix sparc64 ABI for aggregates with floating point members #91003

fix sparc64 ABI for aggregates with floating point members #91003

Conversation

psumbera commented Nov 18, 2021

rust-highfive commented Nov 18, 2021

psumbera commented Nov 18, 2021

This comment has been minimized.

nagisa commented Nov 18, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

psumbera commented Nov 19, 2021

nagisa commented Nov 19, 2021 • edited Loading

psumbera commented Nov 19, 2021

psumbera commented Nov 19, 2021

nagisa commented Nov 19, 2021

nagisa commented Nov 22, 2021

nagisa commented Nov 24, 2021

bors commented Nov 24, 2021

matthiaskrgr commented Nov 25, 2021

psumbera commented Nov 30, 2021

nagisa commented Nov 30, 2021

bors commented Nov 30, 2021

bors commented Nov 30, 2021

This comment has been minimized.

bors commented Nov 30, 2021

nagisa commented Nov 30, 2021 • edited Loading

psumbera commented Dec 1, 2021

nagisa commented Dec 1, 2021

bors commented Dec 1, 2021

bors commented Dec 2, 2021

bors commented Dec 2, 2021

rust-timer commented Dec 2, 2021

glaubitz commented Dec 2, 2021

nagisa commented Nov 19, 2021 •

edited

Loading

nagisa commented Nov 30, 2021 •

edited

Loading