Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ptr range iterable #91000

Closed
wants to merge 7 commits into from
Closed

Make ptr range iterable #91000

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift click to select a range
88150bd
Make ptr range iterable
dtolnay Nov 18, 2021
7ac5ca3
More ptr range test cases
dtolnay Nov 18, 2021
1f15e73
Document alignedness of ptr range elements
dtolnay Nov 18, 2021
f6db190
Add ui test of ptr range coercion
dtolnay Nov 18, 2021
47c8646
Document add/get_unchecked alternatives
dtolnay Nov 18, 2021
4cb6151
Err(0) is no longer going to be okay following PR 89916
dtolnay Nov 18, 2021
81d29d4
Produce better machine code for a loop over ptr range
dtolnay Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More ptr range test cases
  • Loading branch information
@dtolnay
dtolnay committed Nov 18, 2021
commit 7ac5ca3943b0aa1c1eea54431b11ad62c56438f2
87 changes: 87 additions & 0 deletions library/core/tests/iter/range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,3 632,90 @@ fn test_ptr_range_zero_sized() {
assert_eq!(range.advance_back_by(1), Ok(()));
assert_eq!(range, start..end);
}

#[test]
fn test_ptr_range_reversed() {
let start = 2222 as *const i32;
let end = 1111 as *const i32;
let range = start..end;
assert!(range.is_empty());
assert_eq!(range.size_hint(), (0, Some(0)));
assert_eq!(range.clone().next(), None);
assert_eq!(range.clone().nth(0), None);
assert_eq!(range.clone().nth(1), None);
assert_eq!(range.clone().advance_by(0), Ok(())); // Err(0) would be equally fine
dtolnay marked this conversation as resolved.
Show resolved Hide resolved
assert_eq!(range.clone().advance_by(1), Err(0));
assert_eq!(range.clone().next_back(), None);
assert_eq!(range.clone().nth_back(0), None);
assert_eq!(range.clone().nth_back(1), None);
assert_eq!(range.clone().advance_back_by(0), Ok(())); // Err(0) would be equally fine
assert_eq!(range.clone().advance_back_by(1), Err(0));

let start = 2222 as *const ();
let end = 1111 as *const ();
let range = start..end;
assert!(range.is_empty());
assert_eq!(range.size_hint(), (0, Some(0)));
assert_eq!(range.clone().next(), None);
assert_eq!(range.clone().nth(0), None);
assert_eq!(range.clone().nth(1), None);
assert_eq!(range.clone().advance_by(0), Ok(()));
assert_eq!(range.clone().advance_by(1), Err(0));
assert_eq!(range.clone().next_back(), None);
assert_eq!(range.clone().nth_back(0), None);
assert_eq!(range.clone().nth_back(1), None);
assert_eq!(range.clone().advance_back_by(0), Ok(()));
assert_eq!(range.clone().advance_back_by(1), Err(0));
}

#[test]
fn test_ptr_range_underflow() {
let start = 1 as *const [u8; 100];
let end = 2 as *const [u8; 100];

let mut range = start..end;
assert_eq!(range.next_back(), Some(start));
assert_eq!(range, start..start);

let mut range = start..end;
assert_eq!(range.nth_back(0), Some(start));
assert_eq!(range, start..start);

let mut range = start..end;
assert_eq!(range.nth_back(1), None);
assert_eq!(range, start..start);

let mut range = start..end;
assert_eq!(range.advance_back_by(0), Ok(()));
assert_eq!(range, start..end);

let mut range = start..end;
assert_eq!(range.advance_back_by(1), Ok(()));
assert_eq!(range, start..start);
}

#[test]
fn test_ptr_range_overflow() {
let start = (usize::MAX - 2) as *const [u8; 100];
let end = usize::MAX as *const [u8; 100];

let mut range = start..end;
assert_eq!(range.next(), Some(start));
assert_eq!(range, end..end);

let mut range = start..end;
assert_eq!(range.nth(0), Some(start));
assert_eq!(range, end..end);

let mut range = start..end;
assert_eq!(range.nth(1), None);
assert_eq!(range, end..end);

let mut range = start..end;
assert_eq!(range.advance_by(0), Ok(()));
assert_eq!(range, start..end);

let mut range = start..end;
assert_eq!(range.advance_by(1), Ok(()));
assert_eq!(range, end..end);
}