Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change environment variable getters to error recoverably #86183

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Change environment variable getters to error recoverably #86183

merged 4 commits into from
Aug 2, 2021

Commits on Jul 6, 2021

  1. Change env var getters to error recoverably 

    Before this, `std`'s env var getter functions would panic on
receiving certain invalid inputs. This commit makes them
return a `None` or `Err` instead.
    @inquisitivecrystal
    inquisitivecrystal committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    f2c0f29 View commit details
    Browse the repository at this point in the history

  2. Add test to prevent regression

    @inquisitivecrystal
    inquisitivecrystal committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    d26e01e View commit details
    Browse the repository at this point in the history

  3. Make getenv return an Option instead of a Result

    @inquisitivecrystal
    inquisitivecrystal committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    a12107a View commit details
    Browse the repository at this point in the history

  4. Improve env var getter docs

    @inquisitivecrystal
    inquisitivecrystal committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    d9752c7 View commit details
    Browse the repository at this point in the history