Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop alias reduce for fold - we have a reduce function #84706

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

joshtriplett
Copy link
Member

Searching for "reduce" currently puts the reduce alias for fold
above the actual reduce function. The reduce function already has a
cross-reference for fold, and vice versa.

Searching for "reduce" currently puts the `reduce` alias for `fold`
above the actual `reduce` function. The `reduce` function already has a
cross-reference for `fold`, and vice versa.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2021
@joshtriplett joshtriplett added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 29, 2021
@joshtriplett
Copy link
Member Author

r? @m-ou-se

@m-ou-se
Copy link
Member

m-ou-se commented Apr 29, 2021

This was supposed to make that "see also" link more visible, also in the search results. But looks like the search results are just more confusing now:
image

@bors r

@bors
Copy link
Contributor

bors commented Apr 29, 2021

📌 Commit 20b569f has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Apr 29, 2021

@bors rollup

jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
Drop alias `reduce` for `fold` - we have a `reduce` function

Searching for "reduce" currently puts the `reduce` alias for `fold`
above the actual `reduce` function. The `reduce` function already has a
cross-reference for `fold`, and vice versa.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
Drop alias `reduce` for `fold` - we have a `reduce` function

Searching for "reduce" currently puts the `reduce` alias for `fold`
above the actual `reduce` function. The `reduce` function already has a
cross-reference for `fold`, and vice versa.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
Drop alias `reduce` for `fold` - we have a `reduce` function

Searching for "reduce" currently puts the `reduce` alias for `fold`
above the actual `reduce` function. The `reduce` function already has a
cross-reference for `fold`, and vice versa.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
Drop alias `reduce` for `fold` - we have a `reduce` function

Searching for "reduce" currently puts the `reduce` alias for `fold`
above the actual `reduce` function. The `reduce` function already has a
cross-reference for `fold`, and vice versa.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#84451 (Use flex more consistently)
 - rust-lang#84590 (Point out that behavior might be switched on 2015 and 2018 too one day)
 - rust-lang#84682 (Don't rebind in `transitive_bounds_that_define_assoc_type`)
 - rust-lang#84683 (Minor grammar tweaks for readability to btree internals)
 - rust-lang#84688 (Remove unnecessary CSS rules for search results)
 - rust-lang#84690 (Remove unneeded bottom margin on search results)
 - rust-lang#84692 (Link between std::env::{var, var_os} and std::env::{vars, vars_os})
 - rust-lang#84705 (make feature recommendations optional)
 - rust-lang#84706 (Drop alias `reduce` for `fold` - we have a `reduce` function)
 - rust-lang#84713 (Fix labels for regression issue template)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32c5f39 into rust-lang:master Apr 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants