Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for thread-local and code-model=large #84508

Closed
wants to merge 1 commit into from
Closed

Add test for thread-local and code-model=large #84508

wants to merge 1 commit into from

Conversation

marmeladema
Copy link
Contributor

Closes #37508

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2021
@Mark-Simulacrum
Copy link
Member

@bors r rollup

@bors
Copy link
Contributor

bors commented Apr 28, 2021

📌 Commit cbd647f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2021
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Apr 28, 2021
@m-ou-se
Rollup merge of rust-lang#84508 - marmeladema:test-thread-local-issue…
fadb8f0 
…-37508, r=Mark-Simulacrum

Add test for thread-local and code-model=large

Closes rust-lang#37508
@m-ou-se m-ou-se mentioned this pull request Apr 28, 2021
Closed
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge of rust-lang#84508 - marmeladema:test-thread-local-issue…
cf6b13c 
…-37508, r=Mark-Simulacrum

Add test for thread-local and code-model=large

Closes rust-lang#37508
@jackh726 jackh726 mentioned this pull request Apr 29, 2021
Closed
@jackh726
Copy link
Member

Failed in #84680 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2021
@crlf0710
Copy link
Member

@marmeladema PIng from triage, this PR is causing test failures in rollup pr. Might taking a look?

@crlf0710
Copy link
Member

crlf0710 commented Jun 5, 2021

@marmeladema Ping from triage, any updates on this?

@Dylan-DPC-zz
Copy link

Closing this due to inactivity and it is small so it can be reopened/recreated at any point in future. Thanks for taking the time

@JohnTitor JohnTitor mentioned this pull request Jun 16, 2021
Merged
@JohnTitor
Copy link
Member

Closing as superseded by #86352 and inactivity, thanks for the PR anyway!

@JohnTitor JohnTitor closed this Jun 16, 2021
@marmeladema marmeladema deleted the test-thread-local-issue-37508 branch June 16, 2021 08:10
@marmeladema
Copy link
Contributor Author

Sorry I could not find time to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with -C code-model=large and thread locals
8 participants
@marmeladema @rust-highfive @Mark-Simulacrum @bors @jackh726 @crlf0710 @Dylan-DPC-zz @JohnTitor