Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses flex to fix formatting of h1 at any width #84376

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Uses flex to fix formatting of h1 at any width #84376

merged 2 commits into from
Apr 22, 2021

Conversation

torhovland
Copy link
Contributor

@torhovland torhovland commented Apr 20, 2021 •
edited
Loading

Fixes #84354.

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @ollie27

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2021
@torhovland
Copy link
Contributor Author

This looks OK on Safari on iPhone 6, using a fake trait name to demonstrate the wrapping. Tested on a real device using BrowserStack:

iPhone-6

Edge also looks good:

Edge

@torhovland
Copy link
Contributor Author

For consistency, I do recommend also changing the other places where .out-of-band is used from float: right to using flex like here.

@GuillaumeGomez
Copy link
Member

@torhovland Thanks!

For consistency, I do recommend also changing the other places where .out-of-band is used from float: right to using flex like here.

Do you want to send another PR to improve it as well?

@GuillaumeGomez
Copy link
Member

In the meantime:

@bors: r

@bors
Copy link
Contributor

bors commented Apr 22, 2021

📌 Commit bb91805 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2021
@torhovland
Copy link
Contributor Author

Do you want to send another PR to improve it as well?

Sure, I can give it a shot.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 22, 2021
@Dylan-DPC
Rollup merge of rust-lang#84376 - torhovland:issue-84534, r=Guillaume…
3d1b81c 
…Gomez

Uses flex to fix formatting of h1 at any width

Fixes rust-lang#84354.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 22, 2021
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2021
@bors
Auto merge of rust-lang#84440 - Dylan-DPC:rollup-0xjb8oi, r=Dylan-DPC
5f1aeb5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#84343 (Remove `ScopeTree::closure_tree`)
 - rust-lang#84376 (Uses flex to fix formatting of h1 at any width)
 - rust-lang#84377 (Followup to rust-lang#83944)
 - rust-lang#84396 (Update LLVM submodule)
 - rust-lang#84402 (Move `sys_common::rwlock::StaticRWLock` etc. to `sys::unix::rwlock`)
 - rust-lang#84404 (Check for intrinsics before coercing to a function pointer)
 - rust-lang#84413 (Remove `sys::args::Args::inner_debug` and use `Debug` instead)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@torhovland torhovland mentioned this pull request Apr 22, 2021
Merged
@bors bors merged commit 7b6fd61 into rust-lang:master Apr 22, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 22, 2021
@jsha jsha mentioned this pull request Apr 23, 2021
Closed
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 23, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
@Dylan-DPC
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
a375058 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
@Dylan-DPC
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
1d65997 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
@Dylan-DPC
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
cc57bf6 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
9381fe1 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
6d18bcf 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
3ad9b00 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
8f956a3 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
@jackh726
Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha
2e58633 
Use flex more consistently

Builds on rust-lang#84376, related to rust-lang#84354.

- Fully replaces `float: right` with `flex` on `.content .out-of-band`.
- Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).

Tested on various widths to make sure the pages behave as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@ollie27 ollie27

Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

rustdoc: Declaration truncated on small mobile screens
6 participants
@torhovland @rust-highfive @GuillaumeGomez @bors @ollie27 @rustbot