Deprecate crate_type and crate_name nested inside #![cfg_attr] #83744

bjorn3 · 2021-04-01T10:17:29Z

This implements the proposal in #83676 (comment), with a future compatibility lint imposed on usage of crate_type/crate_name inside cfg's.

This is a compromise between removing #![crate_type] and #![crate_name] completely and keeping them as a whole, which requires somewhat of a hack in rustc and is impossible to support by gcc-rust. By only removing #![crate_type] and #![crate_name] nested inside #![cfg_attr] it becomes possible to parse them before a big chunk of the compiler has started.

Replaces #83676

#![crate_type = "lib"] // remains working
#![cfg_attr(foo, crate_type = "bin")] // will stop working

Rationale

As it currently is it is possible to try to access the stable crate id before it is actually set, which will panic. The fact that the Session contains mutable state beyond debugging things also doesn't completely sit well with me. Especially once parallel rustc becomes the default.

I think there is currently also a cyclic dependency where you need to set the stable crate id to be able to load crates, but you need to load crates to expand proc macro attributes that may define #![crate_name] or #![crate_type]. Currently crate level proc macro attributes are unstable or completely unsupported (can't remember which), so this is not a problem, but it may become an issue in the future.

Finally if we want to add incremental compilation to macro expansion or even parsing, we need the StableCrateId to be created together with the Session or even earlier as incremental compilation determines the incremental compilation session dir based on the StableCrateId.

rust-highfive · 2021-04-01T10:17:32Z

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

bjorn3 · 2021-04-01T11:54:50Z

Support for this was introduced in #25399.

Part of the rationale was: #25347 (comment)

I'm actually kind of surprised to see this bug. I would have expected #![cfg_attr] to be used in order to enable features based on cargo features, e.g. a cargo feature nightly that enables the use of features such that the same lib can be used in the beta and nightly channels.

This is actually not true. #![crate_name] must match the value passed in using --crate-name by cargo.

$ echo '#![crate_name = "foo"] fn main() {}' | rustc - --crate-name bar
error: `--crate-name` and `#[crate_name]` are required to match, but `bar` != `foo`
 --> <anon>:1:1
  |
1 | #![crate_name = "foo"] fn main() {}
  | ^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

Surprisingly #![crate_type] is even completely ignored when using --crate-type:

$ echo '#![crate_type = "lib"] fn main() {}' | rustc - --crate-type bin
$ ls
rust_out

I thought it merely had to match, just like the crate name.

joshtriplett · 2021-04-01T16:49:45Z

@bjorn3 To confirm, based on your knowledge of the compiler internals, you believe that if we manage to remove this and require that these directives only appear at the top level if at all, we can substantially simplify the logic to handle them in the Rust compiler? Your description that it's "somewhat of a hack in rustc" sounds like there's simplification to be had, and that simplification would be a reasonable motivation to make this change if it turns out no crates use it.

bjorn3 · 2021-04-01T16:59:55Z

Your description that it's "somewhat of a hack in rustc" sounds like there's simplification to be had

Indeed

and that simplification would be a reasonable motivation to make this change if it turns out no crates use it.

IMHO yes. In addition #![cfg_attr(..., crate_type = "...")] can't be supported by rust-gcc.

joshtriplett · 2021-04-02T08:47:54Z

The former seems like a sufficient rationale to give this a try. Starting a try run in preparation for a crater run. If the crater run comes back clean, this seems potentially reasonable.

joshtriplett · 2021-04-02T08:48:02Z

@bors try

bors · 2021-04-02T08:48:10Z

⌛ Trying commit 8e4eb5f3283e0d02c4d46d144e6146011d1d4e73 with merge 45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4...

bors · 2021-04-02T09:36:04Z

☀️ Try build successful - checks-actions
Build commit: 45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4 (45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4)

bjorn3 · 2021-04-02T16:53:39Z

@craterbot check

craterbot · 2021-04-02T16:53:46Z

👌 Experiment pr-83744 created and queued.
🤖 Automatically detected try build 45d8b6e68beee1c9c1ce92ae258a7e02f8f13aa4
⚠️ Try build based on commit 4fa76a4, but latest commit is 8e4eb5f3283e0d02c4d46d144e6146011d1d4e73. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-04-19T14:10:29Z

🚧 Experiment pr-83744 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2021-04-22T22:26:47Z

🎉 Experiment pr-83744 is completed!
📊 9 regressed and 17 fixed (154464 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bjorn3 · 2021-04-23T05:38:36Z

All regressions are spurious. They are either network errors or linkers crashing without any output.

est31 · 2021-04-23T09:49:17Z

That's really good, although a crater report might not be best suited to turn up cases where these things may occur, as I expect them to be used mainly outside of cargo built codebases.

I've looke for crate_type and crate_name on google's opensource code search, couldn't find anything that could cause a problem.

I've used searchcode.com to look for any repos on gitlab or bitbucket, but no cfg_attr use showed up. crate_type, crate_name.

Using searchcode.com for github turns up too much repetitive stuff for it to be sifted through reasonably in a manual fashion. Same goes for github's builtin search, no way to narrow it down. Anyone know of a better search engine?

bjorn3 · 2021-04-23T10:07:07Z

grep.app shows exactly one usage: https://github.com/dropbox/divans/blob/23459c22f8a63e0a70ef1b968402ae0b3682168f/src/lib.rs#L21 This also enables two feature gates when the same cfg is used and they use cargo so it shouldn't have any effect.

(I believe grep.app doesn't search all of github, but it does search a large portion in my experience)

est31 · 2021-04-23T10:17:27Z

Interesting, thanks for pointing to grep.app!

I'm a bit familiar with the repo it found, having filed a PR against it in 2018. It has been ignored for 2 years until I closed it. In that same period, nothing else has been commited to the repo's master branch (or any other PR filed/merged). So it's kinda dead I'd say. It might be used internally at dropbox, idk.

So overall the fallout is manageable I think.

bjorn3 · 2021-04-28T17:07:12Z

Can this land as is, or should I turn it into a future compatibility lint?

Mark-Simulacrum · 2021-11-23T18:52:46Z

Discussed during lang meeting today -- we agreed this doesn't need FCP given just adding a future compatibility warning. I'll take a look at the impl itself shortly and request changes or indicate approval modulo the rebase.

Mark-Simulacrum

r=me with the future compat issue filed

compiler/rustc_lint_defs/src/builtin.rs

Mark-Simulacrum · 2021-12-07T16:48:13Z

@bors r rollup

bors · 2021-12-07T16:48:14Z

📌 Commit 9b6c510 has been approved by Mark-Simulacrum

…e_name, r=Mark-Simulacrum Deprecate crate_type and crate_name nested inside #![cfg_attr] This implements the proposal in rust-lang#83676 (comment), with a future compatibility lint imposed on usage of crate_type/crate_name inside cfg's. This is a compromise between removing `#![crate_type]` and `#![crate_name]` completely and keeping them as a whole, which requires somewhat of a hack in rustc and is impossible to support by gcc-rust. By only removing `#![crate_type]` and `#![crate_name]` nested inside `#![cfg_attr]` it becomes possible to parse them before a big chunk of the compiler has started. Replaces rust-lang#83676 ```rust #![crate_type = "lib"] // remains working #![cfg_attr(foo, crate_type = "bin")] // will stop working ``` # Rationale As it currently is it is possible to try to access the stable crate id before it is actually set, which will panic. The fact that the Session contains mutable state beyond debugging things also doesn't completely sit well with me. Especially once parallel rustc becomes the default. I think there is currently also a cyclic dependency where you need to set the stable crate id to be able to load crates, but you need to load crates to expand proc macro attributes that may define #![crate_name] or #![crate_type]. Currently crate level proc macro attributes are unstable or completely unsupported (can't remember which), so this is not a problem, but it may become an issue in the future. Finally if we want to add incremental compilation to macro expansion or even parsing, we need the StableCrateId to be created together with the Session or even earlier as incremental compilation determines the incremental compilation session dir based on the StableCrateId.

…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#83744 (Deprecate crate_type and crate_name nested inside #![cfg_attr]) - rust-lang#90550 (Update certificates in some Ubuntu 16 images.) - rust-lang#91272 (Print a suggestion when comparing references to primitive types in `const fn`) - rust-lang#91467 (Emphasise that an OsStr[ing] is not necessarily a platform string) - rust-lang#91531 (Do not add `;` to expected tokens list when it's wrong) - rust-lang#91577 (Address some FIXMEs left over from rust-lang#91475) - rust-lang#91638 (Remove `in_band_lifetimes` from `rustc_mir_transform`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Pkgsrc changes: * Bump available bootstraps to 1.58.1. * Adjust one patch (and checksum) so that it still applies. Upstream changes: Version 1.59.0 (2022-02-24) ========================== Language -------- - [Stabilize default arguments for const generics][90207] - [Stabilize destructuring assignment][90521] - [Relax private in public lint on generic bounds and where clauses of trait impls][90586] - [Stabilize asm! and global_asm! for x86, x86_64, ARM, Aarch64, and RISC-V][91728] Compiler -------- - [Stabilize new symbol mangling format, leaving it opt-in (-Csymbol-mangling-version=v0)][90128] - [Emit LLVM optimization remarks when enabled with `-Cremark`][90833] - [Fix sparc64 ABI for aggregates with floating point members][91003] - [Warn when a `#[test]`-like built-in attribute macro is present multiple times.][91172] - [Add support for riscv64gc-unknown-freebsd][91284] - [Stabilize `-Z emit-future-incompat` as `--json future-incompat`][91535] - [Soft disable incremental compilation][94124] This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to a known and relatively frequently occurring bug in incremental compilation, which causes builds to issue internal compiler errors. This particular bug is already fixed on nightly, but that fix has not yet rolled out to stable and is deemed too risky for a direct stable backport. As always, we encourage users to test with nightly and report bugs so that we can track failures and fix issues earlier. See [94124] for more details. [94124]: rust-lang/rust#94124 Libraries --------- - [Remove unnecessary bounds for some Hash{Map,Set} methods][91593] Stabilized APIs --------------- - [`std::thread::available_parallelism`][available_parallelism] - [`Result::copied`][result-copied] - [`Result::cloned`][result-cloned] - [`arch::asm!`][asm] - [`arch::global_asm!`][global_asm] - [`ops::ControlFlow::is_break`][is_break] - [`ops::ControlFlow::is_continue`][is_continue] - [`TryFrom<char> for u8`][try_from_char_u8] - [`char::TryFromCharError`][try_from_char_err] implementing `Clone`, `Debug`, `Display`, `PartialEq`, `Copy`, `Eq`, `Error` - [`iter::zip`][zip] - [`NonZeroU8::is_power_of_two`][is_power_of_two8] - [`NonZeroU16::is_power_of_two`][is_power_of_two16] - [`NonZeroU32::is_power_of_two`][is_power_of_two32] - [`NonZeroU64::is_power_of_two`][is_power_of_two64] - [`NonZeroU128::is_power_of_two`][is_power_of_two128] - [`DoubleEndedIterator for ToLowercase`][lowercase] - [`DoubleEndedIterator for ToUppercase`][uppercase] - [`TryFrom<&mut [T]> for [T; N]`][tryfrom_ref_arr] - [`UnwindSafe for Once`][unwindsafe_once] - [`RefUnwindSafe for Once`][refunwindsafe_once] - [armv8 neon intrinsics for aarch64][stdarch/1266] Const-stable: - [`mem::MaybeUninit::as_ptr`][muninit_ptr] - [`mem::MaybeUninit::assume_init`][muninit_init] - [`mem::MaybeUninit::assume_init_ref`][muninit_init_ref] - [`ffi::CStr::from_bytes_with_nul_unchecked`][cstr_from_bytes] Cargo ----- - [Stabilize the `strip` profile option][cargo/10088] - [Stabilize future-incompat-report][cargo/10165] - [Support abbreviating `--release` as `-r`][cargo/10133] - [Support `term.quiet` configuration][cargo/10152] - [Remove `--host` from cargo {publish,search,login}][cargo/10145] Compatibility Notes ------------------- - [Refactor weak symbols in std::sys::unix][90846] This may add new, versioned, symbols when building with a newer glibc, as the standard library uses weak linkage rather than dynamically attempting to load certain symbols at runtime. - [Deprecate crate_type and crate_name nested inside `#![cfg_attr]`][83744] This adds a future compatibility lint to supporting the use of cfg_attr wrapping either crate_type or crate_name specification within Rust files; it is recommended that users migrate to setting the equivalent command line flags. - [Remove effect of `#[no_link]` attribute on name resolution][92034] This may expose new names, leading to conflicts with preexisting names in a given namespace and a compilation failure. - [Cargo will document libraries before binaries.][cargo/10172] - [Respect doc=false in dependencies, not just the root crate][cargo/10201] - [Weaken guarantee around advancing underlying iterators in zip][83791] - [Make split_inclusive() on an empty slice yield an empty output][89825] - [Update std::env::temp_dir to use GetTempPath2 on Windows when available.][89999] - [unreachable! was updated to match other formatting macro behavior on Rust 2021][92137] Internal Changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Fix many cases of normalization-related ICEs][91255] - [Replace dominators algorithm with simple Lengauer-Tarjan][85013] - [Store liveness in interval sets for region inference][90637] - [Remove `in_band_lifetimes` from the compiler and standard library, in preparation for removing this unstable feature.][91867] [91867]: rust-lang/rust#91867 [83744]: rust-lang/rust#83744 [83791]: rust-lang/rust#83791 [85013]: rust-lang/rust#85013 [89825]: rust-lang/rust#89825 [89999]: rust-lang/rust#89999 [90128]: rust-lang/rust#90128 [90207]: rust-lang/rust#90207 [90521]: rust-lang/rust#90521 [90586]: rust-lang/rust#90586 [90637]: rust-lang/rust#90637 [90833]: rust-lang/rust#90833 [90846]: rust-lang/rust#90846 [91003]: rust-lang/rust#91003 [91172]: rust-lang/rust#91172 [91255]: rust-lang/rust#91255 [91284]: rust-lang/rust#91284 [91535]: rust-lang/rust#91535 [91593]: rust-lang/rust#91593 [91728]: rust-lang/rust#91728 [91878]: rust-lang/rust#91878 [91896]: rust-lang/rust#91896 [91926]: rust-lang/rust#91926 [91984]: rust-lang/rust#91984 [92020]: rust-lang/rust#92020 [92034]: rust-lang/rust#92034 [92483]: rust-lang/rust#92483 [cargo/10088]: rust-lang/cargo#10088 [cargo/10133]: rust-lang/cargo#10133 [cargo/10145]: rust-lang/cargo#10145 [cargo/10152]: rust-lang/cargo#10152 [cargo/10165]: rust-lang/cargo#10165 [cargo/10172]: rust-lang/cargo#10172 [cargo/10201]: rust-lang/cargo#10201 [cargo/10269]: rust-lang/cargo#10269 [cstr_from_bytes]: https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked [muninit_ptr]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.as_ptr [muninit_init]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init [muninit_init_ref]: https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.assume_init_ref [unwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-UnwindSafe [refunwindsafe_once]: https://doc.rust-lang.org/stable/std/sync/struct.Once.html#impl-RefUnwindSafe [tryfrom_ref_arr]: https://doc.rust-lang.org/stable/std/convert/trait.TryFrom.html#impl-TryFrom<&'_ mut [T]> [lowercase]: https://doc.rust-lang.org/stable/std/char/struct.ToLowercase.html#impl-DoubleEndedIterator [uppercase]: https://doc.rust-lang.org/stable/std/char/struct.ToUppercase.html#impl-DoubleEndedIterator [try_from_char_err]: https://doc.rust-lang.org/stable/std/char/struct.TryFromCharError.html [available_parallelism]: https://doc.rust-lang.org/stable/std/thread/fn.available_parallelism.html [result-copied]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.copied [result-cloned]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.cloned [asm]: https://doc.rust-lang.org/stable/core/arch/macro.asm.html [global_asm]: https://doc.rust-lang.org/stable/core/arch/macro.global_asm.html [is_break]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_break [is_continue]: https://doc.rust-lang.org/stable/std/ops/enum.ControlFlow.html#method.is_continue [try_from_char_u8]: https://doc.rust-lang.org/stable/std/primitive.char.html#impl-TryFrom [zip]: https://doc.rust-lang.org/stable/std/iter/fn.zip.html [is_power_of_two8]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU8.html#method.is_power_of_two [is_power_of_two16]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU16.html#method.is_power_of_two [is_power_of_two32]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU32.html#method.is_power_of_two [is_power_of_two64]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU64.html#method.is_power_of_two [is_power_of_two128]: https://doc.rust-lang.org/stable/core/num/struct.NonZeroU128.html#method.is_power_of_two [stdarch/1266]: rust-lang/stdarch#1266

…, r=Mark-Simulacrum Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default Turns the forward compatibility lint added by rust-lang#83744 to deprecate `cfg_attr` usage with `#![crate_type]` and `#![crate_name]` attributes into deny by default. Copying the example from rust-lang#83744: ```Rust #![crate_type = "lib"] // remains working #![cfg_attr(foo, crate_type = "bin")] // will stop working ``` Over 8 months have passed since rust-lang#83744 was merged so I'd say this gives ample time for people to have been warned, so we can make the warning stronger. No usage was found via grep.app except for one, which was in an unmaintained code base that didn't seem to be used in the open source eco system. The crater run conducted in rust-lang#83744 also didn't show up anything. cc rust-lang#91632 - tracking issue for the lint

…, r=Urgau Make deprecated_cfg_attr_crate_type_name a hard error Turns the forward compatibility lint added by rust-lang#83744 into a hard error, so now, while the `#![crate_name]` and `#![crate_type]` attributes are still allowed in raw form, they are now forbidden to be nested inside a `#![cfg_attr()]` attribute. The following will now be an error: ```Rust #![cfg_attr(foo, crate_name = "foobar")] #![cfg_attr(foo, crate_type = "bin")] ``` This code will continue working and is not deprecated: ```Rust #![crate_name = "foobar"] #![crate_type = "lib"] ``` The reasoning for this is explained in rust-lang#83744: it allows us to not have to cfg-expand in order to determine the crate's type and name. As of filing the PR, exactly two years have passed since rust-lang#99784 has been merged, which has turned the lint's default warning level into an error, so there has been ample time to move off the now-forbidden syntax. cc rust-lang#91632 - tracking issue for the lint

bjorn3 added T-lang Relevant to the language team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Apr 1, 2021

rust-highfive assigned matthewjasper Apr 1, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2021

bjorn3 mentioned this pull request Apr 1, 2021

Deprecate #![crate_type] and #![crate_name] #83676

Closed

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the deprecate_cfg_attr_crate_type_name branch from 55d8d5f to 13a7a35 Compare April 1, 2021 10:35

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2021

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 22, 2021

Mark-Simulacrum reviewed Dec 6, 2021

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Show resolved Hide resolved

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2021

bjorn3 force-pushed the deprecate_cfg_attr_crate_type_name branch from 71f5717 to ec3ec98 Compare December 7, 2021 15:38

bjorn3 mentioned this pull request Dec 7, 2021

Tracking issue for future-incompatibility lint deprecated_cfg_attr_crate_type_name #91632

Closed

3 tasks

bjorn3 force-pushed the deprecate_cfg_attr_crate_type_name branch from ec3ec98 to 8f6a8d6 Compare December 7, 2021 15:50

bjorn3 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2021

Future compatibility warning on cfg_attr on crate_type and crate_name

9b6c510

Mark-Simulacrum force-pushed the deprecate_cfg_attr_crate_type_name branch from 8f6a8d6 to 9b6c510 Compare December 7, 2021 16:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2021

This was referenced Dec 8, 2021

Rollup of 14 pull requests #91650

Closed

Rollup of 7 pull requests #91656

Merged

bors merged commit da158c0 into rust-lang:master Dec 8, 2021

rustbot added this to the 1.59.0 milestone Dec 8, 2021

bjorn3 deleted the deprecate_cfg_attr_crate_type_name branch December 8, 2021 14:29

bjorn3 mentioned this pull request Jul 26, 2022

#![crate_type] and #![crate_name] aren't allowed inside cfg_attr ferrocene/specification#164

Open

est31 mentioned this pull request Jul 26, 2022

Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default #99784

Merged

est31 mentioned this pull request Aug 27, 2024

Make deprecated_cfg_attr_crate_type_name a hard error #129670

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate crate_type and crate_name nested inside #![cfg_attr] #83744

Deprecate crate_type and crate_name nested inside #![cfg_attr] #83744

bjorn3 commented Apr 1, 2021 •

edited by Mark-Simulacrum

Loading

rust-highfive commented Apr 1, 2021

This comment has been minimized.

This comment has been minimized.

bjorn3 commented Apr 1, 2021

joshtriplett commented Apr 1, 2021

bjorn3 commented Apr 1, 2021

joshtriplett commented Apr 2, 2021

joshtriplett commented Apr 2, 2021

bors commented Apr 2, 2021

bors commented Apr 2, 2021

bjorn3 commented Apr 2, 2021

craterbot commented Apr 2, 2021

craterbot commented Apr 19, 2021

craterbot commented Apr 22, 2021

bjorn3 commented Apr 23, 2021

est31 commented Apr 23, 2021

bjorn3 commented Apr 23, 2021 •

edited

Loading

est31 commented Apr 23, 2021

bjorn3 commented Apr 28, 2021

Mark-Simulacrum commented Nov 23, 2021

Mark-Simulacrum left a comment

Mark-Simulacrum commented Dec 7, 2021

bors commented Dec 7, 2021

Deprecate crate_type and crate_name nested inside #![cfg_attr] #83744

Deprecate crate_type and crate_name nested inside #![cfg_attr] #83744

Conversation

bjorn3 commented Apr 1, 2021 • edited by Mark-Simulacrum Loading

Rationale

rust-highfive commented Apr 1, 2021

This comment has been minimized.

This comment has been minimized.

bjorn3 commented Apr 1, 2021

joshtriplett commented Apr 1, 2021

bjorn3 commented Apr 1, 2021

joshtriplett commented Apr 2, 2021

joshtriplett commented Apr 2, 2021

bors commented Apr 2, 2021

bors commented Apr 2, 2021

bjorn3 commented Apr 2, 2021

craterbot commented Apr 2, 2021

craterbot commented Apr 19, 2021

craterbot commented Apr 22, 2021

bjorn3 commented Apr 23, 2021

est31 commented Apr 23, 2021

bjorn3 commented Apr 23, 2021 • edited Loading

est31 commented Apr 23, 2021

bjorn3 commented Apr 28, 2021

Mark-Simulacrum commented Nov 23, 2021

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum commented Dec 7, 2021

bors commented Dec 7, 2021

bjorn3 commented Apr 1, 2021 •

edited by Mark-Simulacrum

Loading

bjorn3 commented Apr 23, 2021 •

edited

Loading