Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rustfmt to v1.4.26 #79063

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Update rustfmt to v1.4.26 #79063

merged 1 commit into from
Nov 15, 2020

Conversation

calebcartwright
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2020
@Mark-Simulacrum
Copy link
Member

Note that this will go into 1.50 (1.48 releases in a week, 1.49 in 7).

@bors r

@bors
Copy link
Contributor

bors commented Nov 15, 2020

📌 Commit a49848a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2020
@calebcartwright
Copy link
Member Author

Note that this will go into 1.50 (1.48 releases in a week, 1.49 in 7).

Thanks!

Sorry for the semi-OT question, but is there a way I can check the beta status for #78775 (comment)? Without this, the version of rustfmt in beta currently is still panicking on nested tuple access and would hate to miss getting that fix into stable

@Mark-Simulacrum
Copy link
Member

I just unilaterally beta accepted that patch - my guess is it was missed in compiler team meetings? - I will do another round of beta backports tonight or tomorrow which will likely include that PR. Feel free to ping me on discord/zulip if something is pending like that, easy to overlook.

@calebcartwright
Copy link
Member Author

I will do another round of beta backports tonight or tomorrow which will likely include that PR. Feel free to ping me on discord/zulip if something is pending like that, easy to overlook.

Awesome, thanks so much!

@jonas-schievink jonas-schievink mentioned this pull request Nov 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2020
@bors
Auto merge of rust-lang#79070 - jonas-schievink:rollup-wacn2b8, r=jon…
5fab31e 
…as-schievink

Rollup of 13 pull requests

Successful merges:

 - rust-lang#77802 (Allow making `RUSTC_BOOTSTRAP` conditional on the crate name)
 - rust-lang#79004 (Add `--color` support to bootstrap)
 - rust-lang#79005 (cleanup: Remove `ParseSess::injected_crate_name`)
 - rust-lang#79016 (Make `_` an expression, to discard values in destructuring assignments)
 - rust-lang#79019 (astconv: extract closures into a separate trait)
 - rust-lang#79026 (Implement BTreeMap::retain and BTreeSet::retain)
 - rust-lang#79031 (Validate that locals have a corresponding `LocalDecl`)
 - rust-lang#79034 (rustc_resolve: Make `macro_rules` scope chain compression lazy)
 - rust-lang#79036 (Move Steal to rustc_data_structures.)
 - rust-lang#79041 (Rename clean::{ItemEnum -> ItemKind}, clean::Item::{inner -> kind})
 - rust-lang#79058 (Move likely/unlikely argument outside of invisible unsafe block)
 - rust-lang#79059 (Print 'checking cranelift artifacts' to easily separate it from other artifacts)
 - rust-lang#79063 (Update rustfmt to v1.4.26)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 568354f into rust-lang:master Nov 15, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@calebcartwright @rust-highfive @Mark-Simulacrum @bors @rustbot