Ensure that the source code display is working with DOS backline #77939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I just wonder about something: should I make this |
jyn514
added
the
T-rustdoc
|
I don't understand why this would fix the problem. Why is |
|
You gave me an idea. I'll check it out later. |
jyn514
added
S-waiting-on-author
crlf0710
added
S-waiting-on-author
|
The idea didn't work out unfortunately... So I think the current PR is as good as I can think. |
GuillaumeGomez
added
S-waiting-on-review
|
@GuillaumeGomez do you know why |
|
Because "\r\n" is considered as two backlines. :) |
jyn514
reviewed
Nov 15, 2020
jyn514
added
the
beta-nominated
GuillaumeGomez
force-pushed
the
fix-source-code-dos-backline
branch
from
a0aea9c to
5c4cd43
Compare
…ackline in source rendering
GuillaumeGomez
force-pushed
the
fix-source-code-dos-backline
branch
from
5c4cd43 to
0c52044
Compare
|
Add the test. |
|
@bors: r=jyn514 |
|
📌 Commit 0c52044 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 15, 2020
…backline, r=jyn514 Ensure that the source code display is working with DOS backline Fixes rust-lang#76361. cc `@lzutao` r? `@jyn514`
GuillaumeGomez
added
the
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2020
Rust 1.48.0 stable release This PR bumps the 1.48 beta branch to the 1.48 stable branch, and applies these last minute backports: * rust-lang#77939 - Ensure that the source code display is working with DOS backline * rust-lang#77508 - Fix capitalization in blog post name * rust-lang#78559 - Add LLVM upgrades from 7 to 10 to RELEASES.md * rust-lang#78364 - Update RELEASES.md for 1.48.0 r? `@ghost` cc `@rust-lang/release`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 16, 2020
…backline, r=jyn514 Ensure that the source code display is working with DOS backline Fixes rust-lang#76361. cc ``@lzutao`` r? ``@jyn514``
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 17, 2020
…backline, r=jyn514 Ensure that the source code display is working with DOS backline Fixes rust-lang#76361. cc ```@lzutao``` r? ```@jyn514```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#77939 (Ensure that the source code display is working with DOS backline) - rust-lang#78138 (Upgrade dlmalloc to version 0.2) - rust-lang#78967 (Make codegen tests compatible with extra inlining) - rust-lang#79027 (Limit storage duration of inlined always live locals) - rust-lang#79077 (document that __rust_alloc is also magic to our LLVM fork) - rust-lang#79088 (clarify `span_label` documentation) - rust-lang#79097 (Code block invalid html tag lint) - rust-lang#79105 (std: Fix test `symlink_hard_link` on Windows) - rust-lang#79107 (build-manifest: strip newline from rustc version) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
pietroalbini
removed
the
beta-nominated
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 17, 2020
Get rid of `highlight::Class::None` This is mostly me learning the codebase for rust-lang#77939, so feel free to close the PR. It does have the small benefit that we statically know rustdoc isn't generating useless `span`s, though. r? `@GuillaumeGomez` cc `@matklad`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2020
…crum Prepare beta 1.49.0 This PR sets everything up for beta 1.49.0, and backports the following PRs to it: * rust-lang#79107 - build-manifest: strip newline from rustc version * rust-lang#78986 - Avoid installing external LLVM dylibs * rust-lang#79074 - Install CI llvm into the library directory * rust-lang#78364 - Update RELEASES.md for 1.48.0 * rust-lang#77939 - Ensure that the source code display is working with DOS backline r? `@ghost` cc `@rust-lang/release`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2020
Actually prepare beta 1.49.0 This PR sets everything up for beta 1.49.0, and backports the following PRs to it: * rust-lang#79107 - build-manifest: strip newline from rustc version * rust-lang#78986 - Avoid installing external LLVM dylibs * rust-lang#79074 - Install CI llvm into the library directory * rust-lang#78364 - Update RELEASES.md for 1.48.0 * rust-lang#77939 - Ensure that the source code display is working with DOS backline This is the same as rust-lang#79132, but actually targeting the right branch. r? `@ghost` cc `@rust-lang/release`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76361.
cc @lzutao
r? @jyn514