Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rustc_lexer::TokenKind::Not to Bang #75743

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 20, 2020

All other tokens are named by the punctuation they use, rather than
by semantics operation they stand for. ! is the only exception to
the rule, let's fix it.

@matklad matklad added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI passes

@matklad
Copy link
Member Author

matklad commented Aug 20, 2020

@bors r=davidtwco rollup

@bors
Copy link
Contributor

bors commented Aug 20, 2020

📌 Commit ec9bf7e6599cd22ee449ddb15466e76fe131e3e6 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
@euclio
Copy link
Contributor

euclio commented Aug 20, 2020

Why not Bang?

@matklad
Copy link
Member Author

matklad commented Aug 20, 2020

@bors r-

Good question, I think Bang would be better

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2020
All other tokens are named by the punctuation they use, rather than
by semantics operation they stand for. `!` is the only exception to
the rule, let's fix it.
@matklad
Copy link
Member Author

matklad commented Aug 20, 2020

@bors r=davidtwco rollup

@bors
Copy link
Contributor

bors commented Aug 20, 2020

📌 Commit 5299297 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2020
@tesuji
Copy link
Contributor

tesuji commented Aug 20, 2020

PR title need to change too.

@matklad matklad changed the title Rename rustc_lexer::TokenKind::Not to Excl Rename rustc_lexer::TokenKind::Not to Bang Aug 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#75672 (Move to intra-doc links for task.rs and vec.rs)
 - rust-lang#75702 (Clean up E0759 explanation)
 - rust-lang#75703 (Enable stack-overflow detection on musl for non-main threads)
 - rust-lang#75710 (Fix bad printing of const-eval queries)
 - rust-lang#75716 (Upgrade Emscripten on CI to 1.39.20 )
 - rust-lang#75731 (Suppress ty::Float in MIR comments of ty::Const)
 - rust-lang#75733 (Remove duplicated alloc vec bench push_all_move)
 - rust-lang#75743 (Rename rustc_lexer::TokenKind::Not to Bang)

Failed merges:

r? @ghost
@bors bors merged commit 2a3f43d into rust-lang:master Aug 20, 2020
@matklad matklad deleted the excl branch August 20, 2020 20:28
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants