Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate constants during const_eval_raw #74949

Merged
merged 18 commits into from
Sep 20, 2020
Merged

Validate constants during const_eval_raw #74949

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
083f1d7
Validate constants during `const_eval_raw`
oli-obk Jul 30, 2020
2d7ac72
Stop using the `const_eval` query for initializers of statics
oli-obk Jul 31, 2020
6d3c7bb
Update codegen tests
oli-obk Jul 31, 2020
4397d66
Document `op_to_const`'s purpose
oli-obk Aug 10, 2020
b1bd34d
`turn_into_const` is infallible
oli-obk Aug 10, 2020
48f366f
Replace `and_then` `map_err` `and_then` chain with a match
oli-obk Aug 10, 2020
a6c60bb
Clarify a statement in UB test
oli-obk Aug 10, 2020
dd9702a
Do not call the `const_eval` query in mir interpretation except for c…
oli-obk Aug 10, 2020
40c2087
We can make const eval sound, it's just super expensive
oli-obk Aug 10, 2020
69a6be7
Rename const eval queries to reflect the validation changes
oli-obk Aug 10, 2020
888afd5
Unify the names of const eval queries and their return types
oli-obk Aug 20, 2020
90708c1
Fix rebase fallout and make the test work with debug info
oli-obk Aug 21, 2020
182ed85
Address review comments
oli-obk Sep 7, 2020
c3c8c98
Rustfmt
oli-obk Sep 9, 2020
ef04e68
Update compile-fail tests
oli-obk Sep 9, 2020
c5889e4
Update incremental tests
oli-obk Sep 9, 2020
b8e6883
Reflect the "do not call this query directly" mentality in its name
oli-obk Sep 19, 2020
34785fc
Make codegen test bitwidth-independent
oli-obk Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify a statement in UB test
  • Loading branch information
@oli-obk
oli-obk committed Sep 19, 2020
commit a6c60bbe5de9a090c8da30d5edbd27582f6b19e6
4 changes: 3 additions & 1 deletion src/test/ui/consts/const-eval/double_check2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// check-pass

// This test exhibits undefined behavior, but it is impossible to prevent generally during
// const eval, even if possible to prevent in the cases here. The reason it's impossible in general
// const eval, even if it could be prevented in the cases here if we added expensive and
// complex checks in rustc.
// The reason it's impossible in general
oli-obk marked this conversation as resolved.
Show resolved Hide resolved
// is that we run into query cycles even *without* UB, just because we're checking for UB.
// We do not detect it if you create references to statics
// in ways that are UB.
Expand Down