Correctly check for opaque types in assoc_ty_def
#67867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jan 4, 2020
matthewjasper
force-pushed
the
opaque-assoc-lookup
branch
from
a783e0c to
5e92625
Compare
|
@oli-obk Do you want to review this? |
oli-obk
reviewed
Jan 11, 2020
| @@ -1461,7 +1461,7 @@ fn assoc_ty_def( | |||
| // cycle error if the specialization graph is currently being built. | |||
| let impl_node = specialization_graph::Node::Impl(impl_def_id); | |||
| for item in impl_node.items(tcx) { | |||
| if item.kind == ty::AssocKind::Type | |||
| if matches!(item.kind, ty::AssocKind::Type | ty::AssocKind::OpaqueTy) | |||
There was a problem hiding this comment.
The fix looks correct to me, but now I"m wondering if the bug! below is reachable for opaque types if the impl is missing the associated opaque type item
|
📌 Commit 5e92625 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 12, 2020
…r=oli-obk Correctly check for opaque types in `assoc_ty_def` Closes rust-lang#67856
bors
added a commit
that referenced
this pull request
Jan 12, 2020
Rollup of 6 pull requests Successful merges: - #67494 (Constify more of alloc::Layout) - #67867 (Correctly check for opaque types in `assoc_ty_def`) - #67948 (Galloping search for binary_search_util) - #68045 (Move more of `rustc::lint` into `rustc_lint`) - #68089 (Unstabilize `Vec::remove_item`) - #68108 (Add suggestions when encountering chained comparisons) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67856