Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-expansion gate some more things #64672

Closed
wants to merge 1 commit into from
Closed

Pre-expansion gate some more things #64672

wants to merge 1 commit into from

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Sep 21, 2019 •
edited
Loading

Move feature gating of various unstable syntactic features to the parser.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2019
@Centril

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

Implementation looks good, but this needs a crater run, and then perhaps some soft feature-gating depending on its result.

@bors try

@bors
Copy link
Contributor

bors commented Sep 22, 2019

⌛ Trying commit 18a29c6c798488a64a81dac289c67636338742f3 with merge 00e4530a79c42b21a6ca2ac1edb597c90d21f89f...

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2019
@bors
Copy link
Contributor

bors commented Sep 22, 2019

☀️ Try build successful - checks-azure
Build commit: 00e4530a79c42b21a6ca2ac1edb597c90d21f89f

@Centril
Copy link
Contributor Author

Centril commented Sep 22, 2019

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-64672 created and queued.
🤖 Automatically detected try build 00e4530a79c42b21a6ca2ac1edb597c90d21f89f
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Centril Centril mentioned this pull request Sep 30, 2019
Merged
@craterbot
Copy link
Collaborator

🚧 Experiment pr-64672 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-64672 is completed!
📊 322 regressed and 0 fixed (74234 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 14, 2019
@petrochenkov
Copy link
Contributor

Marking as waiting on author to triage the regressions.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2019
@Centril
Copy link
Contributor Author

Centril commented Oct 16, 2019

crates.io

error[E0658]: try blocks are unstable

Number of crates regressed: 1

  • try-guard-0.2.0 (Centril's note: it is a test)

error[E0658]: auto traits are experimental and possibly buggy

Number of crates regressed: 17

  • airmash-protocol-0.3.0

  • bigqueue-0.0.2

  • dimensioned-0.7.0

  • doh-client-1.4.4

  • emseries-0.4.0

  • git_rs-0.1.0

  • lru-0.1.17

  • mft-0.4.4

  • nonogrid-0.5.2

  • rqrr-0.2.0

  • signalo_sinks-0.5.1

  • signalo_sources-0.5.1

  • sortuniq-0.1.0

  • tox-0.0.10

  • tox-node-0.0.8

  • webauthn-rs-0.1.4

  • xfetch-0.1.0

error[E0658]: extern types are experimental

Number of crates regressed: 98

  • angular-rs-0.1.0

  • awsm-0.0.11

  • awsm_web-0.0.6

  • azure_sdk_auth_aad-0.21.0

  • blockchain-network-simple-0.5.0

  • blurhash-wasm-0.2.0

  • breakout-wasm-0.2.2

  • cargo-geiger-0.7.3

  • cargo-tarpaulin-0.8.6

  • console-web-0.1.2

  • console_log-0.1.2

  • cratchit-0.0.4

  • document-ready-1.0.1

  • dodrio-0.1.0

  • dodrio-js-api-0.1.0

  • draco-0.1.2

  • electron-sys-0.1.0

  • futures_ringbuf-0.1.2

  • glium-0.26.0-alpha3

  • graphql_client_web-0.8.0

  • https-everywhere-lib-wasm-0.1.2

  • impulse-0.1.1

  • indexeddb-0.1.0

  • infuse-0.4.0

  • js-intern-0.3.1

  • js-intern-core-0.3.1

  • js-object-0.2.0

  • js-sys-0.3.27

  • libp2p-0.12.0

  • libp2p-wasm-ext-0.5.0

  • mech-wasm-0.0.2

  • medea-jason-0.1.0

  • meowj-0.2.0

  • mice-0.4.0

  • mika-0.0.0

  • mop-bindings-0.0.8

  • moxie-web-0.1.0

  • n5-wasm-0.1.0

  • node-sys-0.1.0

  • ojo_wasm-0.1.0

  • oxygengine-backend-web-0.4.4

  • oxygengine-composite-renderer-backend-web-0.4.4

  • oxygengine-input-device-web-0.4.4

  • oxygengine-network-backend-web-0.4.4

  • percy-webapis-0.0.2

  • piet-web-0.0.6

  • pir-8-emu-0.1.1

  • plaster-0.2.5

  • plaster-forms-0.1.16

  • plaster-router-0.1.5

  • plaster-router-macro-0.1.1

  • prototty_wasm-0.27.0

  • prototty_wasm_render-0.27.0

  • prototty_wasm_storage-0.27.0

  • qjs-0.1.2

  • quilt_wasm-0.1.1

  • router-rs-0.2.1

  • router-xiaobei-0.1.2

  • rusty_ulid-0.9.1

  • ruukh-0.0.3

  • saphir-0.9.4

  • sauron-native-0.1.0

  • seed-0.4.0

  • serde-wasm-bindgen-0.1.3

  • simi-0.2.1

  • simi-test-0.1.0

  • smd_macro-0.0.7

  • smd_tests-0.0.7

  • smithy-0.0.7

  • smithy_core-0.0.7

  • smithy_types-0.0.7

  • spherro-0.2.1

  • squark-web-0.3.0

  • ss-dom-tree-0.1.1

  • ss-trees-0.1.1

  • ss-view-tree-0.1.1

  • ss-web-utils-0.1.1

  • subscript-0.2.9

  • tera-1.0.0-beta.14

  • typed-array-0.2.0

  • virtual-dom-rs-0.6.10

  • virtual-node-0.2.6

  • vscode-sys-0.1.0

  • wasm-bindgen-0.2.50

  • wasm-bindgen-futures-0.3.27

  • wasm-bindgen-test-0.2.50

  • wasm-logger-0.1.5

  • wasm-stopwatch-0.1.0

  • web-console-logger-0.1.2

  • web-sys-0.3.27

  • web_worker-0.1.0

  • webblender-0.1.1

  • webgl-rs-0.2.2

  • ws_stream_wasm-0.2.1

  • wurst-0.2.0

  • yoloxide-0.4.3

  • yt-tools-0.3.0

  • zs-filecrawler-0.0.3

error[E0658]: negative trait bounds are not yet fully implemented; use marker types for now

Number of crates regressed: 30

  • airmash-protocol-0.3.0

  • beep-0.2.1

  • bigqueue-0.0.2

  • byteorder-pod-0.1.0

  • dimensioned-0.7.0

  • doh-client-1.4.4

  • emseries-0.4.0

  • futures-async-runtime-0.2.1

  • futures-async-runtime-preview-0.2.3

  • futures-v02x-0.1.0

  • git_rs-0.1.0

  • interprocess-traits-0.1.1

  • lru-0.1.17

  • lsm303-0.1.0

  • metric-0.1.2

  • mft-0.4.4

  • nonogrid-0.5.2

  • ocl-extras-0.1.1

  • ophir-0.2.5

  • packed-0.4.2

  • pod-0.5.0

  • rats-0.0.1

  • rqrr-0.2.0

  • signalo_sinks-0.5.1

  • signalo_sources-0.5.1

  • sortuniq-0.1.0

  • tox-0.0.10

  • tox-node-0.0.8

  • webauthn-rs-0.1.4

  • xfetch-0.1.0

error[E0658]: type ascription is experimental

Number of crates regressed: 5

  • anterofit-0.2.0 (Centril's note: seems to be in an example)

  • preftool-app-config-0.2.0

  • preftool-dirs-0.2.0 (Centril's note: this is the root regression)

  • preftool-file-0.2.0

  • preftool-toml-0.2.0

GitHub

error[E0658]: auto traits are experimental and possibly buggy

Number of crates regressed: 7

  • DpEpsilon-synthapse-rs

  • Lytigas-drive-sim

  • benfred-py-spy

  • droundy-gasbeam-paper

  • jonlamb-gh-elis-app

  • jonlamb-gh-rust-test-webapp

  • letmutx-dex-parser

error[E0658]: box expression syntax is experimental; you can call Box::new instead

Number of crates regressed: 1

  • westerhack-qutie_rust

error[E0658]: extern types are experimental

Number of crates regressed: 165

  • 367718-arisu

  • AvraamMavridis-rust-checkers

  • CL4PTP-dbapp

  • CallumJHays-wasm-bindgen-futures-test

  • ChrisWhealy-coin_sort_wasm2

  • ChrisWhealy-porous_absorber

  • Cosmian-gll-draw

  • DR-BoneZ-borker-rs

  • Grunzwanzling-genericspace

  • IOuser-rust-wasm

  • JordanJTW-RUST-8

  • JulianKniephoff-snek

  • LucianoBestia-fetchtest

  • LucianoBestia-mem1

  • LucianoBestia-mem2

  • LukasKalbertodt-psymagen

  • Madao-3-wasm-yaml

  • Mark-Simulacrum-async-fn-size

  • MaulingMonkey-rust_wasm_sample

  • Menschenkindlein-invaders

  • Michael-St-James-wasm-game-of-life

  • MoonL1ght-rust-wasm

  • NightStr-actix-calculator

  • Pauan-war-game

  • Pauan-wasm-pack-perf-test

  • QwantResearch-fafnir

  • ROki1988-ot-rs

  • Ragnaroek-libmaze

  • RainerBlessing-wasm_snake

  • Rauno56-watchman

  • SallySoul-ete

  • Schaeff-zokrates_wasm_resolver_playground

  • Schaeff-zokrates_web_prover

  • Siiiimon-eve-mirror

  • SolarOmni-RustyRogue

  • SpaceEraser-evolutionary_regression

  • SpiderOak-react-markdown-wasm

  • SpiderOak-react-wasm-bridge

  • TheOZoneBE-webgl-rs

  • ThomWright-kvs

  • ThomasdenH-pdf.js-wasm

  • TomasHubelbauer-rust-wasm

  • TradaTech-icetea-wasm

  • WAFFO-hello-wasm-webgl

  • Yuiki-bist

  • ZiCog-insane-british-anagram-rust

  • aep-carrier-custom-service-example

  • alexlapa-wasm-pack-698-reproduction

  • anderejd-electron-wasm-rust-example

  • anderejd-wasm-bindgen-minimal-example

  • anhmv-stats.rs

  • anlumo-webgl_rust_demo

  • ashtuchkin-rypt

  • augustocdias-rust-wasm-test

  • backwardspy-wasm-gol

  • baskerville-plato

  • brettcannon-python-launcher

  • bschwind-secret-santa

  • caelra-rust-wasm-demo

  • carols10cents-cargo-open

  • ceranco-life-rs

  • chengzibaba-GameOfLife

  • codeworm96-hikari

  • colbyn-view-prototype

  • craigmayhew-bigprimes.net-rust-wasm

  • craigmayhew-game-of-life

  • crome110-iiif-manga-viewer-frontend

  • davhogan-MyBuddy

  • dbrgn-airspace-visualizer

  • devetry-mustachers

  • dlgchg-wechat_rust

  • dsbrgg-rust-wasm

  • eduidl-tetris

  • eggmund-langtons_ant

  • emilk-hobogo

  • enricobn-slideshow

  • fasterthanlime-ziptest-rs

  • felipecsl-rusty-chess

  • felixzhuologist-wasm-chip8

  • finegeometer-cubic-curve

  • finegeometer-four-dimensions

  • fitzgen-dodrio-todomvc-wasm-instantiation

  • foldu-iv

  • gesterhuizen-sauron-onclick

  • gregtatum-wasm-canvas

  • h1romas4-rust-synth-emulation

  • h1romas4-wasm-canvas-bitblt

  • h3nnn4n-Rust-TypeScript-Wasm-Template

  • h3nnn4n-Strange-Attractor-Explorer

  • h3nnn4n-julia-dioxide

  • h3nnn4n-smart-panda

  • henrikvik-wasm_pong

  • hnefatl-rust-linked-lists

  • hnefatl-rust-particles

  • hughlang-fuzzy-sims

  • ibaryshnikov-rust-webgl-engine-boilerplate

  • ibaryshnikov-webgl-engine

  • ihakkitekin-rust-http-server

  • ilkomiliev-rust-game-impl

  • indutny-dumb-scrypt-wasm

  • jackharrhy-meowj

  • jawm-protolang

  • jcoglan-ray-tracer

  • jojolepro-specs_wasm

  • jptomanelli-rust-wasm-doom-fire

  • juneil-wasm-client-irc

  • kanekv-actix-async-await

  • krasnobaev-webasm-fmosc

  • laptou-yew-test

  • leegee-rust-ts-boilerplate

  • mateuszJS-battle

  • maxbla-unit-converter

  • miguelmota-rust-wasm-example

  • mizkichan-rust-canvas-example

  • mmmpa-wasm-loan-revolver

  • mtannerman-rust-server

  • nilinswap-snake_wasm

  • nishitaniyuki-wasm-hello-world

  • niveau0-ci-dashboard

  • nrayamajhee-moksha

  • nstoddard-ca-3d

  • nstoddard-webgl-gui-demo

  • pavelsavara-game-of-life

  • plaptov-ant_sim_rs

  • practical-rust-web-development-front_raw_mystore

  • pragyandas-particle-system-wasm

  • qvantor-fabric.rs

  • r-bar-seed-wasm-experiment

  • rajeevriitm-raincatcher_rust_game

  • rasviitanen-glust-kernel

  • rbalicki2-basic_futures

  • rbalicki2-rustactoe

  • rclement-life-wasm

  • richard-reece-md-toc

  • rikshot-testbed

  • rooat-front-rust

  • scampi-falcon

  • segler-alex-stream-check-rust

  • selaux-qrcode-wasm

  • sendilkumarn-draw-page

  • sendilkumarn-state-machine

  • skaggmannen-rusty-mines

  • sneakycrow-rust-api-example

  • synlestidae-webnes

  • szymonkaliski-behaviours-rs

  • tatref-chip8

  • theduke-wasm-debug-instantiate

  • threema-ch-compose-area

  • tismith-device-checkout-rs

  • tskinn-lot

  • twhiteheadzm-cube

  • txus-jam

  • ulip128-algo

  • utkarshkukreti-draco

  • utkarshkukreti-draco-starter

  • venil7-rust-minimax

  • verseatile-wasm-game-of-life

  • wakuwaku3-example-rust-wasm

  • wasmup-server-rs

  • wildthingz-game-of-life

  • wischli-rpaillier

  • xd009642-tarpaulin

  • xuu-wasm-tetris

  • yoshou-videocoreiv-sim

  • yshryk-igo-wasm-demo

error[E0658]: negative trait bounds are not yet fully implemented; use marker types for now

Number of crates regressed: 20

  • DpEpsilon-synthapse-rs

  • Jorch72-kristforge

  • Licenser-rust_ring

  • Lytigas-drive-sim

  • MeisterTea-malabar

  • NikosEfthias-rust-lessons-code

  • alanhoff-rust-example-actix

  • benfred-py-spy

  • droundy-gasbeam-paper

  • emkay-tiny-cache

  • jonlamb-gh-elis-app

  • jonlamb-gh-rust-test-webapp

  • jswrenn-beep

  • letmutx-dex-parser

  • lofim-actix-todo

  • nwoeanhinnogaehr-flow-synth

  • shockham-engine_arch

  • sourcepirate-pichu

  • tcsc-firkin

  • x1a0-bcproxy-rust

error[E0658]: type ascription is experimental

Number of crates regressed: 2

  • akky2501-Ruml

  • akky2501-mincaml-rust

@Centril
Copy link
Contributor Author

Centril commented Oct 16, 2019 •
edited
Loading

Notes:

  • The type ascription regressions in crates.io are really just 2, one of which is in an example and the rest have the same root regression and are part of the same project.

My suggestion is that we soft-gate (tho I'm not sure how to do it...) / wait with:

  • auto traits
  • negative trait impls
  • extern types

Everything else can be pre-expansion gated immediately (I will cherry-pick out a separate PR that does this.) and then we can consider the rest.

@Centril Centril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2019
@petrochenkov
Copy link
Contributor

I agree with the conclusions, waiting on the PR hard-gating everything except auto traits, negative impls and extern types.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2019
@Centril Centril mentioned this pull request Oct 23, 2019
Merged
@Centril Centril removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 23, 2019
@Centril Centril added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Oct 23, 2019
@Centril
Copy link
Contributor Author

Centril commented Oct 23, 2019

Filed #65742 for the subset; marking this as blocked on that.

Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
@Centril
Rollup merge of rust-lang#65742 - Centril:gate-pre-expansion-subset, …
d6a18b6 
…r=davidtwco

Pre-expansion gate most of the things

This is a subset of rust-lang#64672. A crater run has already been done and this PR implements conclusions according to rust-lang#64672 (comment).

r? @davidtwco
cc @petrochenkov
@bors

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor Author

Centril commented Oct 25, 2019

@petrochenkov Any ideas re. how we can soft-gate pre-expansion without losing hard-gate post-expansion? It seems to me we would somehow need to check & store if the spans arose from expansion during parsing to partition the two.

@Centril Centril changed the title Pre-expansion gate (almost) all the things Pre-expansion gate some more things Oct 25, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-10-25T09:12:18.9198146Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-25T09:12:18.9434835Z ##[command]git config gc.auto 0
2019-10-25T09:12:18.9505340Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-25T09:12:18.9562323Z ##[command]git config --get-all http.proxy
2019-10-25T09:12:18.9734539Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin  refs/heads/*:refs/remotes/origin/*  refs/pull/64672/merge:refs/remotes/pull/64672/merge
---
2019-10-25T10:11:29.7761723Z .................................................................................................... 1600/9249
2019-10-25T10:11:35.1844554Z .................................................................................................... 1700/9249
2019-10-25T10:11:47.5496701Z ........................................................i...............i........................... 1800/9249
2019-10-25T10:11:54.9015861Z .................................................................................................... 1900/9249
2019-10-25T10:12:09.3820145Z ..............................................iiiii................................................. 2000/9249
2019-10-25T10:12:19.9953662Z .................................................................................................... 2200/9249
2019-10-25T10:12:22.5311543Z .................................................................................................... 2300/9249
2019-10-25T10:12:26.3704456Z .................................................................................................... 2400/9249
2019-10-25T10:12:49.2817663Z .................................................................................................... 2500/9249
---
2019-10-25T10:15:38.3285185Z ..................................................i...............i................................. 4800/9249
2019-10-25T10:15:47.2801491Z .................................................................................................... 4900/9249
2019-10-25T10:15:55.7468382Z .................................................................................................... 5000/9249
2019-10-25T10:16:01.8495198Z .................................................................................................... 5100/9249
2019-10-25T10:16:12.0831627Z ...................................................ii.ii............................................ 5200/9249
2019-10-25T10:16:21.7593616Z .................................................................................................... 5400/9249
2019-10-25T10:16:30.9241065Z .................................................................................................... 5500/9249
2019-10-25T10:16:38.5474791Z ..................i................................................................................. 5600/9249
2019-10-25T10:16:43.9382397Z .................................................................................................... 5700/9249
2019-10-25T10:16:43.9382397Z .................................................................................................... 5700/9249
2019-10-25T10:16:55.8509790Z .................................................................................................... 5800/9249
2019-10-25T10:17:07.3340006Z ...............ii...i..ii...........i............................................................... 5900/9249
2019-10-25T10:17:28.7205452Z .................................................................................................... 6100/9249
2019-10-25T10:17:33.1485220Z .................................................................................................... 6200/9249
2019-10-25T10:17:33.1485220Z .................................................................................................... 6200/9249
2019-10-25T10:17:45.9862238Z ......................................i..ii......................................................... 6300/9249
2019-10-25T10:18:07.5083845Z .................................................................................................... 6500/9249
2019-10-25T10:18:09.6797304Z ....i............................................................................................... 6600/9249
2019-10-25T10:18:11.9257796Z ...............................................................................i.................... 6700/9249
2019-10-25T10:18:14.6009451Z .................................................................................................... 6800/9249
---
2019-10-25T10:22:17.3117978Z ---- [ui] ui/feature-gates/feature-gate-extern_types.rs stdout ----
2019-10-25T10:22:17.3118027Z 
2019-10-25T10:22:17.3118080Z error: ui test compiled successfully!
2019-10-25T10:22:17.3118127Z status: exit code: 0
2019-10-25T10:22:17.3119113Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/feature-gates/feature-gate-extern_types.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-extern_types" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-extern_types/auxiliary" "-A" "unused"
2019-10-25T10:22:17.3119519Z ------------------------------------------
2019-10-25T10:22:17.3119567Z 
2019-10-25T10:22:17.3119788Z ------------------------------------------
2019-10-25T10:22:17.3119852Z stderr:
---
2019-10-25T10:22:17.3120947Z 26 
2019-10-25T10:22:17.3120973Z 
2019-10-25T10:22:17.3120998Z 
2019-10-25T10:22:17.3121059Z The actual stderr differed from the expected stderr.
2019-10-25T10:22:17.3121398Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias/trait-alias-syntax-fail/trait-alias-syntax-fail.stderr
2019-10-25T10:22:17.3121674Z To update references, rerun the tests and pass the `--bless` flag
2019-10-25T10:22:17.3121960Z To only update this specific test, also pass `--test-args traits/trait-alias/trait-alias-syntax-fail.rs`
2019-10-25T10:22:17.3122041Z error: 1 errors occurred comparing output.
2019-10-25T10:22:17.3122110Z status: exit code: 1
2019-10-25T10:22:17.3122110Z status: exit code: 1
2019-10-25T10:22:17.3122866Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-alias/trait-alias-syntax-fail.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias/trait-alias-syntax-fail" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias/trait-alias-syntax-fail/auxiliary" "-A" "unused"
2019-10-25T10:22:17.3123345Z ------------------------------------------
2019-10-25T10:22:17.3123379Z 
2019-10-25T10:22:17.3123610Z ------------------------------------------
2019-10-25T10:22:17.3123654Z stderr:
2019-10-25T10:22:17.3123654Z stderr:
2019-10-25T10:22:17.3123862Z ------------------------------------------
2019-10-25T10:22:17.3123936Z error: trait aliases cannot be `auto`
2019-10-25T10:22:17.3124190Z   --> /checkout/src/test/ui/traits/trait-alias/trait-alias-syntax-fail.rs:4:1
2019-10-25T10:22:17.3124241Z    |
2019-10-25T10:22:17.3124308Z LL | auto trait A = Foo; //~ ERROR trait aliases cannot be `auto`
2019-10-25T10:22:17.3124360Z    | ^^^^^^^^^^^^^^^^^^^ trait aliases cannot be `auto`
2019-10-25T10:22:17.3124432Z error: trait aliases cannot be `unsafe`
2019-10-25T10:22:17.3124700Z   --> /checkout/src/test/ui/traits/trait-alias/trait-alias-syntax-fail.rs:5:1
2019-10-25T10:22:17.3124757Z    |
2019-10-25T10:22:17.3124757Z    |
2019-10-25T10:22:17.3124804Z LL | unsafe trait B = Foo; //~ ERROR trait aliases cannot be `unsafe`
2019-10-25T10:22:17.3124872Z    | ^^^^^^^^^^^^^^^^^^^^^ trait aliases cannot be `unsafe`
2019-10-25T10:22:17.3125180Z error: bounds are not allowed on trait aliases
2019-10-25T10:22:17.3125514Z   --> /checkout/src/test/ui/traits/trait-alias/trait-alias-syntax-fail.rs:7:8
2019-10-25T10:22:17.3125675Z    |
2019-10-25T10:22:17.3125675Z    |
2019-10-25T10:22:17.3125734Z LL | trait C: Ord = Eq; //~ ERROR bounds are not allowed on trait aliases
2019-10-25T10:22:17.3125824Z 
2019-10-25T10:22:17.3125867Z error: bounds are not allowed on trait aliases
2019-10-25T10:22:17.3126154Z   --> /checkout/src/test/ui/traits/trait-alias/trait-alias-syntax-fail.rs:8:8
2019-10-25T10:22:17.3126220Z    |
2019-10-25T10:22:17.3126220Z    |
2019-10-25T10:22:17.3126267Z LL | trait D: = Eq; //~ ERROR bounds are not allowed on trait aliases
2019-10-25T10:22:17.3126341Z 
2019-10-25T10:22:17.3126408Z error: aborting due to 4 previous errors
2019-10-25T10:22:17.3126437Z 
2019-10-25T10:22:17.3126462Z 
---
2019-10-25T10:22:17.3167557Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-25T10:22:17.3167637Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-25T10:22:17.3185445Z 
2019-10-25T10:22:17.3186286Z 
2019-10-25T10:22:17.3191108Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-25T10:22:17.3191625Z 
2019-10-25T10:22:17.3191659Z 
2019-10-25T10:22:17.3199069Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-25T10:22:17.3199144Z Build completed unsuccessfully in 1:03:31
2019-10-25T10:22:17.3199144Z Build completed unsuccessfully in 1:03:31
2019-10-25T10:22:17.3257306Z == clock drift check ==
2019-10-25T10:22:17.3279018Z   local time: Fri Oct 25 10:22:17 UTC 2019
2019-10-25T10:22:17.6174697Z   network time: Fri, 25 Oct 2019 10:22:17 GMT
2019-10-25T10:22:17.6174874Z == end clock drift check ==
2019-10-25T10:22:18.6617940Z 
2019-10-25T10:22:18.6732350Z ##[error]Bash exited with code '1'.
2019-10-25T10:22:18.6768552Z ##[section]Starting: Checkout
2019-10-25T10:22:18.6770322Z ==============================================================================
2019-10-25T10:22:18.6770379Z Task         : Get sources
2019-10-25T10:22:18.6770446Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril mentioned this pull request Oct 26, 2019
Closed
@bors
Copy link
Contributor

bors commented Oct 29, 2019

☔ The latest upstream changes (presumably #65907) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril Centril mentioned this pull request Oct 30, 2019
Open
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 16, 2019 •
edited
Loading

Even the subset change (#65742) was reverted (#66004), so I'll close this until some buy-in from other people is obtained.

@ehuss ehuss mentioned this pull request May 16, 2021
Open
This was referenced Jul 27, 2022
Closed
Merged
@est31 est31 mentioned this pull request Feb 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Centril @petrochenkov @bors @craterbot @rust-highfive