add -Z dont-buffer-diagnostics
#54232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
requested changes
Sep 14, 2018
src/librustc/ty/context.rs
Outdated
| /// Either immediate signals the given diagnostic, or puts it on the | ||
| /// given `buffer` for later signalling in the future. | ||
| pub fn buffer(self, mut diag: DiagnosticBuilder, buffer: &mut Vec<Diagnostic>) { | ||
| if self.sess.opts.debugging_opts.dont_buffer_diagnostics { |
There was a problem hiding this comment.
I believe this should check treat-err-as-bug and abort. And/or you could probably make this:
if self.sess.opts.debugging_opts.treat_err_as_bug || self.sess.opts.debugging_opts.dont_buffer_diagnostics {I've applied this patch myself numerous times.
There was a problem hiding this comment.
Oh, wait, no I haven't. I think this function is in the wrong place. This code can live in buffer() -- it has access to the Handler, which has the field flags (of type HandlerFlags) that contain flags relevant to it. We can just add this flag in there.
There was a problem hiding this comment.
Ok will do (probably on Monday)
| @@ -457,7 457,7 @@ impl<'a, 'gcx, 'tcx> MirBorrowckCtxt<'a, 'gcx, 'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| err.buffer(&mut self.errors_buffer); | |||
| self.tcx.buffer(err, &mut self.errors_buffer); | |||
There was a problem hiding this comment.
all these diffs aren't needed then
pnkfelix
force-pushed
the
add-way-to-disable-diagnostic-buffering
branch
from
d5d957d
to
d466964
Compare
pnkfelix
changed the title
-Z dont-buffer-diagnostics-Z dont-buffer-diagnostics
|
(this does not seem to yet work in the manner I intended.) Update: 🤕 while incorporating review feedback, I felt out crucial invocation of |
…t its diagnostics. This is mainly intended for `rustc` developers who want to see a diagnostic in its original context in the control flow. Two uses cases for that are: * `-Z treat-err-as-bug` which then allows extraction of a stack-trace to the origin of the error (a case that is so important that we make that flag imply this one, effectively). * `RUST_LOG=... rustc`, in which case it is often useful to see the logging statements that occurred immediately prior to the point where the diagnostic was signalled. Drive-by: Added some documentation pointing future devs at HandlerFlags, and documented the fields of `HandlerFlags` itself.
pnkfelix
force-pushed
the
add-way-to-disable-diagnostic-buffering
branch
from
d466964
to
82e1750
Compare
nikomatsakis
approved these changes
Sep 17, 2018
|
@bors r |
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove [WIP] from this PR's title when it is ready for review. |
|
@bors rollup |
nikomatsakis
changed the title
-Z dont-buffer-diagnostics-Z dont-buffer-diagnostics
|
@bors r rollup |
|
📌 Commit 82e1750 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 18, 2018
…tic-buffering, r=nikomatsakis add `-Z dont-buffer-diagnostics` Add `-Z dont-buffer-diagnostics`, a way to force NLL to immediately its diagnostics. This is mainly intended for developers who want to see the error in its original context in the control flow. Two uses cases for that are: 1. `-Z treat-err-as-bug` (which then allows extraction of a stack-trace to the origin of the error) 2. RUST_LOG=... rustc, in which case it is often useful to see the logging statements that occurred immediately prior to the point where the diagnostic was signalled.
bors
added a commit
that referenced
this pull request
Sep 18, 2018
Rollup of 9 pull requests Successful merges: - #53522 (Add doc for impl From for Addr) - #54097 (rustdoc: Remove namespace for keywords) - #54205 (Add treat-err-as-bug flag in rustdoc) - #54225 (Regression test for #53675.) - #54232 (add `-Z dont-buffer-diagnostics`) - #54273 (Suggest to change numeric literal instead of casting) - #54299 (Issue 54246) - #54311 (Remove README with now-out-of-date docs about docs.) - #54313 (OsStr: Document that it's not NUL terminated) Failed merges: r? @ghost
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Jan 7, 2024
It was added in rust-lang#54232. It seems like it was aimed at NLL development, which is well in the past. Also, it looks like `-Ztreat-err-as-bug` can be used to achieve the same effect. So it doesn't seem necessary.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 8, 2024
…stics, r=compiler-errors Remove `-Zdont-buffer-diagnostics`. It was added in rust-lang#54232. It seems like it was aimed at NLL development, which is well in the past. Also, it looks like `-Ztreat-err-as-bug` can be used to achieve the same effect. So it doesn't seem necessary. r? `@pnkfelix`
nnethercote
added a commit
to nnethercote/rust
that referenced
this pull request
Jan 8, 2024
It was added in rust-lang#54232. It seems like it was aimed at NLL development, which is well in the past. Also, it looks like `-Ztreat-err-as-bug` can be used to achieve the same effect. So it doesn't seem necessary.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 9, 2024
…stics, r=compiler-errors Remove `-Zdont-buffer-diagnostics`. It was added in rust-lang#54232. It seems like it was aimed at NLL development, which is well in the past. Also, it looks like `-Ztreat-err-as-bug` can be used to achieve the same effect. So it doesn't seem necessary. r? `@pnkfelix`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 9, 2024
…stics, r=compiler-errors Remove `-Zdont-buffer-diagnostics`. It was added in rust-lang#54232. It seems like it was aimed at NLL development, which is well in the past. Also, it looks like `-Ztreat-err-as-bug` can be used to achieve the same effect. So it doesn't seem necessary. r? ``@pnkfelix``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2024
Rollup merge of rust-lang#119723 - nnethercote:rm-Zdont-buffer-diagnostics, r=compiler-errors Remove `-Zdont-buffer-diagnostics`. It was added in rust-lang#54232. It seems like it was aimed at NLL development, which is well in the past. Also, it looks like `-Ztreat-err-as-bug` can be used to achieve the same effect. So it doesn't seem necessary. r? ``@pnkfelix``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-Z dont-buffer-diagnostics, a way to force NLL to immediately its diagnostics.This is mainly intended for developers who want to see the error in its original context in the control flow. Two uses cases for that are:
-Z treat-err-as-bug(which then allows extraction of a stack-trace to the origin of the error)RUST_LOG=... rustc, in which case it is often useful to see the logging statements that occurred immediately prior to the point where the diagnostic was signalled.