Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for full RELRO #43170

Merged
merged 5 commits into from
Jul 19, 2017
Merged

Add support for full RELRO #43170

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift click to select a range
2306687
Add support for full RELRO
kyrias Jul 10, 2017
94b9cc9
Support both partial and full RELRO
kyrias Jul 14, 2017
ecf3f6d
Make partial RELRO default on ppc64 due to segfault
kyrias Jul 14, 2017
6a8328c
Move relro_level from CodegenOptions to DebuggingOptions
kyrias Jul 17, 2017
2161fb2
Implement FromStr for RelroLevel rather than duplicating the match
kyrias Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make partial RELRO default on ppc64 due to segfault 
On at least RHEL6 there is a segfault caused by the older ld.so version
when BIND_NOW is used, so use partial RELRO by default on ppc64
architectures for now.

Signed-off-by: Johannes Löthberg <[email protected]>
  • Loading branch information
@kyrias
kyrias committed Jul 14, 2017
commit ecf3f6d4def2b2aa4b268ed50a7799ce40423bc0
6 changes: 5 additions & 1 deletion src/librustc_back/target/powerpc64_unknown_linux_gnu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 9,18 @@
// except according to those terms.

use LinkerFlavor;
use target::{Target, TargetResult};
use target::{Target, TargetResult, RelroLevel};

pub fn target() -> TargetResult {
let mut base = super::linux_base::opts();
base.cpu = "ppc64".to_string();
base.pre_link_args.get_mut(&LinkerFlavor::Gcc).unwrap().push("-m64".to_string());
base.max_atomic_width = Some(64);

// ld.so in at least RHEL6 on ppc64 has a bug related to BIND_NOW, so only enable partial RELRO
// for now. https://github.com/rust-lang/rust/pull/43170#issuecomment-315411474
base.relro_level = RelroLevel::Partial;

// see #36994
base.exe_allocation_crate = None;

Expand Down