core: Add priv::chan_from_global_ptr #2136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
Update GetSystemInfo to work with `page_size` (rust-lang#2136) - Change logic in GetSystemInfo shim to take into account the two possible layouts of `SYSTEM_INFO`, the first-field-is-union used by [winapi::um::sysinfoapi::SYSTEM_INFO](https://docs.rs/winapi/latest/winapi/um/sysinfoapi/struct.SYSTEM_INFO.html), and first-two-fields-are-inlined-union used by [num_cpus](https://github.com/seanmonstar/num_cpus/blob/5f1b03332000b4c4274b5bd35fac516049ff1c6b/src/lib.rs#L206). - Fill out the `dwPageSize` field with the `PAGE_SIZE` constant of `4096`. Closes rust-lang#2136
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jun 29, 2023
Dereference pointers in shims as correct types Currently, shims will dereference pointers as the type written by the user. This can cause false positives, incorrect behavior such as rust-lang#2136, and even ICEs if a field is not present. This PR fixes this by having shims dereference pointers with types from `std` or `libc` that we can rely on the layout and field names of instead of with whatever the user passed in. Fixes rust-lang#1123
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Update the RFC to capture the current state of the MIR linker and mark it as Stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows singleton, globally accessible tasks to be created, for the purpose of creating a global, default I/O loop.
It's a function that takes a pointer to a pointer-sized memory location, a task builder, and a task function, and returns a singleton channel to another task. It uses compare and swap.
For uv to use it we will have a single
uintptr_tfield onrust_kernelcalledglobal_io_chanto hold the handle.It's in the
privmod because I couldn't think of where else to put it. It is not intended to be a public API.