Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark f16 and f128 as incomplete features. #127743

Closed
wants to merge 2 commits into from
Closed

Mark f16 and f128 as incomplete features. #127743

wants to merge 2 commits into from

Conversation

tgross35
Copy link
Contributor

See #116909 (comment).

Unfortunately this will probably have a lot that needs to be updated, just getting this started to figure out exactly what that will be.

(moved from #127739, github didn't like my branch typo fix)

r? @scottmcm

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 15, 2024
@tgross35 tgross35 mentioned this pull request Jul 15, 2024
Closed
@tgross35 tgross35 changed the title F16 f128 incomplete feature Mark f16 and f128 as incomplete features. Jul 15, 2024
@tgross35
Copy link
Contributor Author

@rustbot label rla-silenced

@rustbot rustbot added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Jul 15, 2024
@tgross35
Copy link
Contributor Author

Maybe this isn't super useful if we can get #125016 over the line. That will fix the ABI and linking errors on iirc all but one tier1 platforms, I don't think missing library functions alone are enough to justify this change.

I'll just not prioritize this until at least seeing what happens once that merges (but if somebody wants to push it forward, feel free).

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Aug 21, 2024 •
edited
Loading

Marking the feature incomplete seems like more annoyance & churn than it is worth - the gate is already in > 150 places, across four different rust-lang repos, and there isn't a good solution to the fact that all incomplete features get enabled #127739 (comment). Because of this and because the situation is improving little by little (we can link on most platforms now, yay), I'm just going to close this PR.

@tgross35 tgross35 closed this Aug 21, 2024
@tgross35 tgross35 deleted the f16-f128-incomplete-feature branch August 21, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgross35 @scottmcm @rustbot