-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code of run-make/llvm-ident
#127237
Improve code of run-make/llvm-ident
#127237
Conversation
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! I think that we can base this on top of #126957 once it is merged (hopefully it should be close to being done).
…vm-ident-code, r=jieyouxu Improve run make llvm ident code I took the commits that are not blocking rust-lang#127237. r? `@Kobzol`
Rollup merge of rust-lang#127359 - GuillaumeGomez:improve-run-make-llvm-ident-code, r=jieyouxu Improve run make llvm ident code I took the commits that are not blocking rust-lang#127237. r? `@Kobzol`
☔ The latest upstream changes (presumably #127360) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot author (the pulled out PR merged) |
…code, r=jieyouxu Improve run make llvm ident code I took the commits that are not blocking rust-lang/rust#127237. r? `@Kobzol`
2e5959f
to
aa1c24a
Compare
Used the new function and removed the parts that were added in another PR. |
@rustbot ready |
@bors r rollup |
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#126427 (Rewrite `intrinsic-unreachable`, `sepcomp-cci-copies`, `sepcomp-inlining` and `sepcomp-separate` `run-make` tests to rmake.rs) - rust-lang#127237 (Improve code of `run-make/llvm-ident`) - rust-lang#127325 (Migrate `target-cpu-native`, `target-specs` and `target-without-atomic-cas` `run-make` tests to rmake) - rust-lang#127482 (Infer async closure signature from (old-style) two-part `Fn` `Future` bounds) Failed merges: - rust-lang#127357 (Remove `StructuredDiag`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#127237 - GuillaumeGomez:improve-run-make-llvm-ident, r=Kobzol Improve code of `run-make/llvm-ident` Follow-up of rust-lang#126941. r? `@Kobzol`
Follow-up of #126941.
r? @Kobzol