Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fuchsia commit, and SDK to 21.20240610.2.1 #126244

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Update fuchsia commit, and SDK to 21.20240610.2.1 #126244

merged 1 commit into from
Jun 14, 2024

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Jun 10, 2024 •
edited by Kobzol
Loading

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration

@rustbot
Copy link
Collaborator

rustbot commented Jun 10, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 10, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jun 11, 2024

@bors try

Let's try if it works :)

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2024
@bors
Auto merge of rust-lang#126244 - erickt:bump, r=<try>
1c5cc44 
Update fuchsia commit, and SDK to 21.20240610.2.1

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration
@bors
Copy link
Contributor

bors commented Jun 11, 2024

⌛ Trying commit 0ca41ba with merge 1c5cc44...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 11, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2024
@erickt
Copy link
Contributor Author

erickt commented Jun 11, 2024

Aw shucks, that should hopefully be fixed once we land http://fxrev.dev/1064520 in fuchsia. I'll update the PR once it lands.

@Kobzol
Copy link
Contributor

Kobzol commented Jun 12, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2024
@bors
Auto merge of rust-lang#126244 - erickt:bump, r=<try>
6765289 
Update fuchsia commit, and SDK to 21.20240610.2.1

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration
@bors
Copy link
Contributor

bors commented Jun 12, 2024

⌛ Trying commit c71e249 with merge 6765289...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 12, 2024

💔 Test failed - checks-actions

@Kobzol
Copy link
Contributor

Kobzol commented Jun 13, 2024

@bors try

@bors
Copy link
Contributor

bors commented Jun 13, 2024

⌛ Trying commit 4b3354e with merge c65181f...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2024
@bors
Auto merge of rust-lang#126244 - erickt:bump, r=<try>
c65181f 
Update fuchsia commit, and SDK to 21.20240610.2.1

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 13, 2024

💔 Test failed - checks-actions

@erickt
Copy link
Contributor Author

erickt commented Jun 13, 2024

Shucks, well getting closer though…

@erickt
Update fuchsia commit, and SDK to 21.20240610.2.1
14014ab 
This includes a fix to the race when publishing multiple packages at the
same time.
@Kobzol
Copy link
Contributor

Kobzol commented Jun 13, 2024

@bors try

@bors
Copy link
Contributor

bors commented Jun 13, 2024

⌛ Trying commit 14014ab with merge e15e1e3...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2024
@bors
Auto merge of rust-lang#126244 - erickt:bump, r=<try>
e15e1e3 
Update fuchsia commit, and SDK to 21.20240610.2.1

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
.......... (120/124)
...F       (124/124)


/checkout/tests/rustdoc-gui/help-page.goml help-page... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` line 16
    from `tests/rustdoc-gui/help-page.goml` line 23
    from `tests/rustdoc-gui/help-page.goml` line 32: Error: Evaluation failed: The following errors happened: [localStorage item "rustdoc-theme" (of value "ayu") != "null"]: for command `assert-local-storage: {"rustdoc-theme": |theme|}`
Error: ()
Build completed unsuccessfully in 0:03:30
  local time: Thu Jun 13 20:11:09 UTC 2024
  network time: Thu, 13 Jun 2024 20:11:09 GMT

@lqd
Copy link
Member

lqd commented Jun 13, 2024 •
edited
Loading

(cc #126430 on that last spurious PR CI failure)

@bors
Copy link
Contributor

bors commented Jun 13, 2024

☀️ Try build successful - checks-actions
Build commit: e15e1e3 (e15e1e3fe2e093d627cb4db481e5168f48518b5a)

@Kobzol
Copy link
Contributor

Kobzol commented Jun 13, 2024

Looks like it works now. Let me know if you want to modify something, or if I can merge it.

@erickt
Copy link
Contributor Author

erickt commented Jun 13, 2024

Looks good to merge, thanks!

@Kobzol
Copy link
Contributor

Kobzol commented Jun 13, 2024

@bors r rollup

@bors
Copy link
Contributor

bors commented Jun 13, 2024

📌 Commit 14014ab has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 14, 2024
@matthiaskrgr
Rollup merge of rust-lang#126244 - erickt:bump, r=Kobzol
158d2c1 
Update fuchsia commit, and SDK to 21.20240610.2.1

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 14, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2024
@bors
Auto merge of rust-lang#126458 - matthiaskrgr:rollup-g5mmyg8, r=matth…
19e365e 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates)
 - rust-lang#124884 (place explicit lifetime bound after generic param)
 - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1)
 - rust-lang#126270 (Migrate run make const fn mir)
 - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns)
 - rust-lang#126343 (Remove some msys2 utils)
 - rust-lang#126351 (std::unix::fs::link using direct linkat call for Solaris.)
 - rust-lang#126368 (Remove some unnecessary crate dependencies.)
 - rust-lang#126386 (Migrate `run-make/allow-non-lint-warnings-cmdline` to `rmake.rs`)
 - rust-lang#126449 (Fill out missing Windows support information)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2024
@bors
Auto merge of rust-lang#126462 - matthiaskrgr:rollup-g0t1am4, r=matth…
d2ad293 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123962 (change method resolution to constrain hidden types instead of rejecting method candidates)
 - rust-lang#126244 (Update fuchsia commit, and SDK to 21.20240610.2.1)
 - rust-lang#126270 (Migrate run make const fn mir)
 - rust-lang#126320 (Avoid ICES after reporting errors on erroneous patterns)
 - rust-lang#126449 (Fill out missing Windows support information)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e37fb61 into rust-lang:master Jun 14, 2024
5 of 7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 14, 2024
@rust-timer
Unrolled build for rust-lang#126244
94d40b2 
Rollup merge of rust-lang#126244 - erickt:bump, r=Kobzol

Update fuchsia commit, and SDK to 21.20240610.2.1

This includes a fix to the race when publishing multiple packages at the same time.

try-job: x86_64-gnu-integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
6 participants
@erickt @rustbot @Kobzol @bors @rust-log-analyzer @lqd