Generic associated consts: Check regions earlier when comparing impl with trait item def #123898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
T-compiler
|
r=me |
compiler-errors
approved these changes
Apr 13, 2024
fmease
commented
Apr 13, 2024
| @@ -1886,8 1886,6 @@ fn compare_type_predicate_entailment<'tcx>( | |||
| let impl_ty_predicates = tcx.predicates_of(impl_ty.def_id); | |||
| let trait_ty_predicates = tcx.predicates_of(trait_ty.def_id); | |||
|
|
|||
| check_region_bounds_on_impl_item(tcx, impl_ty, trait_ty, false)?; | |||
There was a problem hiding this comment.
There was no need to move this one out of compare_type_predicate_entailment except consistency with both compare_{method,const}_predicate_entailment which is reason enough imo.
fmease
commented
Apr 13, 2024
| @@ -1763,8 1764,6 @@ fn compare_const_predicate_entailment<'tcx>( | |||
| let impl_ct_predicates = tcx.predicates_of(impl_ct.def_id); | |||
| let trait_ct_predicates = tcx.predicates_of(trait_ct.def_id); | |||
|
|
|||
| check_region_bounds_on_impl_item(tcx, impl_ct, trait_ct, false)?; | |||
There was a problem hiding this comment.
On lifetime param mismatches, we ICE'd in tcx.type_of(trait_ct.def_id).instantiate(tcx, trait_to_impl_args) a few lines further up for obvious reasons. That's on me, I messed that up in the initial GCI PR.
fmease
changed the title
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 14, 2024
…, r=compiler-errors Generic associated consts: Check regions earlier when comparing impl with trait item def Fixes rust-lang#123836. r? compiler-errors or compiler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123651 (Thread local updates for idiomatic examples) - rust-lang#123699 (run-make-support: tidy up support library) - rust-lang#123779 (OpenBSD fix long socket addresses) - rust-lang#123803 (Fix `VecDeque::shrink_to` UB when `handle_alloc_error` unwinds.) - rust-lang#123875 (Doc: replace x with y for hexa-decimal fmt) - rust-lang#123879 (Add missing `unsafe` to some internal `std` functions) - rust-lang#123889 (reduce tidy overheads in run-make checks) - rust-lang#123898 (Generic associated consts: Check regions earlier when comparing impl with trait item def) - rust-lang#123902 (compiletest: Update rustfix to 0.8.1) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123651 (Thread local updates for idiomatic examples) - rust-lang#123699 (run-make-support: tidy up support library) - rust-lang#123779 (OpenBSD fix long socket addresses) - rust-lang#123875 (Doc: replace x with y for hexa-decimal fmt) - rust-lang#123879 (Add missing `unsafe` to some internal `std` functions) - rust-lang#123889 (reduce tidy overheads in run-make checks) - rust-lang#123898 (Generic associated consts: Check regions earlier when comparing impl with trait item def) - rust-lang#123902 (compiletest: Update rustfix to 0.8.1) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
Rollup merge of rust-lang#123898 - fmease:gci-cmp-impl-item-lt-params, r=compiler-errors Generic associated consts: Check regions earlier when comparing impl with trait item def Fixes rust-lang#123836. r? compiler-errors or compiler
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123836.
r? compiler-errors or compiler