Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the minimum external LLVM to 17 #122649

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Update the minimum external LLVM to 17 #122649

merged 2 commits into from
Mar 18, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 17, 2024 •
edited
Loading

With this change, we'll have stable support for LLVM 17 and 18.
For reference, the previous increase to LLVM 16 was #117947.

@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 17, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@cuviper
Copy link
Member Author

cuviper commented Mar 17, 2024

cc @rust-lang/wg-llvm @RalfJung -- I believe this will unblock #117329.

And with my distro hat on, we needed LLVM 16 for Fedora 38, but that will be EOL before 1.79 is released.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 17, 2024

I assume that all the LLVM version numbers in the description should be incremented by one? :)

@cuviper
Copy link
Member Author

cuviper commented Mar 17, 2024

I assume that all the LLVM version numbers in the description should be incremented by one? :)

D'oh! Fixed.

nikic
nikic reviewed Mar 17, 2024
View reviewed changes
src/ci/docker/host-x86_64/x86_64-gnu-llvm-18/Dockerfile
COPY host-x86_64/dist-x86_64-linux/shared.sh /scripts/
COPY host-x86_64/dist-x86_64-linux/build-gccjit.sh /scripts/

RUN /scripts/build-gccjit.sh /scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's syncing with changes that were made in 16 and 17, but not 18 yet -- I presume because they were developed around the same time 18 was added. But I think all of that is in question in #122546.

@RalfJung RalfJung mentioned this pull request Mar 17, 2024
Merged
@Kobzol
Copy link
Contributor

Kobzol commented Mar 17, 2024

CI (and other) changes look good to me 👍

@nikic
Copy link
Contributor

nikic commented Mar 18, 2024

@bors r

@bors
Copy link
Contributor

bors commented Mar 18, 2024

📌 Commit d9132de has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 18, 2024
@matthiaskrgr
Rollup merge of rust-lang#122649 - cuviper:min-llvm-17, r=nikic
414debe 
Update the minimum external LLVM to 17

With this change, we'll have stable support for LLVM 17 and 18.
For reference, the previous increase to LLVM 16 was rust-lang#117947.
This was referenced Mar 18, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2024
@bors
Auto merge of rust-lang#122690 - matthiaskrgr:rollup-43fggl0, r=matth…
d31b6fb 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#122480 (Avoid various uses of `Option<Span>` in favor of using `DUMMY_SP` in the few cases that used `None`)
 - rust-lang#122567 (Remove fixme about LLVM basic block naming)
 - rust-lang#122588 (less useless filter calls in imported_source_file)
 - rust-lang#122647 (add_retag: ensure box-to-raw-ptr casts are preserved for Miri)
 - rust-lang#122649 (Update the minimum external LLVM to 17)
 - rust-lang#122680 (Do not eat nested expressions' results in `MayContainYieldPoint` format args visitor)
 - rust-lang#122683 (add missing test: expected paren or brace in macro)
 - rust-lang#122689 (Add missing `try_visit` calls in visitors.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1ac0239 into rust-lang:master Mar 18, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2024
@rust-timer
Unrolled build for rust-lang#122649
c8ceff8 
Rollup merge of rust-lang#122649 - cuviper:min-llvm-17, r=nikic

Update the minimum external LLVM to 17

With this change, we'll have stable support for LLVM 17 and 18.
For reference, the previous increase to LLVM 16 was rust-lang#117947.
@cuviper cuviper added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 18, 2024
@klensy klensy mentioned this pull request Mar 19, 2024
Open
@cuviper cuviper deleted the min-llvm-17 branch April 11, 2024 16:05
@Nilstrieb Nilstrieb mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cuviper @rustbot @Kobzol @nikic @bors