Fix misaligned loads when loading UEFI arg pointers #122164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the two UEFI argument pointers are stored in an
alloca
of alignment 1, a pointer to which is then passed asargv
. However, the library code treatsargv
as a pointer to an array of pointers and dereferences it as such, meaning that it presumes thealloca
is aligned to at least the alignment of a pointer. This PR fixes this mismatch by aligning thealloca
to the alignment of a pointer.This PR also changed the
gep
to use the newinbounds_ptradd
method.