-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement {Div,Rem}Assign<NonZero<X>>
on X
#121952
Conversation
rustbot has assigned @workingjubilee. Use r? to explicitly pick a reviewer |
c3d7969
to
f0fc331
Compare
Since these are insta-stable, the ACP alone doesn't suffice, so starting an FCP: @rfcbot merge |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
r=me with the doc fixup. @bors delegate |
✌️ @JarvisCraft, you can now approve this pull request! If @workingjubilee told you to " |
☔ The latest upstream changes (presumably #121885) made this pull request unmergeable. Please resolve the merge conflicts. |
Signed-off-by: Petr Portnov <[email protected]>
These were only relevant for the unsafe-containing implementations Signed-off-by: Petr Portnov <[email protected]>
Thanks for your hint, I've updated the PR by echoing the comments and rebasing on |
feat: implement `{Div,Rem}Assign<NonZero<X>>` on `X` # Description This PR implements `DivAssign<X>` and `RemAssign<X>` on `X` as suggested in rust-lang/libs-team#346. Since this is just a trait implementation on an already stable type, for which non-assign operator traits are already stable, I suggest that it is an insta-stable feature.
💔 Test failed - checks-actions |
Seems spurious? @bors retry |
☀️ Test successful - checks-actions |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
Finished benchmarking commit (80e5694): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.349s -> 668.534s (0.03%) |
Description
This PR implements
DivAssign<X>
andRemAssign<X>
onX
as suggested in rust-lang/libs-team#346.Since this is just a trait implementation on an already stable type, for which non-assign operator traits are already stable, I suggest that it is an insta-stable feature.