Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide prebuilt std for gnullvm targets #121712

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Provide prebuilt std for gnullvm targets #121712

merged 1 commit into from
Apr 20, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Feb 27, 2024

Revival of #114346 which waiting on MCP that was accepted recently: rust-lang/compiler-team#710 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 27, 2024
@ehuss
Copy link
Contributor

ehuss commented Feb 28, 2024

I'm not sure who is best to review this.

r? infra-ci

@rustbot rustbot assigned Mark-Simulacrum and unassigned ehuss Feb 28, 2024
@mati865 mati865 mentioned this pull request Mar 6, 2024
Draft
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 9, 2024 •
edited
Loading

Why is this not updating the platform support docs to indicate this is now a tier 2 target (without host tools)?

I'm generally fine with landing this presuming the relevant approvals have been obtained. Building just std doesn't take that long so I'm not too worried about added CI time.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@mati865 mati865 force-pushed the provide-prebuilt-std-for-gnullvm branch from 280a431 to 14b18e9 Compare March 9, 2024 19:42
@mati865
Copy link
Contributor Author

mati865 commented Mar 9, 2024

Fixed.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2024
@Mark-Simulacrum
Copy link
Member

@bors r

@bors
Copy link
Contributor

bors commented Mar 16, 2024

📌 Commit 14b18e9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024
@Mark-Simulacrum
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2024
@mati865 mati865 force-pushed the provide-prebuilt-std-for-gnullvm branch from 14b18e9 to 2eba855 Compare March 18, 2024 21:05
@mati865
Copy link
Contributor Author

mati865 commented Mar 18, 2024

Sorry, I was under impression this table is generated from other files.
Updated it and grepped through the repository.

Also found out the machine where I had built Dockerfile had not fully rebased branch and with current master this fails to build.
Marking as blocked on rust-lang/compiler-builtins#575 which is blocked on #121552

@rustbot blocked

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jeremyd2019
Copy link
Contributor

jeremyd2019 commented Apr 10, 2024 •
edited
Loading

I created rust-lang/compiler-builtins#585 to better track this (as opposed to a comment on the PR)

A fix for this has now been merged, and it looks like they even released a new version of the compiler-builtins crate (0.1.109). There's a PR to update compiler_builtins in #123719

@mati865
Copy link
Contributor Author

mati865 commented Apr 10, 2024

Yeah, I already saw #123719 and I'm waiting for it to merge.

@mati865 mati865 force-pushed the provide-prebuilt-std-for-gnullvm branch from 46500e9 to c395176 Compare April 15, 2024 00:04
@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

@mati865 mati865 force-pushed the provide-prebuilt-std-for-gnullvm branch from c395176 to cd4c0da Compare April 15, 2024 00:10
@mati865
Copy link
Contributor Author

mati865 commented Apr 15, 2024

Rebased, updated the toolchain and tested locally using ./src/ci/docker/run.sh dist-various-1.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Apr 15, 2024
@jeremyd2019 jeremyd2019 mentioned this pull request Apr 17, 2024
Closed
3 tasks
@Mark-Simulacrum
Copy link
Member

@bors r rollup=never

@bors
Copy link
Contributor

bors commented Apr 20, 2024

📌 Commit cd4c0da has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2024
@bors
Copy link
Contributor

bors commented Apr 20, 2024

⌛ Testing commit cd4c0da with merge 8cf135e...

@bors
Copy link
Contributor

bors commented Apr 20, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8cf135e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 20, 2024
@bors bors merged commit 8cf135e into rust-lang:master Apr 20, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 20, 2024
@bors bors mentioned this pull request Apr 20, 2024
Open
@mati865 mati865 deleted the provide-prebuilt-std-for-gnullvm branch April 20, 2024 17:40
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8cf135e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.8% [0.8%, 0.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.4% [-4.4%, -4.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -4.4% [-4.4%, -4.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.07s -> 672.886s (0.12%)
Artifact size: 315.18 MiB -> 315.23 MiB (0.02%)

This was referenced Apr 20, 2024
Merged
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#124229 - mati865:add-gnullvm-targets-to-man…
a755d81 
…ifest, r=Mark-Simulacrum

Add gnullvm targets to manifest

Fixes an oversight from rust-lang#121712
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#124229 - mati865:add-gnullvm-targets-to-man…
7474773 
…ifest, r=Mark-Simulacrum

Add gnullvm targets to manifest

Fixes an oversight from rust-lang#121712
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#124229 - mati865:add-gnullvm-targets-to-man…
e96ed6d 
…ifest, r=Mark-Simulacrum

Add gnullvm targets to manifest

Fixes an oversight from rust-lang#121712
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2024
@rust-timer
Unrolled build for rust-lang#124229
c4b2d8b 
Rollup merge of rust-lang#124229 - mati865:add-gnullvm-targets-to-manifest, r=Mark-Simulacrum

Add gnullvm targets to manifest

Fixes an oversight from rust-lang#121712
@mati865 mati865 mentioned this pull request May 27, 2024
Merged
@filnet filnet mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mati865 @rustbot @ehuss @Mark-Simulacrum @bors @rust-log-analyzer @jeremyd2019 @rust-timer