Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various clippy fixes #121543

Merged
merged 5 commits into from
Mar 20, 2024
Merged

various clippy fixes #121543

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift click to select a range
ead18f4
reorder clippy rules to their original order before passing them
onur-ozkan Feb 24, 2024
b43dc06
add unit test: `order_of_clippy_rules`
onur-ozkan Feb 24, 2024
1945e8f
pass ignored lints after manual ones
onur-ozkan Feb 24, 2024
a61bf30
use `--cap-lints` only when deny and forbid rules are not specified
onur-ozkan Feb 24, 2024
81d7d7a
resolve clippy errors
onur-ozkan Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pass ignored lints after manual ones 
Previously, when passing lint rules manually using `x clippy ..`, ignored lints would
override manual ones. This change corrects the order by passing ignored lints after the
manual ones.

Signed-off-by: onur-ozkan <[email protected]>
  • Loading branch information
@onur-ozkan
onur-ozkan committed Mar 17, 2024
commit 1945e8f1f6e54dc53ace8cf2314ed76301ff51ee
2 changes: 1 addition & 1 deletion src/bootstrap/src/core/build_steps/check.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 64,8 @@ fn args(builder: &Builder<'_>) -> Vec<String> {
let all_args = std::env::args().collect::<Vec<_>>();

args.extend(strings(&["--", "--cap-lints", "warn"]));
args.extend(ignored_lints.iter().map(|lint| format!("-Aclippy::{}", lint)));
args.extend(get_clippy_rules_in_order(&all_args, allow, deny, warn, forbid));
args.extend(ignored_lints.iter().map(|lint| format!("-Aclippy::{}", lint)));
args.extend(builder.config.free_args.clone());
args
} else {
Expand Down