Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower transmutes from int to pointer type as gep on null #121282

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Feb 19, 2024

I thought of this while looking at #121242. See that PR's description for why this lowering is preferable.

The UI test that's being changed here crashes without changing the transmutes into casts. Based on that, this PR should not be merged without a crater build-and-test run.

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2024
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 19, 2024
@bors
Copy link
Contributor

bors commented Feb 19, 2024

⌛ Trying commit 903dd09 with merge d073071...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2024
…e, r=<try>

Lower transmutes from int to pointer type as gep on null

I thought of this while looking at rust-lang#121242

The UI test that's being changed here crashes without changing the transmutes into casts. Based on that, this PR should not be merged without a crater build-and-test run.
@bors
Copy link
Contributor

bors commented Feb 19, 2024

☀️ Try build successful - checks-actions
Build commit: d073071 (d073071d77ce0f93b4fd8cc567a1e2b9e1b22126)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d073071): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.2%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Bootstrap: 640.336s -> 641.418s (0.17%)
Artifact size: 308.82 MiB -> 308.83 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 19, 2024
@saethlin
Copy link
Member Author

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-121282 created and queued.
🤖 Automatically detected try build d073071
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2024
@saethlin saethlin added the T-opsem Relevant to the opsem team label Feb 19, 2024
@saethlin
Copy link
Member Author

@craterbot abort

@craterbot
Copy link
Collaborator

🗑️ Experiment pr-121282 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 20, 2024
@saethlin
Copy link
Member Author

@craterbot run mode=build-and-test start=master#61223975d46f794466efa832bc7562b9707ecc46 rustflags=-Copt-level=3 end=try#d073071d77ce0f93b4fd8cc567a1e2b9e1b22126 rustflags=-Copt-level=3

@craterbot
Copy link
Collaborator

👌 Experiment pr-121282 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2024
@@ -49,7 49,7 @@ pub fn ptr_to_int(p: *mut u16) -> usize {
}

// CHECK: define{{.*}}ptr @int_to_ptr([[USIZE]] %i)
// CHECK: %_0 = inttoptr [[USIZE]] %i to ptr
// CHECK: %_0 = getelementptr i8, ptr null, i64 %i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to make this pass on non-64-bit you need

Suggested change
// CHECK: %_0 = getelementptr i8, ptr null, i64 %i
// CHECK: %_0 = getelementptr i8, ptr null, [[USIZE]] %i

@craterbot
Copy link
Collaborator

🚧 Experiment pr-121282 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@bors
Copy link
Contributor

bors commented Mar 12, 2024

📌 Commit 2eb9c6d has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@bors
Copy link
Contributor

bors commented Mar 12, 2024

⌛ Testing commit 2eb9c6d with merge 0fa7fea...

@bors
Copy link
Contributor

bors commented Mar 12, 2024

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 0fa7fea to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2024
@bors bors merged commit 0fa7fea into rust-lang:master Mar 12, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0fa7fea): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-7.8% [-7.8%, -7.8%] 1
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.319s -> 672.448s (0.02%)
Artifact size: 310.04 MiB -> 310.05 MiB (0.00%)

@saethlin saethlin deleted the gep-null-means-no-provenance branch March 12, 2024 13:40
bors added a commit to rust-lang/crater that referenced this pull request Mar 18, 2024
Ignore some more crates

Adding all the spurious failures I identified in rust-lang/rust#121282 (comment)

I'm also not sure what `blacklist.md` is for, but it hasn't been updated in 6 years so I imagine it's not important.
bors added a commit to rust-lang/crater that referenced this pull request Mar 20, 2024
Ignore some more crates

Adding all the spurious failures I identified in rust-lang/rust#121282 (comment)

I'm also not sure what `blacklist.md` is for, but it hasn't been updated in 6 years so I imagine it's not important.
bors added a commit to rust-lang/crater that referenced this pull request Mar 20, 2024
Ignore some more crates

Adding all the spurious failures I identified in rust-lang/rust#121282 (comment)

I'm also not sure what `blacklist.md` is for, but it hasn't been updated in 6 years so I imagine it's not important.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2024
transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc `@saethlin` `@scottmcm`

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2024
transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc ``@saethlin`` ``@scottmcm``

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 24, 2024
transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc ```@saethlin``` ```@scottmcm```

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 24, 2024
transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc ````@saethlin```` ````@scottmcm````

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 24, 2024
transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc `````@saethlin````` `````@scottmcm`````

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2024
Rollup merge of rust-lang#122379 - RalfJung:int2ptr-transmute, r=m-ou-se

transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc ```@saethlin``` ```@scottmcm```

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024
transmute: caution against int2ptr transmutation

This came up in rust-lang#121282.
Cc ```@saethlin``` ```@scottmcm```

Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request May 4, 2024
Pkgsrc changes:
 * Adapt checksums and patches, some have beene intregrated upstream.

Upstream chnages:

Version 1.78.0 (2024-05-02)
===========================

Language
--------
- [Stabilize `#[cfg(target_abi = ...)]`]
  (rust-lang/rust#119590)
- [Stabilize the `#[diagnostic]` namespace and
  `#[diagnostic::on_unimplemented]` attribute]
  (rust-lang/rust#119888)
- [Make async-fn-in-trait implementable with concrete signatures]
  (rust-lang/rust#120103)
- [Make matching on NaN a hard error, and remove the rest of
  `illegal_floating_point_literal_pattern`]
  (rust-lang/rust#116284)
- [static mut: allow mutable reference to arbitrary types, not just
  slices and arrays]
  (rust-lang/rust#117614)
- [Extend `invalid_reference_casting` to include references casting
  to bigger memory layout]
  (rust-lang/rust#118983)
- [Add `non_contiguous_range_endpoints` lint for singleton gaps
  after exclusive ranges]
  (rust-lang/rust#118879)
- [Add `wasm_c_abi` lint for use of older wasm-bindgen versions]
  (rust-lang/rust#117918)
  This lint currently only works when using Cargo.
- [Update `indirect_structural_match` and `pointer_structural_match`
  lints to match RFC]
  (rust-lang/rust#120423)
- [Make non-`PartialEq`-typed consts as patterns a hard error]
  (rust-lang/rust#120805)
- [Split `refining_impl_trait` lint into `_reachable`, `_internal` variants]
  (rust-lang/rust#121720)
- [Remove unnecessary type inference when using associated types
  inside of higher ranked `where`-bounds]
  (rust-lang/rust#119849)
- [Weaken eager detection of cyclic types during type inference]
  (rust-lang/rust#119989)
- [`trait Trait: Auto {}`: allow upcasting from `dyn Trait` to `dyn Auto`]
  (rust-lang/rust#119338)

Compiler
--------

- [Made `INVALID_DOC_ATTRIBUTES` lint deny by default]
  (rust-lang/rust#111505)
- [Increase accuracy of redundant `use` checking]
  (rust-lang/rust#117772)
- [Suggest moving definition if non-found macro_rules! is defined later]
  (rust-lang/rust#121130)
- [Lower transmutes from int to pointer type as gep on null]
  (rust-lang/rust#121282)

Target changes:

- [Windows tier 1 targets now require at least Windows 10]
  (rust-lang/rust#115141)
 - [Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics in tier 1 Windows]
  (rust-lang/rust#120820)
- [Add `wasm32-wasip1` tier 2 (without host tools) target]
  (rust-lang/rust#120468)
- [Add `wasm32-wasip2` tier 3 target]
  (rust-lang/rust#119616)
- [Rename `wasm32-wasi-preview1-threads` to `wasm32-wasip1-threads`]
  (rust-lang/rust#122170)
- [Add `arm64ec-pc-windows-msvc` tier 3 target]
  (rust-lang/rust#119199)
- [Add `armv8r-none-eabihf` tier 3 target for the Cortex-R52]
  (rust-lang/rust#110482)
- [Add `loongarch64-unknown-linux-musl` tier 3 target]
  (rust-lang/rust#121832)

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries
---------

- [Bump Unicode to version 15.1.0, regenerate tables]
  (rust-lang/rust#120777)
- [Make align_offset, align_to well-behaved in all cases]
  (rust-lang/rust#121201)
- [PartialEq, PartialOrd: document expectations for transitive chains]
  (rust-lang/rust#115386)
- [Optimize away poison guards when std is built with panic=abort]
  (rust-lang/rust#100603)
- [Replace pthread `RwLock` with custom implementation]
  (rust-lang/rust#110211)
- [Implement unwind safety for Condvar on all platforms]
  (rust-lang/rust#121768)
- [Add ASCII fast-path for `char::is_grapheme_extended`]
  (rust-lang/rust#121138)

Stabilized APIs
---------------

- [`impl Read for &Stdin`]
  (https://doc.rust-lang.org/stable/std/io/struct.Stdin.html#impl-Read-for-&Stdin)
- [Accept non `'static` lifetimes for several `std::error::Error`
  related implementations] (rust-lang/rust#113833)
- [Make `impl<Fd: AsFd>` impl take `?Sized`]
  (rust-lang/rust#114655)
- [`impl From<TryReserveError> for io::Error`]
  (https://doc.rust-lang.org/stable/std/io/struct.Error.html#impl-From-for-Error)

These APIs are now stable in const contexts:

- [`Barrier::new()`]
  (https://doc.rust-lang.org/stable/std/sync/struct.Barrier.html#method.new)

Cargo
-----

- [Stabilize lockfile v4](rust-lang/cargo#12852)
- [Respect `rust-version` when generating lockfile]
  (rust-lang/cargo#12861)
- [Control `--charset` via auto-detecting config value]
  (rust-lang/cargo#13337)
- [Support `target.<triple>.rustdocflags` officially]
  (rust-lang/cargo#13197)
- [Stabilize global cache data tracking]
  (rust-lang/cargo#13492)

Misc
----

- [rustdoc: add `--test-builder-wrapper` arg to support wrappers
  such as RUSTC_WRAPPER when building doctests]
  (rust-lang/rust#114651)

Compatibility Notes
-------------------

- [Many unsafe precondition checks now run for user code with debug
  assertions enabled] (rust-lang/rust#120863)
  This change helps users catch undefined behavior in their code,
  though the details of how much is checked are generally not
  stable.
- [riscv only supports split_debuginfo=off for now]
  (rust-lang/rust#120518)
- [Consistently check bounds on hidden types of `impl Trait`]
  (rust-lang/rust#121679)
- [Change equality of higher ranked types to not rely on subtyping]
  (rust-lang/rust#118247)
- [When called, additionally check bounds on normalized function return type]
  (rust-lang/rust#118882)
- [Expand coverage for `arithmetic_overflow` lint]
  (rust-lang/rust#119432)

Internal Changes
----------------

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

- [Update to LLVM 18](rust-lang/rust#120055)
- [Build `rustc` with 1CGU on `x86_64-pc-windows-msvc`]
  (rust-lang/rust#112267)
- [Build `rustc` with 1CGU on `x86_64-apple-darwin`]
  (rust-lang/rust#112268)
- [Introduce `run-make` V2 infrastructure, a `run_make_support`
  library and port over 2 tests as example]
  (rust-lang/rust#113026)
- [Windows: Implement condvar, mutex and rwlock using futex]
  (rust-lang/rust#121956)
Liorst4 added a commit to Liorst4/liorforth that referenced this pull request May 24, 2024
…Cell`

Reduces the amount of `unsafe` in the code.

Looks like in newer rustc versions, this causes crashes.
Could be related to rust-lang/rust#121282
@Liorst4
Copy link

Liorst4 commented May 24, 2024

Is there a difference between casting an isize to a pointer using as and using std::mem::transmute?

@saethlin @scottmcm

When this change was proposed it crashed on one of my projects #121282 (comment)

@saethlin discussed this with me here: Liorst4/liorforth#1

The discussion didn't go very deep into the issue, and it left me kind of confused.
I assumed its a bug in the patch and @saethlin was going to fix it before pushing it into master.

Now when I run the test in release the test crashes.
To fix it, all I needed to do is change a std::mem::transmute cast into an as cast.
Liorst4/liorforth@fba984a
But I don't really understand why, shouldn't these be the same thing? Is there something I'm missing? Alignment issues?

Code that fails now

type Byte = u8;

type Cell = isize;

#[repr(packed(1))]
struct CountedString {
    len: Byte,
    data: [Byte; 0],
}

#[no_mangle]
fn test_breaks() {
    let buffer: [u8; 6] = [5, b'h', b'e', b'l', b'l', b'o'];
    let counted_string_address: Cell = (&buffer).as_ptr() as Cell;
    
    // Using `transmute` to cast
    let counted_string: &CountedString = unsafe {
        std::mem::transmute::<Cell, *const CountedString>(counted_string_address)
            .as_ref()
            .unwrap()
    };

    let counted_string_as_slice: &[u8] = unsafe {
        std::slice::from_raw_parts(counted_string.data.as_ptr(), counted_string.len as usize)
    };
    let counted_string_as_rust_string = std::str::from_utf8(counted_string_as_slice).unwrap();
    println!("{}", counted_string_as_rust_string);
}

#[no_mangle]
fn test_works() {
    let buffer: [u8; 6] = [5, b'h', b'e', b'l', b'l', b'o'];
    let counted_string_address: Cell = (&buffer).as_ptr() as Cell;
    
    // Using `as` to cast
    let counted_string: &CountedString = unsafe {
        (counted_string_address as *const CountedString)
            .as_ref()
            .unwrap()
    };

    let counted_string_as_slice: &[u8] = unsafe {
        std::slice::from_raw_parts(counted_string.data.as_ptr(), counted_string.len as usize)
    };
    let counted_string_as_rust_string = std::str::from_utf8(counted_string_as_slice).unwrap();
    println!("{}", counted_string_as_rust_string);
}

pub fn main() {
    test_works();
    test_breaks();
}

https://gcc.godbolt.org/z/b8ba9Y7G5

@saethlin
Copy link
Member Author

Yes there is a difference. To quote the RFC https://rust-lang.github.io/rfcs/3559-rust-has-provenance.html

Furthermore, the section on “Integer types” is extended to say that integers do not have provenance, and therefore transmuting (via transmute or type punning) from a pointer to an integer is a lossy operation and might even be UB. (The exact semantics of that operation involve some subtle trade-offs and are not decided by this RFC.)

as is a different operation from transmute for other types as well. Conversions between integers and floating point, for example.

@Liorst4
Copy link

Liorst4 commented May 24, 2024

Yes there is a difference. To quote the RFC https://rust-lang.github.io/rfcs/3559-rust-has-provenance.html

Furthermore, the section on “Integer types” is extended to say that integers do not have provenance, and therefore transmuting (via transmute or type punning) from a pointer to an integer is a lossy operation and might even be UB. (The exact semantics of that operation involve some subtle trade-offs and are not decided by this RFC.)

as is a different operation from transmute for other types as well. Conversions between integers and floating point, for example.

OK, thanks, this clears stuff up 👍

@scottmcm
Copy link
Member

scottmcm commented May 24, 2024

@Liorst4 Reminder that you can also confirm this using Miri. This PR changed only codegen, which doesn't affect Miri, but your test_breaks example also fails in Miri: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=46c3f8c80ae90b5fb22dd59023628e88

error: Undefined Behavior: out-of-bounds pointer use: 0x25d44[noalloc] is a dangling pointer (it has no provenance)
   --> /playground/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/const_ptr.rs:358:57
    |
358 |         if self.is_null() { None } else { unsafe { Some(&*self) } }
    |                                                         ^^^^^^ out-of-bounds pointer use: 0x25d44[noalloc] is a dangling pointer (it has no provenance)
    |
    = help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
    = help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information
    = note: BACKTRACE:
    = note: inside `std::ptr::const_ptr::<impl *const CountedString>::as_ref::<'_>` at /playground/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/const_ptr.rs:358:57: 358:63
note: inside `test_breaks`
   --> src/main.rs:18:9
    |
18  | /         std::mem::transmute::<Cell, *const CountedString>(counted_string_address)
19  | |             .as_ref()
    | |_____________________^
note: inside `main`
   --> src/main.rs:31:5
    |
31  |     test_breaks();
    |     ^^^^^^^^^^^^^

(Miri has diagnosed this for a long time; this PR just means that LLVM also knows about the UB.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-opsem Relevant to the opsem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet