-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For E0223, suggest associated functions that are similar to the path #120632
Conversation
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
if if let Some(ty_def_id) = qself_ty.ty_def_id() | ||
&& let Ok([inherent_impl]) = tcx.inherent_impls(ty_def_id) | ||
&& let Some(ty::AssocItem { kind: ty::AssocKind::Fn, .. }) = tcx | ||
.associated_items(inherent_impl) | ||
.filter_by_name_unhygienic(Symbol::intern(&name)) | ||
.next() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use something like the method resolution logic to find the method, even if it's hidden behind derefs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oli-obk I moved everything into a helper function and removed the |
Oh... yea, there's no good way to invoke that from here :/ I guess we'll miss out on some cases, but get the usual ones. @bors r rollup |
…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#120520 (Some cleanups around diagnostic levels.) - rust-lang#120575 (Simplify codegen diagnostic handling) - rust-lang#120597 (Suggest `[tail @ ..]` on `[..tail]` and `[...tail]` where `tail` is unresolved) - rust-lang#120602 (rustc_monomorphize: fix outdated comment in partition) - rust-lang#120609 (hir: Stop keeping prefixes for most of `use` list stems) - rust-lang#120631 (Emit a diagnostic for invalid target options) - rust-lang#120632 (For E0223, suggest associated functions that are similar to the path) - rust-lang#120670 (cleanup effect var handling) - rust-lang#120673 (rustc_metadata: fix typo) - rust-lang#120683 (miri: fix ICE with symbolic alignment check on extern static) - rust-lang#120690 (Remove b-naber from the compiler review rotation) - rust-lang#120713 (Make async closures test use async bound modifier) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#120632 - trevyn:issue-109195, r=oli-obk For E0223, suggest associated functions that are similar to the path e.g. for `String::from::utf8`, suggest `String::from_utf8` Closes rust-lang#109195
e.g. for
String::from::utf8
, suggestString::from_utf8
Closes #109195