-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #120417
Rollup of 6 pull requests #120417
Conversation
The feature does not seem to be required by this doctest.
last usages removed by rust-lang#116170
Co-authored-by: Michael Goulet <[email protected]>
When encountering an attribute in a body, we try to recover from an attribute on an expression (as opposed to a statement). We need to properly clean up when the attribute is at the end of the body where a tail expression would be. Fix rust-lang#118164.
Properly recover from trailing attr in body When encountering an attribute in a body, we try to recover from an attribute on an expression (as opposed to a statement). We need to properly clean up when the attribute is at the end of the body where a tail expression would be. Fix rust-lang#118164, fix rust-lang#118575.
…sDenton Remove feature not required by `Ipv6Addr::to_cononical` doctest The feature does not seem to be required by this doctest.
fix: correct suggestion arg for impl trait follow up rust-lang#118502, close rust-lang#119775
…ler-errors ScopeTree: remove destruction_scopes as unused last usages removed by rust-lang#116170 Unused, but still presented in memory at `t-gmax` (in DHAT termonology)
…piler-errors Improve handling of numbers in `IntoDiagnosticArg` While working on rust-lang#120393, I realize that my fluent selectors were not working. So here is an improvement (not a fix unfortunately).
…rieb Remove myself from review rotation Still willing to do reviews (and make it through my backlog), but I don't have the bandwidth to be on the rotation right now.
@bors r rollup=never p=6 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 8b6a431b3d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (7df6f4a): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 663.547s -> 660.284s (-0.49%) |
Successful merges:
Ipv6Addr::to_cononical
doctest #119641 (Remove feature not required byIpv6Addr::to_cononical
doctest)IntoDiagnosticArg
#120398 (Improve handling of numbers inIntoDiagnosticArg
)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup