Increase visibility of join_path and split_paths
#119748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
juntyr
reviewed
Jan 8, 2024
tgross35
force-pushed
the
suggest-path-split
branch
2 times, most recently
from
48eabf8
to
3e64f68
Compare
|
@rustbot label A-docs |
rustbot
added
the
A-docs
tgross35
force-pushed
the
suggest-path-split
branch
from
3e64f68
to
aca631f
Compare
benjamin-nw
reviewed
Jan 9, 2024
|
I have mixed feelings about the doc alias. If I'm a new user doing a search for "path" then I'm probably looking for path - see std::env::split_paths
|
|
r? libs-api |
rustbot
added
the
T-libs-api
|
@tgross35 This is fine, but the doc aliases should be removed. Searching for "path" should point users to the |
Amanieu
added
S-waiting-on-author
Add some crosslinking among `std::env` pages. Also add aliases to help anyone searching for `PATH`.
tgross35
force-pushed
the
suggest-path-split
branch
from
0de3677
to
dbb98e6
Compare
|
Slipped my mind, removed the aliases so this should be ready. (squashed the typo fix commit) @rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 29, 2024
…nieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
This was referenced Feb 29, 2024
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Feb 29, 2024
…nieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup of 11 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121130 (Suggest moving definition if non-found macro_rules! is defined later) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup of 10 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120291 (Have `String` use `SliceIndex` impls from `str`) - rust-lang#121723 (Two diagnostic things) - rust-lang#121740 (Changing some attributes to only_local.) - rust-lang#121745 (Deeply normalize obligations in `refining_impl_trait`) - rust-lang#121748 (Restore the standard library review rotation to its former glory) - rust-lang#121768 (Implement unwind safety for Condvar on all platforms ) - rust-lang#121777 (Fix typo in `rustc_passes/messages.ftl`) - rust-lang#121778 (Document potential memory leak in unbounded channel) - rust-lang#121779 (Remove unused diagnostic struct) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
Rollup merge of rust-lang#119748 - tgross35:suggest-path-split, r=Amanieu Increase visibility of `join_path` and `split_paths` Add some crosslinking among `std::env` pages to make it easier to discover `join_paths` and `split_paths`. Also add aliases to help anyone searching for `PATH`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#118217 (Document which methods on `f64` are precise) - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#121412 (platform docs: clarify hexagon-unknown-none-elf example, add hexagon-unknown-linux-musl) - rust-lang#121654 (Fix `async Fn` confirmation for `FnDef`/`FnPtr`/`Closure` types) - rust-lang#121700 (CFI: Don't compress user-defined builtin types) - rust-lang#121765 (add platform-specific function to get the error number for HermitOS) - rust-lang#121781 (bootstrap/format: send larger batches to rustfmt) - rust-lang#121788 (bootstrap: fix clap deprecated warnings) - rust-lang#121792 (Improve renaming suggestion when item starts with underscore) - rust-lang#121793 (Document which methods on `f32` are precise) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 29, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#119748 (Increase visibility of `join_path` and `split_paths`) - rust-lang#120820 (Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics (in nightly) in Windows x64) - rust-lang#121000 (pattern_analysis: rework how we hide empty private fields) - rust-lang#121376 (Skip unnecessary comparison with half-open range patterns) - rust-lang#121596 (Use volatile access instead of `#[used]` for `on_tls_callback`) - rust-lang#121669 (Count stashed errors again) - rust-lang#121783 (Emitter cleanups) r? `@ghost` `@rustbot` modify labels: rollup
|
It keeps getting skipped when I make rollups so just trying to see if bors somehow lost its state by re-approving it. @bors r=Amanieu rollup |
|
💡 This pull request was already approved, no need to approve it again.
|
|
Foiled again! Rollup completed and everything got merged but this |
|
Seems like it was merged tho? 06d4878 Not sure what's going on there. |
|
Ahhhh wtf Bors merged those two from before I force pushed, which is before this PR was approved. That's not right |
|
It seems bors r picked up a stale commit: #119748 (comment) Despite the force-push that was done here 25h before the r : #119748 (comment) |
|
Maybe make a new PR that fixes it to be what it should have been? You could also maybe try closing and reopening this PR but at this point I feel like maybe we should give it up as a lost cause 😔 |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Feb 29, 2024
Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).
|
I just made a new PR to fix this one up #121809, indeed not worth sorting this specific one out. Just spooky 💀 |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 29, 2024
… r=Amanieu Remove doc aliases to PATH Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2024
Rollup merge of rust-lang#121809 - tgross35:suggest-path-split-fixup, r=Amanieu Remove doc aliases to PATH Remove aliases for `split_paths` and `join_paths` as should have been done in <rust-lang#119748> (Bors merged the wrong commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some crosslinking among
std::envpages to make it easier to discoverjoin_pathsandsplit_paths. Also add aliases to help anyone searching forPATH.