Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exhaustiveness: Statically enforce revealing of opaques #119329

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Exhaustiveness: Statically enforce revealing of opaques #119329

merged 1 commit into from
Jan 6, 2024

Conversation

Nadrieril
Copy link
Member

In #116821 it was decided that exhaustiveness should operate on the hidden type of an opaque type when relevant. This PR makes sure we consistently reveal opaques within exhaustiveness. This makes it possible to remove reveal_opaque_ty from the TypeCx trait which was an unfortunate implementation detail.

r? @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 26, 2023
@Nadrieril
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 26, 2023
@bors
Copy link
Contributor

bors commented Dec 26, 2023

⌛ Trying commit cd5760e with merge f47f4cd...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2023
@bors
Auto merge of rust-lang#119329 - Nadrieril:reveal-opaques-early, r=<try>
f47f4cd 
Exhaustiveness: Statically enforce revealing of opaques

In rust-lang#116821 it was decided that exhaustiveness should operate on the hidden type of an opaque type when relevant. This PR makes sure we consistently reveal opaques within exhaustiveness. This makes it possible to remove `reveal_opaque_ty` from the `TypeCx` trait which was an unfortunate implementation detail.

r? `@compiler-errors`
@bors
Copy link
Contributor

bors commented Dec 27, 2023

☀️ Try build successful - checks-actions
Build commit: f47f4cd (f47f4cd076d44b91176cc2bb087a3a4298ead14e)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f47f4cd): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.9% [1.8%, 2.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.702s -> 672.275s (0.23%)
Artifact size: 312.43 MiB -> 312.39 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 27, 2023
@Nadrieril
Copy link
Member Author

Just good old match-stress being grumpy. Also I see no changes on cycles.

@Nadrieril Nadrieril added the perf-regression-triaged The performance regression has been triaged. label Dec 30, 2023
@compiler-errors
Copy link
Member

@bors r

@bors
Copy link
Contributor

bors commented Jan 4, 2024

📌 Commit c352720 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2024
@Nadrieril Nadrieril mentioned this pull request Jan 4, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2024
@bors
Auto merge of rust-lang#119581 - Nadrieril:detangle-arena, r=<try>
da5b704 
Exhaustiveness: remove the need for arena-allocation within the algorithm

WARNING: skip the first commit, it's from rust-lang#119329 which is getting merged.

This nicely cleans up the lifetime story: after this PR, all the `&'p DeconstructedPat` ever handled in the algorithm are coming from user input; we never build one ourselves.

r? `@compiler-errors`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2024
@bors
Auto merge of rust-lang#119329 - Nadrieril:reveal-opaques-early, r=co…
132c5bb 
…mpiler-errors

Exhaustiveness: Statically enforce revealing of opaques

In rust-lang#116821 it was decided that exhaustiveness should operate on the hidden type of an opaque type when relevant. This PR makes sure we consistently reveal opaques within exhaustiveness. This makes it possible to remove `reveal_opaque_ty` from the `TypeCx` trait which was an unfortunate implementation detail.

r? `@compiler-errors`
@bors
Copy link
Contributor

bors commented Jan 5, 2024

⌛ Testing commit c352720 with merge 132c5bb...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
   Compiling cranelift-object v0.103.0
[RUSTC-TIMING] cranelift_module test:false 1.174
[RUSTC-TIMING] cranelift_frontend test:false 1.863
[RUSTC-TIMING] cranelift_object test:false 1.696
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Sat Jan  6 00:02:06 UTC 2024
  local time: Sat Jan  6 00:02:06 UTC 2024
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

@bors
Copy link
Contributor

bors commented Jan 6, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2024
@Nadrieril
Copy link
Member Author

I don't understand what cancelled the check. Let's retry?

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2024
@bors
Copy link
Contributor

bors commented Jan 6, 2024

⌛ Testing commit c352720 with merge 5bcd86d...

@bors
Copy link
Contributor

bors commented Jan 6, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5bcd86d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2024
@bors bors merged commit 5bcd86d into rust-lang:master Jan 6, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 6, 2024
@bors bors mentioned this pull request Jan 6, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5bcd86d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.9% [1.7%, 2.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.2% [-1.3%, -1.1%] 3
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.481s -> 668.285s (-0.03%)
Artifact size: 311.14 MiB -> 311.06 MiB (-0.02%)

@Nadrieril Nadrieril deleted the reveal-opaques-early branch January 6, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Nadrieril @rust-timer @bors @compiler-errors @rust-log-analyzer @rustbot