Add triagebot mentions entry for simd intrinsics #119123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
|
For portable-simd I only added the people already in the mentions entry for portable-simd under the assumption that the rest doesn't want to get notified. Please tell me if you want to be mentioned anyway. |
GuillaumeGomez
approved these changes
Dec 19, 2023
triagebot.toml
Outdated
| [mentions."library/core/src/intrinsics/simd.rs"] | ||
| message = """ | ||
| Some changes occurred to the platform-builtins intrinsics. Make sure all | ||
| codegen backends as well as portable-simd get adapted for the changes. |
There was a problem hiding this comment.
maybe phrase this so people creating PRs aren't under the impression that they have to update every backend by themselves? iirc gcc and cranelift aren't supposed to block PRs...
There was a problem hiding this comment.
Yeah, I think we should update the text here, or make a T-compiler decision if we do want to block PRs. My guess is that we're not ready to block on making the backends work yet.
Mark-Simulacrum
added
S-waiting-on-author
|
sounds good |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2024
…llaumeGomez Rollup of 18 pull requests Successful merges: - rust-lang#119123 (Add triagebot mentions entry for simd intrinsics) - rust-lang#119991 (Reject infinitely-sized reads from io::Repeat) - rust-lang#120172 (bootstrap: add more unit tests) - rust-lang#120250 (rustdoc: Prevent JS injection from localStorage) - rust-lang#120376 (Update codegen test for LLVM 18) - rust-lang#120387 (interpret/memory: fix safety comment for large array memset optimization) - rust-lang#120400 (Bound errors span label cleanup) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120403 (Add instructions of how to use pre-vendored 'rustc-src') - rust-lang#120424 (raw pointer metadata API: data address -> data pointer) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120439 (Move UI issue tests to subdirectories) - rust-lang#120443 (Fixes footnote handling in rustdoc) - rust-lang#120452 (std: Update documentation of seek_write on Windows) - rust-lang#120460 (Be more careful about interpreting a label/lifetime as a mistyped char literal.) - rust-lang#120464 (Add matthewjasper to some review groups) - rust-lang#120467 (Update books) - rust-lang#120488 (Diagnostic lifetimes cleanups) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2024
Rollup merge of rust-lang#119123 - bjorn3:simd_intrinsics_mentions, r=Nilstrieb Add triagebot mentions entry for simd intrinsics Fixes rust-lang#119119 cc `@antoyo,` `@GuillaumeGomez,` `@rust-lang/project-portable-simd`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119119
cc @antoyo, @GuillaumeGomez, @rust-lang/project-portable-simd