Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate overaligned MIR constants for codegen. #119056

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Tolerate overaligned MIR constants for codegen. #119056

merged 2 commits into from
Dec 21, 2023

Conversation

cjgillot
Copy link
Contributor

Fixes #117761

cc @saethlin

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 17, 2023
@wesleywiser
Copy link
Member

@bors r

@bors
Copy link
Contributor

bors commented Dec 20, 2023

📌 Commit 503af0d has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2023
@bors
Copy link
Contributor

bors commented Dec 21, 2023

⌛ Testing commit 503af0d with merge 920e005...

@bors
Copy link
Contributor

bors commented Dec 21, 2023

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 920e005 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2023
@bors bors merged commit 920e005 into rust-lang:master Dec 21, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (920e005): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.3% [4.3%, 4.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.469s -> 673.95s (0.07%)
Artifact size: 312.82 MiB -> 312.81 MiB (-0.00%)

@cjgillot cjgillot deleted the codegen-overalign branch December 21, 2023 10:17
@durin42 durin42 mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saethlin saethlin saethlin left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

Enabling GVN produces a const allocation with the wrong alignment?
6 participants
@cjgillot @rustbot @wesleywiser @bors @rust-timer @saethlin