Check normalized call signature for WF in mir typeck #118882

compiler-errors · 2023-12-12T16:44:07Z

Unfortunately we don't check that the built-in implementations for Fn* traits are actually well-formed in the same way that we do for user-provided impls.

Essentially, when checking a call terminator, we end up with a signature that references an unnormalized <[closure] as FnOnce<...>>::Output in its output. That output type, due to the built-in impl, doesn't follow the expected rule that WF(ty) implies WF(normalized(ty)). We fix this by also checking the normalized signature here.

See boxy's detailed and useful explanation comment which explains this in more detail: #114936 (comment)

Fixes #114936
Fixes #118876

r? types
cc @BoxyUwU @lcnr

lcnr · 2023-12-13T07:31:45Z

compiler/rustc_borrowck/src/type_check/mod.rs

+ // HACK(#114936): `WF(sig)` does not imply `WF(normalized(sig))`
+ // with built-in `Fn` implementations, since the impl may not be
+ // well-formed itself.
+ self.prove_predicates(


nit: do we want to only emit those in case normalization actually changed the arg/ret ty

lcnr · 2023-12-13T07:33:02Z

r=me after crater and types FCP

@bors try

bors · 2023-12-13T07:34:14Z

⌛ Trying commit dd748cb with merge 8bdbfd4...

…=<try> Check normalized call signature for WF in mir typeck Unfortunately we don't check that the built-in implementations for `Fn*` traits are actually well-formed in the same way that we do for user-provided impls. Essentially, when checking a call terminator, we end up with a signature that references an unnormalized `<[closure] as FnOnce<...>>::Output` in its output. That output type, due to the built-in impl, doesn't follow the expected rule that `WF(ty)` implies `WF(normalized(ty))`. We fix this by also checking the normalized signature here. **See** boxy's detailed and useful explanation comment which explains this in more detail: rust-lang#114936 (comment) Fixes rust-lang#114936 Fixes rust-lang#118876 r? types cc `@BoxyUwU` `@lcnr`

bors · 2023-12-13T09:01:09Z

☀️ Try build successful - checks-actions
Build commit: 8bdbfd4 (8bdbfd41bed26c4938a9f14bd20556eac1de8437)

lcnr · 2023-12-13T10:06:27Z

@craterbot check

lcnr · 2023-12-13T10:24:25Z

@craterbot ping

compiler-errors · 2023-12-13T18:55:07Z

@craterbot check

craterbot · 2023-12-13T18:55:09Z

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

compiler-errors · 2023-12-13T18:56:23Z

@craterbot check start=master#27d8a577138c0d319a572cd1a464c2b755e577de end=try#8bdbfd41bed26c4938a9f14bd20556eac1de8437

craterbot · 2023-12-13T18:56:29Z

👌 Experiment pr-118882 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-12-18T22:56:56Z

🚧 Experiment pr-118882 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-12-20T18:54:18Z

🎉 Experiment pr-118882 is completed!
📊 54 regressed and 3 fixed (399389 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

compiler-errors · 2024-01-01T19:26:25Z

Regression:

use std::iter::FromIterator;

struct Foo;

impl<'a, U: Clone> FromIterator<&'a U> for Foo {
    fn from_iter<T: IntoIterator<Item = &'a U>>(iter: T) -> Self { 
        for x in iter {}

        Foo
     }
}

fn main() {}

error[E0309]: the parameter type `U` may not live long enough
 --> /home/gh-compiler-errors/test.rs:7:18
  |
5 | impl<'a, U: Clone> FromIterator<&'a U> for Foo {
  |      -- the parameter type `U` must be valid for the lifetime `'a` as defined here...
6 |     fn from_iter<T: IntoIterator<Item = &'a U>>(iter: T) -> Self { 
7 |         for x in iter {}
  |                  ^^^^ ...so that the type `U` will meet its required lifetime bounds
  |
help: consider adding an explicit lifetime bound
  |
5 | impl<'a, U: Clone   'a> FromIterator<&'a U> for Foo {
  |

aliemjay · 2024-01-01T19:29:02Z

Regression:

fixed by #104098?

compiler-errors · 2024-01-01T19:30:27Z

@aliemjay: Yes it looks clear that the PR would fix it!

lcnr · 2024-01-10T12:27:53Z

marking as blocked on #104098 then

rfcbot · 2024-02-01T19:44:13Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2024-02-11T19:49:04Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

lcnr · 2024-02-12T10:01:47Z

r=me after fixing CI

compiler-errors · 2024-02-13T16:28:11Z

@bors r=lcnr

bors · 2024-02-13T16:28:14Z

📌 Commit 2b4a2b9 has been approved by lcnr

It is now in the queue for this repository.

… r=lcnr Check normalized call signature for WF in mir typeck Unfortunately we don't check that the built-in implementations for `Fn*` traits are actually well-formed in the same way that we do for user-provided impls. Essentially, when checking a call terminator, we end up with a signature that references an unnormalized `<[closure] as FnOnce<...>>::Output` in its output. That output type, due to the built-in impl, doesn't follow the expected rule that `WF(ty)` implies `WF(normalized(ty))`. We fix this by also checking the normalized signature here. **See** boxy's detailed and useful explanation comment which explains this in more detail: rust-lang#114936 (comment) Fixes rust-lang#114936 Fixes rust-lang#118876 r? types cc `@BoxyUwU` `@lcnr`

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118882 (Check normalized call signature for WF in mir typeck) - rust-lang#120999 (rustdoc: replace `clean::InstantiationParam` with `clean::GenericArg`) - rust-lang#121002 (remove unnecessary calls to `commit_if_ok`) - rust-lang#121005 (Remove jsha from the rustdoc review rotation) - rust-lang#121043 (add lcnr to the compiler-team assignment group) - rust-lang#121045 (Fix two UI tests with incorrect directive / invalid revision) - rust-lang#121046 (Fix incorrect use of `compile_fail`) - rust-lang#121047 (Do not assemble candidates for default impls) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118882 (Check normalized call signature for WF in mir typeck) - rust-lang#120999 (rustdoc: replace `clean::InstantiationParam` with `clean::GenericArg`) - rust-lang#121002 (remove unnecessary calls to `commit_if_ok`) - rust-lang#121005 (Remove jsha from the rustdoc review rotation) - rust-lang#121014 (Remove `force_print_diagnostic`) - rust-lang#121043 (add lcnr to the compiler-team assignment group) - rust-lang#121046 (Fix incorrect use of `compile_fail`) - rust-lang#121047 (Do not assemble candidates for default impls) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118882 - compiler-errors:normalized-sig-wf, r=lcnr Check normalized call signature for WF in mir typeck Unfortunately we don't check that the built-in implementations for `Fn*` traits are actually well-formed in the same way that we do for user-provided impls. Essentially, when checking a call terminator, we end up with a signature that references an unnormalized `<[closure] as FnOnce<...>>::Output` in its output. That output type, due to the built-in impl, doesn't follow the expected rule that `WF(ty)` implies `WF(normalized(ty))`. We fix this by also checking the normalized signature here. **See** boxy's detailed and useful explanation comment which explains this in more detail: rust-lang#114936 (comment) Fixes rust-lang#114936 Fixes rust-lang#118876 r? types cc ``@BoxyUwU`` ``@lcnr``

Pkgsrc changes: * Adapt checksums and patches, some have beene intregrated upstream. Upstream chnages: Version 1.78.0 (2024-05-02) =========================== Language -------- - [Stabilize `#[cfg(target_abi = ...)]`] (rust-lang/rust#119590) - [Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute] (rust-lang/rust#119888) - [Make async-fn-in-trait implementable with concrete signatures] (rust-lang/rust#120103) - [Make matching on NaN a hard error, and remove the rest of `illegal_floating_point_literal_pattern`] (rust-lang/rust#116284) - [static mut: allow mutable reference to arbitrary types, not just slices and arrays] (rust-lang/rust#117614) - [Extend `invalid_reference_casting` to include references casting to bigger memory layout] (rust-lang/rust#118983) - [Add `non_contiguous_range_endpoints` lint for singleton gaps after exclusive ranges] (rust-lang/rust#118879) - [Add `wasm_c_abi` lint for use of older wasm-bindgen versions] (rust-lang/rust#117918) This lint currently only works when using Cargo. - [Update `indirect_structural_match` and `pointer_structural_match` lints to match RFC] (rust-lang/rust#120423) - [Make non-`PartialEq`-typed consts as patterns a hard error] (rust-lang/rust#120805) - [Split `refining_impl_trait` lint into `_reachable`, `_internal` variants] (rust-lang/rust#121720) - [Remove unnecessary type inference when using associated types inside of higher ranked `where`-bounds] (rust-lang/rust#119849) - [Weaken eager detection of cyclic types during type inference] (rust-lang/rust#119989) - [`trait Trait: Auto {}`: allow upcasting from `dyn Trait` to `dyn Auto`] (rust-lang/rust#119338) Compiler -------- - [Made `INVALID_DOC_ATTRIBUTES` lint deny by default] (rust-lang/rust#111505) - [Increase accuracy of redundant `use` checking] (rust-lang/rust#117772) - [Suggest moving definition if non-found macro_rules! is defined later] (rust-lang/rust#121130) - [Lower transmutes from int to pointer type as gep on null] (rust-lang/rust#121282) Target changes: - [Windows tier 1 targets now require at least Windows 10] (rust-lang/rust#115141) - [Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics in tier 1 Windows] (rust-lang/rust#120820) - [Add `wasm32-wasip1` tier 2 (without host tools) target] (rust-lang/rust#120468) - [Add `wasm32-wasip2` tier 3 target] (rust-lang/rust#119616) - [Rename `wasm32-wasi-preview1-threads` to `wasm32-wasip1-threads`] (rust-lang/rust#122170) - [Add `arm64ec-pc-windows-msvc` tier 3 target] (rust-lang/rust#119199) - [Add `armv8r-none-eabihf` tier 3 target for the Cortex-R52] (rust-lang/rust#110482) - [Add `loongarch64-unknown-linux-musl` tier 3 target] (rust-lang/rust#121832) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Bump Unicode to version 15.1.0, regenerate tables] (rust-lang/rust#120777) - [Make align_offset, align_to well-behaved in all cases] (rust-lang/rust#121201) - [PartialEq, PartialOrd: document expectations for transitive chains] (rust-lang/rust#115386) - [Optimize away poison guards when std is built with panic=abort] (rust-lang/rust#100603) - [Replace pthread `RwLock` with custom implementation] (rust-lang/rust#110211) - [Implement unwind safety for Condvar on all platforms] (rust-lang/rust#121768) - [Add ASCII fast-path for `char::is_grapheme_extended`] (rust-lang/rust#121138) Stabilized APIs --------------- - [`impl Read for &Stdin`] (https://doc.rust-lang.org/stable/std/io/struct.Stdin.html#impl-Read-for-&Stdin) - [Accept non `'static` lifetimes for several `std::error::Error` related implementations] (rust-lang/rust#113833) - [Make `impl<Fd: AsFd>` impl take `?Sized`] (rust-lang/rust#114655) - [`impl From<TryReserveError> for io::Error`] (https://doc.rust-lang.org/stable/std/io/struct.Error.html#impl-From-for-Error) These APIs are now stable in const contexts: - [`Barrier::new()`] (https://doc.rust-lang.org/stable/std/sync/struct.Barrier.html#method.new) Cargo ----- - [Stabilize lockfile v4](rust-lang/cargo#12852) - [Respect `rust-version` when generating lockfile] (rust-lang/cargo#12861) - [Control `--charset` via auto-detecting config value] (rust-lang/cargo#13337) - [Support `target.<triple>.rustdocflags` officially] (rust-lang/cargo#13197) - [Stabilize global cache data tracking] (rust-lang/cargo#13492) Misc ---- - [rustdoc: add `--test-builder-wrapper` arg to support wrappers such as RUSTC_WRAPPER when building doctests] (rust-lang/rust#114651) Compatibility Notes ------------------- - [Many unsafe precondition checks now run for user code with debug assertions enabled] (rust-lang/rust#120863) This change helps users catch undefined behavior in their code, though the details of how much is checked are generally not stable. - [riscv only supports split_debuginfo=off for now] (rust-lang/rust#120518) - [Consistently check bounds on hidden types of `impl Trait`] (rust-lang/rust#121679) - [Change equality of higher ranked types to not rely on subtyping] (rust-lang/rust#118247) - [When called, additionally check bounds on normalized function return type] (rust-lang/rust#118882) - [Expand coverage for `arithmetic_overflow` lint] (rust-lang/rust#119432) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Update to LLVM 18](rust-lang/rust#120055) - [Build `rustc` with 1CGU on `x86_64-pc-windows-msvc`] (rust-lang/rust#112267) - [Build `rustc` with 1CGU on `x86_64-apple-darwin`] (rust-lang/rust#112268) - [Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example] (rust-lang/rust#113026) - [Windows: Implement condvar, mutex and rwlock using futex] (rust-lang/rust#121956)

alexcrichton · 2024-05-10T19:38:32Z

I've opened #124984 which cargo bisect-rustc points to this PR as the cause of the regression so wanted to flag it here as well.

rustbot assigned lcnr Dec 12, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2023

compiler-errors mentioned this pull request Dec 12, 2023

&'a T → &'static T in safe code #118876

Closed

estebank approved these changes Dec 13, 2023

View reviewed changes

lcnr reviewed Dec 13, 2023

View reviewed changes

lcnr added T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2023

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2023

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 20, 2023

lcnr added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2024

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 1, 2024

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 1, 2024

Check normalized call signature for WF in mir typeck

2b4a2b9

rust-cloud-vms bot force-pushed the normalized-sig-wf branch from 5bce1c4 to 2b4a2b9 Compare February 13, 2024 16:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2024

matthiaskrgr mentioned this pull request Feb 13, 2024

Rollup of 8 pull requests #121054

Closed

matthiaskrgr mentioned this pull request Feb 13, 2024

Rollup of 8 pull requests #121055

Merged

bors merged commit db9591c into rust-lang:master Feb 14, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Feb 14, 2024

apiraino removed the to-announce Announce this issue on triage meeting label Feb 15, 2024

compiler-errors mentioned this pull request Mar 29, 2024

Explicit lifetime required on scoped value #123195

Closed

compiler-errors deleted the normalized-sig-wf branch March 29, 2024 15:23

alexcrichton mentioned this pull request May 10, 2024

Regression in required trait bounds in Rust 1.78.0 #124984

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check normalized call signature for WF in mir typeck #118882

Check normalized call signature for WF in mir typeck #118882

compiler-errors commented Dec 12, 2023

lcnr Dec 13, 2023

lcnr commented Dec 13, 2023 •

edited

Loading

bors commented Dec 13, 2023

bors commented Dec 13, 2023

lcnr commented Dec 13, 2023

lcnr commented Dec 13, 2023

compiler-errors commented Dec 13, 2023

craterbot commented Dec 13, 2023

compiler-errors commented Dec 13, 2023

craterbot commented Dec 13, 2023

craterbot commented Dec 18, 2023

craterbot commented Dec 20, 2023

compiler-errors commented Jan 1, 2024

aliemjay commented Jan 1, 2024

compiler-errors commented Jan 1, 2024

lcnr commented Jan 10, 2024

rfcbot commented Feb 1, 2024

rfcbot commented Feb 11, 2024

lcnr commented Feb 12, 2024

compiler-errors commented Feb 13, 2024

bors commented Feb 13, 2024

alexcrichton commented May 10, 2024

Check normalized call signature for WF in mir typeck #118882

Check normalized call signature for WF in mir typeck #118882

Conversation

compiler-errors commented Dec 12, 2023

lcnr Dec 13, 2023

Choose a reason for hiding this comment

lcnr commented Dec 13, 2023 • edited Loading

bors commented Dec 13, 2023

bors commented Dec 13, 2023

lcnr commented Dec 13, 2023

lcnr commented Dec 13, 2023

compiler-errors commented Dec 13, 2023

craterbot commented Dec 13, 2023

compiler-errors commented Dec 13, 2023

craterbot commented Dec 13, 2023

craterbot commented Dec 18, 2023

craterbot commented Dec 20, 2023

compiler-errors commented Jan 1, 2024

aliemjay commented Jan 1, 2024

compiler-errors commented Jan 1, 2024

lcnr commented Jan 10, 2024

rfcbot commented Feb 1, 2024

rfcbot commented Feb 11, 2024

lcnr commented Feb 12, 2024

compiler-errors commented Feb 13, 2024

bors commented Feb 13, 2024

alexcrichton commented May 10, 2024

lcnr commented Dec 13, 2023 •

edited

Loading