Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to LLVM 17.0.5 #117907

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Update to LLVM 17.0.5 #117907

merged 1 commit into from
Nov 14, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Nov 14, 2023

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2023
@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2023
@nikic
Copy link
Contributor Author

nikic commented Nov 14, 2023

Mips is tier 3, but it probably still makes sense to backport this, as the target is currently completely broken.

(The nomination is for the next beta, not the upcoming stable.)

@cuviper
Copy link
Member

cuviper commented Nov 14, 2023

It seems you included your own Nov 3 commit of "[GlobalOpt] Cache whether CC is changeable", before it landed on main on Nov 7 and was backported to 17.x on Nov 14 (today). Not a big deal, since the commits were identical and so the merge was clean -- just noting the difference in commit history.

@cuviper
Copy link
Member

cuviper commented Nov 14, 2023

@bors r rollup=never

@bors
Copy link
Contributor

bors commented Nov 14, 2023

📌 Commit 8e2fcc4 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2023
@nikic
Copy link
Contributor Author

nikic commented Nov 14, 2023

It seems you included your own Nov 3 commit of "[GlobalOpt] Cache whether CC is changeable", before it landed on main on Nov 7 and was backported to 17.x on Nov 14 (today). Not a big deal, since the commits were identical and so the merge was clean -- just noting the difference in commit history.

Ooops, I forgot to reset my branch before merging.

@klensy
Copy link
Contributor

klensy commented Nov 14, 2023

Maybe bump here too?

rust/src/ci/docker/host-x86_64/dist-x86_64-linux/build-clang.sh

Line 7 in d97bb19

LLVM=llvmorg-17.0.4

@bors
Copy link
Contributor

bors commented Nov 14, 2023

⌛ Testing commit 8e2fcc4 with merge 2fef4be...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2023
@bors
Auto merge of rust-lang#117907 - nikic:update-llvm-17, r=cuviper
2fef4be 
Update to LLVM 17.0.5

Fixes rust-lang#116177.
Fixes the compile-time issue reported at https://internals.rust-lang.org/t/significant-increase-in-fat-lto-time-post-update-to-rustc-1-75-0-nightly/19765.

r? `@cuviper`
@cuviper
Copy link
Member

cuviper commented Nov 14, 2023

@klensy that update can be done separately, and I think doesn't need beta backport.

@klensy
Copy link
Contributor

klensy commented Nov 14, 2023

Oh, beta, ok.

@bors
Copy link
Contributor

bors commented Nov 14, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 14, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@cuviper
Copy link
Member

cuviper commented Nov 14, 2023

@bors retry (network failure)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2023
@bors
Copy link
Contributor

bors commented Nov 14, 2023

⌛ Testing commit 8e2fcc4 with merge dd430bc...

@bors
Copy link
Contributor

bors commented Nov 14, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing dd430bc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 14, 2023
@bors bors merged commit dd430bc into rust-lang:master Nov 14, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 14, 2023
@tatsuya6502 tatsuya6502 mentioned this pull request Nov 14, 2023
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dd430bc): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.9% [-2.9%, -2.9%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% [-3.1%, -2.2%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.6% [-3.1%, -2.2%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.687s -> 674.834s (0.17%)
Artifact size: 311.12 MiB -> 311.10 MiB (-0.01%)

@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 19, 2023
@cuviper cuviper mentioned this pull request Nov 27, 2023
Merged
@cuviper cuviper modified the milestones: 1.76.0, 1.75.0 Nov 27, 2023
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 27, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2023
@bors
Auto merge of rust-lang#118390 - cuviper:beta-next, r=cuviper
bd45872 
[beta] backports

- feat: implement `DoubleEndedSearcher` for `CharArray[Ref]Searcher` rust-lang#111922
- Update to LLVM 17.0.5 rust-lang#117907
- clarify `fn discriminant` guarantees: only free lifetimes may get erased rust-lang#118006

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.

64 bit shift is broken in nightly build for MIPS
8 participants
@nikic @rustbot @cuviper @bors @klensy @rust-log-analyzer @rust-timer @apiraino