Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow reference to static mut and adding static_mut_ref lint #117556

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Disallow reference to static mut and adding static_mut_ref lint #117556

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift click to select a range
2c088f9
Disallow reference to `static mut` for expressions
obeis Dec 22, 2023
70ba4d1
Disallow reference to `static mut` for statements
obeis Dec 22, 2023
a82fd2b
Call `maybe_expr_static_mut` inside `resolve_expr`
obeis Dec 22, 2023
e36f7b7
Call `maybe_stmt_static_mut` inside `resolve_stmt`
obeis Dec 22, 2023
18edf9a
Add test for `E0796` and `static_mut_ref` lint
obeis Dec 22, 2023
a8aa687
Update test for `E0796` and `static_mut_ref` lint
obeis Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Call maybe_expr_static_mut inside resolve_expr
  • Loading branch information
@obeis
obeis committed Jan 6, 2024
commit a82fd2bc7cf15b8aa9ffbd7752999a3bc9cb8cea
4 changes: 4 additions & 0 deletions compiler/rustc_hir_analysis/src/check/region.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 18,8 @@ use rustc_middle::ty::TyCtxt;
use rustc_span::source_map;
use rustc_span::Span;

use super::errs::maybe_expr_static_mut;

use std::mem;

#[derive(Debug, Copy, Clone)]
Expand Down Expand Up @@ -242,6 244,8 @@ fn resolve_stmt<'tcx>(visitor: &mut RegionResolutionVisitor<'tcx>, stmt: &'tcx h
fn resolve_expr<'tcx>(visitor: &mut RegionResolutionVisitor<'tcx>, expr: &'tcx hir::Expr<'tcx>) {
debug!("resolve_expr - pre-increment {} expr = {:?}", visitor.expr_and_pat_count, expr);

maybe_expr_static_mut(visitor.tcx, *expr);

let prev_cx = visitor.cx;
visitor.enter_node_scope_with_dtor(expr.hir_id.local_id);

Expand Down