Some diagnostics improvements of `gen` blocks #117389

oli-obk · 2023-10-30T10:25:13Z

These are leftovers from #116447

rustbot · 2023-10-30T10:25:21Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-10-30T14:23:00Z

r? compiler-errors @bors r rollup

bors · 2023-10-30T14:23:04Z

📌 Commit bc926f7 has been approved by compiler-errors

It is now in the queue for this repository.

Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#117317 (share some track_caller logic between interpret and codegen) - rust-lang#117357 (Rename a few remaining references to abort terminator) - rust-lang#117383 (improve and fix `x install`) - rust-lang#117389 (Some diagnostics improvements of `gen` blocks) - rust-lang#117390 (Fix unused variables lint issue for args in macro) - rust-lang#117395 (Fix missing leading space in suggestion) - rust-lang#117396 (Don't treat closures/coroutine types as part of the public API) r? `@ghost` `@rustbot` modify labels: rollup

Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

oli-obk · 2023-10-30T16:02:12Z

@bors r-

oli-obk · 2023-10-30T16:16:59Z

@bors r=compiler-errors

bors · 2023-10-30T16:17:01Z

📌 Commit ac9c5bd has been approved by compiler-errors

It is now in the queue for this repository.

Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

oli-obk · 2023-10-30T16:27:24Z

@bors r-

oli-obk · 2023-10-30T16:33:03Z

@bors r=compiler-errors

bors · 2023-10-30T16:33:06Z

📌 Commit 224ddf8 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116862 (Detect when trait is implemented for type and suggest importing it) - rust-lang#117389 (Some diagnostics improvements of `gen` blocks) - rust-lang#117396 (Don't treat closures/coroutine types as part of the public API) - rust-lang#117398 (Correctly handle nested or-patterns in exhaustiveness) - rust-lang#117403 (Poison check_well_formed if method receivers are invalid to prevent typeck from running on it) - rust-lang#117411 (Improve some diagnostics around `?Trait` bounds) - rust-lang#117414 (Don't normalize to an un-revealed opaque when we hit the recursion limit) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117389 - oli-obk:gen_fn, r=compiler-errors Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

oli-obk added 2 commits October 30, 2023 10:13

Talk about gen fn in diagnostics about gen fn

745c600

Add a custom panic message for resuming gen blocks after they panicked

bc926f7

rustbot assigned b-naber Oct 30, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2023

rustbot assigned compiler-errors and unassigned b-naber Oct 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 30, 2023

Rollup merge of rust-lang#117389 - oli-obk:gen_fn, r=compiler-errors

399aae3

Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

matthiaskrgr mentioned this pull request Oct 30, 2023

Rollup of 7 pull requests #117400

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 30, 2023

Rollup merge of rust-lang#117389 - oli-obk:gen_fn, r=compiler-errors

309bf69

Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

matthiaskrgr mentioned this pull request Oct 30, 2023

Rollup of 7 pull requests #117402

Closed

oli-obk mentioned this pull request Oct 30, 2023

Don't treat closures/coroutine types as part of the public API #117396

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2023

This comment has been minimized.

Sign in to view

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 30, 2023

Rollup merge of rust-lang#117389 - oli-obk:gen_fn, r=compiler-errors

284e95f

Some diagnostics improvements of `gen` blocks These are leftovers from rust-lang#116447

GuillaumeGomez mentioned this pull request Oct 30, 2023

Rollup of 12 pull requests #117404

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 30, 2023

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 30, 2023

Only run panic tests on targets that can unwind

224ddf8

oli-obk force-pushed the gen_fn branch from ac9c5bd to 224ddf8 Compare October 30, 2023 16:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2023

matthiaskrgr mentioned this pull request Oct 30, 2023

Rollup of 7 pull requests #117415

Merged

bors merged commit 86259e7 into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some diagnostics improvements of `gen` blocks #117389

Some diagnostics improvements of `gen` blocks #117389

oli-obk commented Oct 30, 2023

rustbot commented Oct 30, 2023

compiler-errors commented Oct 30, 2023

bors commented Oct 30, 2023

oli-obk commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

This comment has been minimized.

oli-obk commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

Some diagnostics improvements of gen blocks #117389

Some diagnostics improvements of gen blocks #117389

Conversation

oli-obk commented Oct 30, 2023

rustbot commented Oct 30, 2023

compiler-errors commented Oct 30, 2023

bors commented Oct 30, 2023

oli-obk commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

This comment has been minimized.

oli-obk commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

Some diagnostics improvements of `gen` blocks #117389

Some diagnostics improvements of `gen` blocks #117389