Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for i586-unknown-netbsd as target. #117170

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Add support for i586-unknown-netbsd as target. #117170

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift click to select a range
6642b4b
Add support for i586-unknown-netbsd as target.
he32 Oct 25, 2023
391b472
rustc_llvm/build.rs: improve comment for NetBSD/i386 targets
he32 Oct 26, 2023
893e726
i586_unknown_netbsd.rs: fix formatting.
he32 Oct 27, 2023
0f04e2d
For i586/NetBSD: fix another formatting insistence.
he32 Oct 27, 2023
a510288
i586_unknown_netbsd.rs: drop "-m32" flag insertion to gcc.
he32 Oct 28, 2023
d9ddad3
i586-unknown-netbsd: add entry in platform-support.md.
he32 Oct 28, 2023
f5fa36f
i586-unknown-netbsd platform-support.md: fix typo.
he32 Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rustc_llvm/build.rs: improve comment for NetBSD/i386 targets 
...explaining why we need -latomic (gcc & g   built for i486,
and LLVM insisting on use of 64-bit atomics).
  • Loading branch information
@he32
he32 committed Oct 26, 2023
commit 391b472a370a5d35c43bd0a26182076cf0c17ca9
4 changes: 3 additions & 1 deletion compiler/rustc_llvm/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 258,9 @@ fn main() {
{
println!("cargo:rustc-link-lib=z");
} else if target.contains("netbsd") {
// Building for i586 or i686, we need -latomic for 64-bit atomics
// On NetBSD/i386, gcc and g is built for i486 (to maximize backward compat)
// However, LLVM insists on using 64-bit atomics.
// This gives rise to a need to link rust itself with -latomic for these targets
if target.starts_with("i586")
|| target.starts_with("i686")
{
Expand Down
Loading