Skip test if Unix sockets are unsupported #116989

ChrisDenton · 2023-10-20T17:28:08Z

The test will be skipped if AF_UNIX is not supported. In that case WSASocketW returns WSAEAFNOSUPPORT.

It will never skip the test when run in CI but maybe this is me being too defensive since the error code is narrowly scoped to just the af family parameter being unsupported?

Also fixed a minor typo.

r? @Mark-Simulacrum

the8472 · 2023-10-21T10:49:20Z

It will never skip the test when run in CI but maybe this is me being too defensive

Imo it's fine, we already have a bunch of checks like this in other places. If some 3rd party ever wants to support legacy windows builds and build CI infrastructure for that they can open an issue and then we can think about that.
Afaik nobody has stepped up doing something like that for windows 7 for example.

Mark-Simulacrum · 2023-10-21T18:13:42Z

@bors r

bors · 2023-10-21T18:13:44Z

📌 Commit 46f68cc has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#116985 (Use gdb.ValuePrinter tag class) - rust-lang#116989 (Skip test if Unix sockets are unsupported) - rust-lang#117034 (Don't crash on empty match in the `nonexhaustive_omitted_patterns` lint) - rust-lang#117037 (rustdoc book doc example error) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116989 - ChrisDenton:skip-unsupported, r=Mark-Simulacrum Skip test if Unix sockets are unsupported Fixes rust-lang#116683 (comment) The test will be skipped if `AF_UNIX` is not supported. In that case [`WSASocketW` returns `WSAEAFNOSUPPORT`](https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-wsasocketw#return-value). It will never skip the test when run in CI but maybe this is me being too defensive since the error code is narrowly scoped to just the af family parameter being unsupported? Also fixed a minor typo. r? `@Mark-Simulacrum`

Skip test if Unix sockets are unsupported

46f68cc

rustbot assigned Mark-Simulacrum Oct 20, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 20, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2023

matthiaskrgr mentioned this pull request Oct 22, 2023

Rollup of 4 pull requests #117041

Merged

bors merged commit 4d80740 into rust-lang:master Oct 22, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 22, 2023

ChrisDenton deleted the skip-unsupported branch October 22, 2023 12:08

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip test if Unix sockets are unsupported #116989

Skip test if Unix sockets are unsupported #116989

ChrisDenton commented Oct 20, 2023

the8472 commented Oct 21, 2023

Mark-Simulacrum commented Oct 21, 2023

bors commented Oct 21, 2023

Skip test if Unix sockets are unsupported #116989

Skip test if Unix sockets are unsupported #116989

Conversation

ChrisDenton commented Oct 20, 2023

the8472 commented Oct 21, 2023

Mark-Simulacrum commented Oct 21, 2023

bors commented Oct 21, 2023