Add target features for LoongArch #116943

heiher · 2023-10-19T14:09:58Z

No description provided.

rustbot · 2023-10-19T14:10:07Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

wesleywiser · 2023-10-19T17:49:05Z

@bors r rollup

bors · 2023-10-19T17:49:08Z

📌 Commit 1df855e has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2023-10-20T07:48:23Z

⌛ Testing commit 1df855e with merge 89fc2e0...

Add target features for LoongArch

bors · 2023-10-20T08:18:47Z

💔 Test failed - checks-actions

heiher · 2023-10-20T08:58:29Z

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

Oops! The ual feature is missed in LLVM 16, it's added from LLVM 17.

Is there a way to skip testing for this feature on LLVM 16? Or I remove ual now and then add it back when time is right.

compiler/rustc_codegen_ssa/src/target_features.rs

heiher · 2023-10-24T06:55:27Z

@wesleywiser RFR

A min-llvm-version is added to abi compatibility tests to skip unsupported versions, and we will not lose any target features now.

wesleywiser · 2023-10-24T14:02:34Z

That seems fine to me. Earlier versions of LLVM don't have great LoongArch support anyway.

@bors r

bors · 2023-10-24T14:02:36Z

📌 Commit 300d04d has been approved by wesleywiser

It is now in the queue for this repository.

Add target features for LoongArch

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116094 (Introduce `-C instrument-coverage=branch` to gate branch coverage) - rust-lang#116396 (Migrate diagnostics in `rustc_hir_analysis/src/coherence/orphan.rs`) - rust-lang#116792 (Avoid unnecessary renumbering during borrowck) - rust-lang#116943 (Add target features for LoongArch) - rust-lang#117010 (Add method to convert internal to stable constructs) - rust-lang#117029 (Add FileCheck annotations to MIR-opt inlining tests ) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116094 (Introduce `-C instrument-coverage=branch` to gate branch coverage) - rust-lang#116396 (Migrate diagnostics in `rustc_hir_analysis/src/coherence/orphan.rs`) - rust-lang#116714 (Derive `Ord`, `PartialOrd` and `Hash` for `SocketAddr*`) - rust-lang#116792 (Avoid unnecessary renumbering during borrowck) - rust-lang#116841 (Suggest unwrap/expect for let binding type mismatch) - rust-lang#116943 (Add target features for LoongArch) - rust-lang#117010 (Add method to convert internal to stable constructs) - rust-lang#117127 (Remove `#[allow(incomplete_features)]` from RPITIT/AFIT tests) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116943 - heiher:target-features, r=wesleywiser Add target features for LoongArch

rustbot assigned wesleywiser Oct 19, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2023

wesleywiser approved these changes Oct 19, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 20, 2023

Auto merge of rust-lang#116943 - heiher:target-features, r=wesleywiser

89fc2e0

Add target features for LoongArch

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2023

heiher force-pushed the target-features branch from 1df855e to b8bb6b2 Compare October 20, 2023 12:05

heiher commented Oct 20, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/target_features.rs Show resolved Hide resolved

heiher requested a review from wesleywiser October 20, 2023 12:06

heiher added 2 commits October 24, 2023 09:36

compiler: Add target features for LoongArch

cb61816

tests: Add features-gate for LoongArch

6cf9423

heiher marked this pull request as draft October 24, 2023 01:46

tests/ui/abi/compatibility: Set min-llvm-version to 17 for LoongArch64

300d04d

heiher force-pushed the target-features branch from b8bb6b2 to 300d04d Compare October 24, 2023 06:05

heiher marked this pull request as ready for review October 24, 2023 06:05

wesleywiser approved these changes Oct 24, 2023

View reviewed changes

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 24, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 24, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 24, 2023

Rollup merge of rust-lang#116943 - heiher:target-features, r=wesleywiser

edba0cb

Add target features for LoongArch

matthiaskrgr mentioned this pull request Oct 24, 2023

Rollup of 6 pull requests #117125

Closed

matthiaskrgr mentioned this pull request Oct 24, 2023

Rollup of 8 pull requests #117135

Merged

bors merged commit 84f0bef into rust-lang:master Oct 24, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 24, 2023

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2023

Unrolled build for rust-lang#116943

3d15547

Rollup merge of rust-lang#116943 - heiher:target-features, r=wesleywiser Add target features for LoongArch

heiher deleted the target-features branch October 25, 2023 01:30

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add target features for LoongArch #116943

Add target features for LoongArch #116943

heiher commented Oct 19, 2023

rustbot commented Oct 19, 2023

wesleywiser commented Oct 19, 2023

bors commented Oct 19, 2023

bors commented Oct 20, 2023

This comment has been minimized.

bors commented Oct 20, 2023

heiher commented Oct 20, 2023 •

edited

Loading

heiher commented Oct 24, 2023

wesleywiser commented Oct 24, 2023

bors commented Oct 24, 2023

Add target features for LoongArch #116943

Add target features for LoongArch #116943

Conversation

heiher commented Oct 19, 2023

rustbot commented Oct 19, 2023

wesleywiser commented Oct 19, 2023

bors commented Oct 19, 2023

bors commented Oct 20, 2023

This comment has been minimized.

bors commented Oct 20, 2023

heiher commented Oct 20, 2023 • edited Loading

heiher commented Oct 24, 2023

wesleywiser commented Oct 24, 2023

bors commented Oct 24, 2023

heiher commented Oct 20, 2023 •

edited

Loading