Rollup of 5 pull requests #116885

aliemjay · 2023-10-18T11:24:53Z

Successful merges:

Disable missing_copy_implementations lint on non_exhaustive types #116812 (Disable missing_copy_implementations lint on non_exhaustive types)
Disable effects in libcore again #116856 (Disable effects in libcore again)
Suggest constraining assoc types in more cases #116865 (Suggest constraining assoc types in more cases)
Don't compare host param by name #116870 (Don't compare host param by name)
revert #114586 #116879 (revert Bubble up opaque <eq> opaque operations instead of picking an order #114586)

r? @ghost
@rustbot modify labels: rollup

use is_variant_list_non_exhaustive/is_field_list_non_exhaustive remove unused tcx inline non_exhaustive def/variant check

Fix rust-lang#46969.

…ons_non_exhaustive, r=petrochenkov Disable missing_copy_implementations lint on non_exhaustive types Fixes rust-lang#116766

Disable effects in libcore again r? `@fee1-dead` This was accidentally allowed by rust-lang#114776 without feature gates

…rrors Suggest constraining assoc types in more cases Fix rust-lang#46969. ``` error[E0308]: mismatched types --> $DIR/suggest-contraining-assoc-type-because-of-assoc-const.rs:12:21 | LL | const N: C::M = 4u8; | ^^^ expected associated type, found `u8` | = note: expected associated type `<C as O>::M` found type `u8` help: consider constraining the associated type `<C as O>::M` to `u8` | LL | impl<C: O<M = u8>> U<C> for u16 { | ```

…, r=fee1-dead Don't compare host param by name Seems sketchy to be searching for `sym::host` by name, especially when we can get the actual index with not very much work. r? fee1-dead

…li-obk revert rust-lang#114586 Reverts rust-lang#114586. cc rust-lang#116877 (not closing until this gets a beta backport) fixes rust-lang#116684 fixes rust-lang#114586 (comment) r? `@oli-obk` or `@lcnr`

aliemjay · 2023-10-18T11:26:22Z

@bors r rollup=never p=5

bors · 2023-10-18T11:26:24Z

📌 Commit 8489bce has been approved by aliemjay

It is now in the queue for this repository.

bors · 2023-10-18T11:55:44Z

⌛ Testing commit 8489bce with merge e1de04a...

bors · 2023-10-18T13:47:55Z

☀️ Test successful - checks-actions
Approved by: aliemjay
Pushing e1de04a to master...

rust-timer · 2023-10-18T13:49:22Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116812	Disable missing_copy_implementations lint on non_exhaustive…	`4d1720e03d8d2e0136309f2af7b6020f26686820` (link)
#116856	Disable effects in libcore again	`309a65e090b50082a4b5df21f1f2ce62a07f1b61` (link)
#116865	Suggest constraining assoc types in more cases	`f4f402ab8229afa1b5292762551b9c33c2918be4` (link)
#116870	Don't compare host param by name	`9712dcaf7a473d9386838ea5195ff50d13d39b3c` (link)
#116879	revert #114586	`83c884d87b987f01c84c1a0ffbf330303a481318` (link)

previous master: e8b8c78d84

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-10-18T15:14:09Z

Finished benchmarking commit (e1de04a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.2%]	9
Improvements ✅ (secondary)	-0.6%	[-0.9%, -0.3%]	13
All ❌✅ (primary)	-0.2%	[-0.5%, 0.5%]	10

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	8.6%	[8.4%, 8.7%]	2
Regressions ❌ (secondary)	2.2%	[0.5%, 3.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-4.1%, -0.7%]	3
All ❌✅ (primary)	8.6%	[8.4%, 8.7%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.5%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	29
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	14
All ❌✅ (primary)	-0.0%	[-0.3%, 0.5%]	34

Bootstrap: 631.223s -> 629.235s (-0.31%)
Artifact size: 304.04 MiB -> 303.99 MiB (-0.02%)

nnethercote · 2023-10-19T00:35:58Z

Improvement outweigh regressions. I wonder which one was responsible. Maybe #116812?

@rustbot label: perf-regression-triaged

rmehri01 and others added 10 commits October 17, 2023 08:33

disable missing_copy_implementations lint on non_exhaustive types

a8e7e79

use is_variant_list_non_exhaustive/is_field_list_non_exhaustive remove unused tcx inline non_exhaustive def/variant check

Disable effects in libcore again

bcdd3d7

Suggest constraining assoc types in more cases

dee86bf

Fix rust-lang#46969.

Don't compare host param by name

9917ef9

revert rust-lang#114586

a1e274f

Rollup merge of rust-lang#116812 - rmehri01:missing_copy_implementati…

0653d7e

…ons_non_exhaustive, r=petrochenkov Disable missing_copy_implementations lint on non_exhaustive types Fixes rust-lang#116766

Rollup merge of rust-lang#116856 - oli-obk:no_effects, r=compiler-errors

a536d58

Disable effects in libcore again r? `@fee1-dead` This was accidentally allowed by rust-lang#114776 without feature gates

Rollup merge of rust-lang#116870 - compiler-errors:host-param-by-name…

42e5f41

…, r=fee1-dead Don't compare host param by name Seems sketchy to be searching for `sym::host` by name, especially when we can get the actual index with not very much work. r? fee1-dead

Rollup merge of rust-lang#116879 - aliemjay:revert-opaque-bubble, r=o…

8489bce

…li-obk revert rust-lang#114586 Reverts rust-lang#114586. cc rust-lang#116877 (not closing until this gets a beta backport) fixes rust-lang#116684 fixes rust-lang#114586 (comment) r? `@oli-obk` or `@lcnr`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 18, 2023

bors merged commit e1de04a into rust-lang:master Oct 18, 2023
12 checks passed

rustbot added this to the 1.75.0 milestone Oct 18, 2023

This was referenced Oct 18, 2023

[WIP] Support param bounds on non-lifetime binders #115362

Draft

make Fn* traits const_trait again #116058

Closed

Use elaboration to turn ~const bounds into non-const bounds #116872

Closed

rustbot added the perf-regression Performance regression. label Oct 18, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 19, 2023

fmease mentioned this pull request Oct 22, 2023

rustdoc: avoid allocating strings primitive link printing #117007

Merged

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #116885

Rollup of 5 pull requests #116885

aliemjay commented Oct 18, 2023

aliemjay commented Oct 18, 2023

bors commented Oct 18, 2023

bors commented Oct 18, 2023

bors commented Oct 18, 2023

rust-timer commented Oct 18, 2023

rust-timer commented Oct 18, 2023

nnethercote commented Oct 19, 2023

Rollup of 5 pull requests #116885

Rollup of 5 pull requests #116885

Conversation

aliemjay commented Oct 18, 2023

aliemjay commented Oct 18, 2023

bors commented Oct 18, 2023

bors commented Oct 18, 2023

bors commented Oct 18, 2023

rust-timer commented Oct 18, 2023

rust-timer commented Oct 18, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

nnethercote commented Oct 19, 2023