Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Support sub-millisecond sleep #116461

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Windows: Support sub-millisecond sleep #116461

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
fca182b
Windows: Support sub-millisecond sleep
ChrisDenton Oct 5, 2023
fbf2567
Miri: Add `CreateWaitableTimerEx` stub
ChrisDenton Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Miri: Add CreateWaitableTimerEx stub 
This function will always fail, allowing std's `Sleep` fallback path to be taken instead.
  • Loading branch information
@ChrisDenton
ChrisDenton committed Oct 6, 2023
commit fbf256716e499d9b2ee15c722c63d90d960f2859
12 changes: 12 additions & 0 deletions src/tools/miri/src/shims/windows/foreign_items.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 267,18 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriInterpCxExt<'mir, 'tcx> {

this.Sleep(timeout)?;
}
"CreateWaitableTimerExW" => {
let [attributes, name, flags, access] =
this.check_shim(abi, Abi::System { unwind: false }, link_name, args)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we do at least read all the arguments of a shim to make sure they are initialized -- or we mark the shim as "only run in std".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've added the reads.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

this.read_pointer(attributes)?;
this.read_pointer(name)?;
this.read_scalar(flags)?.to_u32()?;
this.read_scalar(access)?.to_u32()?;
// Unimplemented. Always return failure.
let not_supported = this.eval_windows("c", "ERROR_NOT_SUPPORTED");
this.set_last_error(not_supported)?;
this.write_null(dest)?;
}

// Synchronization primitives
"AcquireSRWLockExclusive" => {
Expand Down
Loading