Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #115995

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Rollup of 3 pull requests #115995

merged 6 commits into from
Sep 20, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

matthewjasper and others added 6 commits September 19, 2023 12:48
@matthewjasper
Add more if let guard tests
b491402
@eopb
fix confusing let chain indentation in rustc_resolve
2243872
@Mark-Simulacrum @sksat
copy 1.72.1 release notes to master
ed3c63c 
update release date to actual released date
@matthiaskrgr
Rollup merge of rust-lang#115965 - matthewjasper:extra-if-let-guard-t…
3304ea4 
…ests, r=compiler-errors

Add more if let guard tests

cc rust-lang#51114
@matthiaskrgr
Rollup merge of rust-lang#115978 - sksat:copy-1.72.1-release-note-to-…
24fc098 
…master, r=Mark-Simulacrum

Copy 1.72.1 release notes to master

- rust-lang#115976
- this cherry-pick 1.72.1 release note from rust-lang#115787(0414f85)
@matthiaskrgr
Rollup merge of rust-lang#115983 - eopb:confusing-if-chain-indent, r=…
af36ab1 
…compiler-errors

fix confusing let chain indentation in rustc_resolve

Sorry for opening a PR for such a minor style fix.
This just felt sufficiently misleading to warrant fixing.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 20, 2023
@matthiaskrgr
Copy link
Member Author

@bors r rollup=never p=3

@bors
Copy link
Contributor

bors commented Sep 20, 2023

📌 Commit af36ab1 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@bors
Copy link
Contributor

bors commented Sep 20, 2023

⌛ Testing commit af36ab1 with merge 62d9034...

@bors
Copy link
Contributor

bors commented Sep 20, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 62d9034 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2023
@bors bors merged commit 62d9034 into rust-lang:master Sep 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 20, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#115965 Add more if let guard tests 2794d692444881af0c8394bbe4cd9842f0e9700b (link)
#115978 Copy 1.72.1 release notes to master e5b7ca2245a033d2f1fb12d6cda05f46874e75a7 (link)
#115983 fix confusing let chain indentation in rustc_resolve 6df3c5c1ab9e8afe12e50beb0223f44156b0ebdb (link)

previous master: 0e11725809

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Sep 20, 2023
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (62d9034): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -5.0% [-5.0%, -4.9%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.541s -> 631.695s (-0.13%)
Artifact size: 317.85 MiB -> 317.87 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-jukbrvq branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @bors @rust-timer @rustbot @matthewjasper @eopb @Mark-Simulacrum