rustdoc: add test cases, and fix, search tabs layout jank #115988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha Some changes occurred in GUI tests. |
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/search-tab-layout
branch
from
96da64e
to
0adabd8
Compare
notriddle
changed the title
notriddle
force-pushed
the
notriddle/search-tab-layout
branch
4 times, most recently
from
6641bcc
to
a630701
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/search-tab-layout
branch
from
a630701
to
9fbee7d
Compare
| @@ -2334,11 2334,16 @@ ${item.displayPath}<span class="${type}">${name}</span>\ | |||
| } | |||
|
|
|||
| function makeTabHeader(tabNb, text, nbElems) { | |||
| // https://blog.horizon-eda.org/misc/2020/02/19/ui.html | |||
There was a problem hiding this comment.
Very nice read. Could you add a small explanation nonetheless in case the website disappears? Something like \u{2007} is a unicode character the same size as a digit to keep alignment locked.
GuillaumeGomez
approved these changes
Sep 20, 2023
|
Thanks! r=me once CI pass. |
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#115566 (clean up unneeded `ToPredicate` impls) - rust-lang#115962 (coverage: Remove debug code from the instrumentor) - rust-lang#115988 (rustdoc: add test cases, and fix, search tabs layout jank) - rust-lang#115991 (Ensure `build/tmp` exists in `rustdoc_themes::get_themes`) - rust-lang#115997 (RELEASES.md: Add missing patch releases) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 20, 2023
Rollup merge of rust-lang#115988 - notriddle:notriddle/search-tab-layout, r=GuillaumeGomez rustdoc: add test cases, and fix, search tabs layout jank ## Before ### Resizing https://github.com/rust-lang/rust/assets/1593513/24bb5f2b-f6bd-4ed8-91e1-f9ff63d1acee ### Typing https://github.com/rust-lang/rust/assets/1593513/145f53e1-42eb-4b2a-adba-7c9ab44b0aa4 ## After ### Resizing https://github.com/rust-lang/rust/assets/1593513/acc10a55-e83e-43e6-8604-5dfcb9ae3141 ### Typing https://github.com/rust-lang/rust/assets/1593513/09d6d389-e24f-428f-933f-83d9075f15a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Resizing
Screen.Recording.2023-09-19.at.20.36.43.mov
Typing
Screen.Recording.2023-09-19.at.20.44.43.mov
After
Resizing
Screen.Recording.2023-09-19.at.20.50.52.mov
Typing
Screen.Recording.2023-09-19.at.20.49.51.mov