Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ASAN/LSAN/TSAN for *-apple-ios-macabi #115644

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Enable ASAN/LSAN/TSAN for *-apple-ios-macabi #115644

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift click to select a range
4eb1b52
Enable ASAN/LSAN/TSAN for *-apple-ios-macabi
danakj Sep 7, 2023
b7e98e1
Document that the macabi sanitizers are shared with darwin
danakj Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Document that the macabi sanitizers are shared with darwin 
Do not rename and resign the darwin sanitizers a second time for
macabi.
  • Loading branch information
@danakj
danakj committed Sep 18, 2023
commit b7e98e13cdbd6319fab38b6edc233e3d2925d567
5 changes: 3 additions & 2 deletions src/bootstrap/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,13 570,14 @@ fn copy_sanitizers(
let dst = libdir.join(&runtime.name);
builder.copy(&runtime.path, &dst);

// The `aarch64-apple-ios-macabi` and `x86_64-apple-ios-macabi` are also supported for
// sanitizers, but they share a sanitizer runtime with `${arch}-apple-darwin`, so we do
// not list them here to rename and sign the runtime library.
if target == "x86_64-apple-darwin"
|| target == "aarch64-apple-darwin"
|| target == "aarch64-apple-ios"
|| target == "aarch64-apple-ios-sim"
|| target == "aarch64-apple-ios-catalyst"
|| target == "x86_64-apple-ios"
|| target == "x86_64-apple-ios-catalyst"
{
// Update the library’s install name to reflect that it has been renamed.
apple_darwin_update_library_name(&dst, &format!("@rpath/{}", &runtime.name));
Expand Down
Loading