Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for parallel compiler by default #115235

Closed
wants to merge 2 commits into from
Closed

test for parallel compiler by default #115235

wants to merge 2 commits into from

Conversation

SparrowLii
Copy link
Member

test for query cache perf
r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 26, 2023
@SparrowLii SparrowLii marked this pull request as draft August 26, 2023 02:23
@SparrowLii
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 26, 2023
@bors
Copy link
Contributor

bors commented Aug 26, 2023

⌛ Trying commit 6d64962f4cd0b1cf8a9a2254c1e5a0d23937220d with merge bc4ea756b0234e22a2bf9cd864525f05cdd1dbfd...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 26, 2023

☀️ Try build successful - checks-actions
Build commit: bc4ea756b0234e22a2bf9cd864525f05cdd1dbfd (bc4ea756b0234e22a2bf9cd864525f05cdd1dbfd)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bc4ea756b0234e22a2bf9cd864525f05cdd1dbfd): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.9% [0.2%, 4.6%] 213
Regressions ❌
(secondary)		 2.5% [0.4%, 7.6%] 190
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.9% [0.2%, 4.6%] 213

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [0.6%, 3.8%] 9
Regressions ❌
(secondary)		 3.5% [1.6%, 7.5%] 9
Improvements ✅
(primary)		 -1.8% [-2.2%, -1.0%] 3
Improvements ✅
(secondary)		 -4.4% [-9.5%, -1.8%] 8
All ❌✅ (primary) 0.7% [-2.2%, 3.8%] 12

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 7.7% [0.9%, 19.7%] 223
Regressions ❌
(secondary)		 9.0% [1.1%, 42.1%] 221
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 7.7% [0.9%, 19.7%] 223

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.447s -> 664.538s (5.24%)
Artifact size: 315.65 MiB -> 320.47 MiB (1.53%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 26, 2023
@SparrowLii
Copy link
Member Author

test again after #111713
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 31, 2023
@bors
Copy link
Contributor

bors commented Aug 31, 2023

⌛ Trying commit d93b2269bac0ae5b31dd947b636acc838db763b7 with merge 0d19aa3affba579f3a8f545e6755348e654643a4...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Aug 31, 2023

☀️ Try build successful - checks-actions
Build commit: 0d19aa3affba579f3a8f545e6755348e654643a4 (0d19aa3affba579f3a8f545e6755348e654643a4)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0d19aa3affba579f3a8f545e6755348e654643a4): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [0.4%, 5.8%] 222
Regressions ❌
(secondary)		 3.0% [0.5%, 8.4%] 210
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.5% [0.4%, 5.8%] 222

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.7% [0.6%, 3.7%] 6
Regressions ❌
(secondary)		 2.3% [0.7%, 4.5%] 7
Improvements ✅
(primary)		 -1.5% [-2.0%, -1.1%] 3
Improvements ✅
(secondary)		 -3.3% [-6.6%, -1.8%] 6
All ❌✅ (primary) 0.6% [-2.0%, 3.7%] 9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.9% [0.7%, 10.4%] 207
Regressions ❌
(secondary)		 4.3% [1.1%, 9.3%] 167
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.9% [0.7%, 10.4%] 207

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.235s -> 658.306s (4.29%)
Artifact size: 316.59 MiB -> 321.57 MiB (1.57%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 31, 2023
@rustbot rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label Sep 1, 2023
@SparrowLii
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2023
@SparrowLii
Copy link
Member Author

@craterbot run

@craterbot
Copy link
Collaborator

👌 Experiment pr-115235 created and queued.
🤖 Automatically detected try build 5a3d3b9
⚠️ Try build based on commit a9a4dd0, but latest commit is 585a491. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-115235 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-115235 is completed!
📊 237 regressed and 111 fixed (369570 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 19, 2023
@lqd
Copy link
Member

lqd commented Sep 20, 2023

@craterbot run crates=https://crater-reports.s3.amazonaws.com/pr-115235/retry-regressed-list.txt p=1

This is going to be a short run, so p=1 should be acceptable for the short delay for the other PR in the queue.

@craterbot
Copy link
Collaborator

👌 Experiment pr-115235-1 created and queued.
🤖 Automatically detected try build 5a3d3b9
⚠️ Try build based on commit a9a4dd0, but latest commit is 585a491. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-115235-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-115235-1 is completed!
📊 11 regressed and 18 fixed (237 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 21, 2023
@SparrowLii SparrowLii mentioned this pull request Sep 21, 2023
Open
28 tasks
@SparrowLii
Copy link
Member Author

@craterbot run crates=https://crater-reports.s3.amazonaws.com/pr-115235-1/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-115235-2 created and queued.
🤖 Automatically detected try build 5a3d3b9
⚠️ Try build based on commit a9a4dd0, but latest commit is 585a491. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2023
@petrochenkov
Copy link
Contributor

@craterbot p=1

@craterbot
Copy link
Collaborator

📝 Configuration of the pr-115235-2 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-115235-2 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-115235-2 is completed!
📊 7 regressed and 1 fixed (11 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 22, 2023
@bors
Copy link
Contributor

bors commented Oct 10, 2023

☔ The latest upstream changes (presumably #116598) made this pull request unmergeable. Please resolve the merge conflicts.

@SparrowLii SparrowLii mentioned this pull request Oct 11, 2023
Closed
3 tasks
@SparrowLii SparrowLii closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SparrowLii @rust-timer @bors @rust-log-analyzer @craterbot @lqd @petrochenkov @rustbot