Print GHA log groups to stdout instead of stderr #114453

Kobzol · 2023-08-04T08:40:37Z

In all other places (e.g. bootstrap.py, opt-dist), we use stdout instead of stderr. I think that using stderr might be causing some discrepancies in the log, where sometimes the contents of a group "leak" outside the group. Let's see what happens if we use stdout instead. It's possible that it will be worse, since we print most stuff to stderr (?).

r? @ghost

In all other places (e.g. `bootstrap.py`, `opt-dist`), we use stdout instead of stderr. I think that using stderr might be causing some discrepancies in the log, where sometimes the contents of a group "leak" outside the group. Let's see what happens if we use stdout instead. It's possible that it will be worse, since we print most stuff to stderr (?).

Kobzol · 2023-08-04T10:18:33Z

It seems to me that this look a little bit better than before. Compare this PR vs the previous output. It seems to me that less data is leaked out of the groups. But I'll let others decide.

r? bootstrap

onur-ozkan · 2023-08-04T12:10:49Z

It seems slightly cleaner.

I would like to hear more opinions, at least from the bootstrap team. cc @rust-lang/bootstrap

saethlin · 2023-08-05T00:07:28Z

This is probably papering over GitHub's failure to correctly stitch together separately-captured stdout and stderr. I have seen that problem from every CI provider I have used, and I do not know why they all seem to mess this up. You can probably validate that this is the cause by doing exec 2>&1 at the top of a CI script.

Kobzol · 2023-10-02T15:57:36Z

@onur-ozkan Any further opinions on this? :)

onur-ozkan · 2023-10-02T16:33:39Z

@onur-ozkan Any further opinions on this? :)

As I said it seems slightly cleaner/better in my opinion. As there no concern since the team ping, let's land this.

@bors r

bors · 2023-10-02T16:33:41Z

📌 Commit 88b9985 has been approved by onur-ozkan

It is now in the queue for this repository.

bors · 2023-10-02T19:37:43Z

⌛ Testing commit 88b9985 with merge 6e53a1d...

Print GHA log groups to stdout instead of stderr In all other places (e.g. `bootstrap.py`, `opt-dist`), we use stdout instead of stderr. I think that using stderr might be causing some discrepancies in the log, where sometimes the contents of a group "leak" outside the group. Let's see what happens if we use stdout instead. It's possible that it will be worse, since we print most stuff to stderr (?). r? `@ghost`

tmandry · 2023-10-02T20:10:19Z

@bors retry

Rollup of 5 pull requests Successful merges: - rust-lang#114453 (Print GHA log groups to stdout instead of stderr) - rust-lang#114454 (Replace `HashMap` with `IndexMap` in pattern binding resolve ) - rust-lang#116289 (Add missing #[inline] on AsFd impl for sys::unix::fs::File) - rust-lang#116349 (ensure the parent path's existence on `x install`) - rust-lang#116350 (Improve wording of `hint::black_box` docs) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2023-10-02T20:14:25Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Rollup merge of rust-lang#114453 - Kobzol:ci-group-stdout, r=onur-ozkan Print GHA log groups to stdout instead of stderr In all other places (e.g. `bootstrap.py`, `opt-dist`), we use stdout instead of stderr. I think that using stderr might be causing some discrepancies in the log, where sometimes the contents of a group "leak" outside the group. Let's see what happens if we use stdout instead. It's possible that it will be worse, since we print most stuff to stderr (?). r? `@ghost`

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2023

Kobzol marked this pull request as ready for review August 4, 2023 10:17

rustbot assigned onur-ozkan Aug 4, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2023

tmandry mentioned this pull request Oct 2, 2023

Rollup of 5 pull requests #116356

Merged

bors merged commit 14f6249 into rust-lang:master Oct 2, 2023
11 of 12 checks passed

rustbot added this to the 1.75.0 milestone Oct 2, 2023

Kobzol deleted the ci-group-stdout branch October 3, 2023 05:24

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print GHA log groups to stdout instead of stderr #114453

Print GHA log groups to stdout instead of stderr #114453

Kobzol commented Aug 4, 2023

Kobzol commented Aug 4, 2023

onur-ozkan commented Aug 4, 2023

saethlin commented Aug 5, 2023 •

edited

Loading

Kobzol commented Oct 2, 2023

onur-ozkan commented Oct 2, 2023 •

edited

Loading

bors commented Oct 2, 2023

bors commented Oct 2, 2023

tmandry commented Oct 2, 2023

rust-log-analyzer commented Oct 2, 2023

Print GHA log groups to stdout instead of stderr #114453

Print GHA log groups to stdout instead of stderr #114453

Conversation

Kobzol commented Aug 4, 2023

Kobzol commented Aug 4, 2023

onur-ozkan commented Aug 4, 2023

saethlin commented Aug 5, 2023 • edited Loading

Kobzol commented Oct 2, 2023

onur-ozkan commented Oct 2, 2023 • edited Loading

bors commented Oct 2, 2023

bors commented Oct 2, 2023

tmandry commented Oct 2, 2023

rust-log-analyzer commented Oct 2, 2023

saethlin commented Aug 5, 2023 •

edited

Loading

onur-ozkan commented Oct 2, 2023 •

edited

Loading